#{ERB::Util.html_escape(title)}
" + end + + def youtube_url(row) + (clean(row["story_youtube_url"]).presence || clean(row["story_youtube_ur"]).presence) + end + + def author_credit(row) + AUTHOR_CREDIT_BY_SHOWHIDE[clean(row["showhide_the_name"])] || DEFAULT_AUTHOR_CREDIT + end + + def published?(row) + clean(row["Status"]).casecmp?(PUBLISHED_WP_STATUS) + end + + def persist(record) + return true if @dry_run + record.save! + true + rescue ActiveRecord::RecordInvalid => e + @logger.error("[StoryImporter] invalid #{record.class}: #{e.message}") + false + end + + def default_organization_status + OrganizationStatus.find_by(name: "Pending") || OrganizationStatus.first + end + + def wp_id(row) + clean(row["ID"]).presence || "?" + end + + def truthy?(value) + %w[1 true yes].include?(clean(value).to_s.downcase) + end + + # WordPress export encodes entities (e.g. &) even in plain-text columns. + def clean(value) + CGI.unescapeHTML(value.to_s).strip + end + + # Content columns are already HTML; only decode double-encoded entities. + def clean_html(value) + value.to_s.strip + end + + def record_skip(row, reason) + @result.skipped << "row #{wp_id(row)} (#{clean(row['Title'])}): #{reason}" + nil + end + + def record_warning(row, reason) + @result.warnings << "row #{wp_id(row)} (#{clean(row['Title'])}): #{reason}" + nil + end +end diff --git a/app/views/stories/index.html.erb b/app/views/stories/index.html.erb index 6c17afc974..87af5655a5 100644 --- a/app/views/stories/index.html.erb +++ b/app/views/stories/index.html.erb @@ -9,7 +9,12 @@Check out stories from Windows Facilitators around the world and the healing they make possible through art
-+ Reviewing <%= @filename %>. + Nothing has been saved yet — confirm below to run the import. +
+ +…and <%= @result.warnings.size - 100 %> more.
+ <% end %> ++ This will create <%= pluralize(@result.ideas_created, "story idea") %> + and <%= pluralize(@result.stories_created, "connected story") %>. +
++ Upload a WordPress Posts Export CSV. We'll create a story idea for every row and a + connected, published story for rows that were public on WordPress. You'll see a + preview of exactly what will be created before anything is saved. +
+ +A published story.
,publish,Test Org,Adult Windows Workshop,Adults,Domestic Violence,display_full_name,California,Jane,2021-07-11 10:07:53 +102,Finding my voice,Another published story.
,publish,Test Org,Heart Stories,Children,Mental Health,hide_full_name,Florida,Maria,2022-03-02 09:00:00 +103,A work in progress,A draft.
,draft,Test Org,,Adults,Self-Care & Personal Growth,display_first_name,Oregon,Sam,2023-01-15 12:00:00 diff --git a/spec/requests/story_imports_spec.rb b/spec/requests/story_imports_spec.rb new file mode 100644 index 0000000000..3c2de4914f --- /dev/null +++ b/spec/requests/story_imports_spec.rb @@ -0,0 +1,117 @@ +require "rails_helper" + +RSpec.describe "Story imports", type: :request do + let(:admin) { create(:user, :admin) } + let(:regular_user) { create(:user) } + + # Reference data the importer needs to resolve rows. + before do + create(:windows_type, :adult) + create(:windows_type, :children) + create(:windows_type, :combined) + create(:organization_status, name: "Pending") + end + + let(:csv) { fixture_file_upload("spec/fixtures/files/stories_import.csv", "text/csv") } + + def signed_blob_for_fixture + ActiveStorage::Blob.create_and_upload!( + io: Rails.root.join("spec/fixtures/files/stories_import.csv").open, + filename: "stories_import.csv", + content_type: "text/csv" + ).signed_id + end + + describe "GET /stories/import/new" do + it "renders the upload form for admins" do + sign_in admin + get new_story_import_path + + expect(response).to be_successful + expect(response.body).to include("Import stories from CSV") + end + + it "redirects non-admins" do + sign_in regular_user + get new_story_import_path + + expect(response).to redirect_to(root_path) + end + + it "redirects guests to sign in" do + get new_story_import_path + + expect(response).to redirect_to(new_user_session_path) + end + end + + describe "POST /stories/import (preview)" do + before { sign_in admin } + + it "shows a dry-run preview without creating records" do + post story_import_path, params: { file: csv } + + expect(StoryIdea.count).to eq(0) + expect(Story.count).to eq(0) + expect(response).to be_successful + expect(response.body).to include("Preview import") + expect(response.body).to include("Connected stories") + end + + it "stashes the file as a blob so it can be confirmed" do + expect { + post story_import_path, params: { file: csv } + }.to change(ActiveStorage::Blob, :count).by(1) + end + + it "redirects with an alert when no file is given" do + post story_import_path, params: {} + + expect(response).to redirect_to(new_story_import_path) + expect(flash[:alert]).to match(/choose a csv/i) + end + + it "rejects non-CSV uploads" do + upload = fixture_file_upload("spec/fixtures/files/stories_import.csv", "image/png") + allow(upload).to receive(:original_filename).and_return("avatar.png") + + post story_import_path, params: { file: upload } + + expect(response).to redirect_to(new_story_import_path) + expect(flash[:alert]).to match(/not a csv/i) + end + + it "is forbidden for non-admins" do + sign_in regular_user + post story_import_path, params: { file: csv } + + expect(response).to redirect_to(root_path) + end + end + + describe "POST /stories/import/confirm" do + before { sign_in admin } + + it "creates ideas for every row and stories for published rows" do + expect { + post confirm_story_import_path, params: { signed_id: signed_blob_for_fixture } + }.to change(StoryIdea, :count).by(3).and change(Story, :count).by(2) + + expect(response).to redirect_to(stories_path) + expect(flash[:notice]).to match(/3 story ideas and 2 connected stories/) + end + + it "records the importing admin as the creator" do + post confirm_story_import_path, params: { signed_id: signed_blob_for_fixture } + + expect(Story.last.created_by).to eq(admin) + end + + it "redirects with an alert when the upload is gone" do + post confirm_story_import_path, params: { signed_id: "bogus" } + + expect(response).to redirect_to(new_story_import_path) + expect(flash[:alert]).to match(/no longer available/i) + end + end +end diff --git a/spec/services/story_importer_spec.rb b/spec/services/story_importer_spec.rb new file mode 100644 index 0000000000..f42217012f --- /dev/null +++ b/spec/services/story_importer_spec.rb @@ -0,0 +1,161 @@ +require "rails_helper" +require "csv" + +RSpec.describe StoryImporter do + let(:import_user) { create(:user) } + let!(:pending_status) { create(:organization_status, name: "Pending") } + let!(:adult_wt) { create(:windows_type, :adult) } + let!(:children_wt) { create(:windows_type, :children) } + let!(:combined_wt) { create(:windows_type, :combined) } + + # Minimal subset of the WordPress export columns the importer reads. + let(:headers) do + %w[ + ID Title Content Excerpt Status organization_name story_workshop_name + story_youtube_url showhide_the_name Tags Categories state + facilitator_name facilitator_last_name home_top_featured_story Date + ] + end + + # Held in an array so the Tempfiles aren't garbage-collected (and deleted) + # before the importer reads them. + let(:tempfiles) { [] } + + def csv_file(rows) + file = Tempfile.new([ "stories", ".csv" ]) + tempfiles << file + CSV.open(file.path, "w", write_headers: true, headers: headers) do |csv| + rows.each { |row| csv << headers.map { |h| row[h] } } + end + file.path + end + + def base_row(overrides = {}) + { + "ID" => "1", + "Title" => "A story of healing", + "Content" => "Once upon a time.
", + "Status" => "publish", + "organization_name" => "A Greater Hope", + "story_workshop_name" => "Adult Windows Workshop", + "Tags" => "Adults", + "Categories" => "Domestic Violence", + "showhide_the_name" => "display_full_name" + }.merge(overrides) + end + + def import(rows, **opts) + described_class.new(csv_path: csv_file(rows), import_user: import_user, **opts).call + end + + it "creates a story idea for every row" do + result = import([ base_row, base_row("ID" => "2", "Title" => "Second", "organization_name" => "New Leaf") ]) + + expect(result.ideas_created).to eq(2) + expect(StoryIdea.count).to eq(2) + end + + it "creates a connected published story for published rows" do + import([ base_row ]) + + story = Story.sole + expect(story.published).to be(true) + expect(story.publicly_visible).to be(true) + expect(story.story_idea).to eq(StoryIdea.sole) + expect(story.title).to eq("A story of healing") + end + + it "does not create a story for draft rows" do + result = import([ base_row("Status" => "draft") ]) + + expect(result.ideas_created).to eq(1) + expect(result.stories_created).to eq(0) + expect(Story.count).to eq(0) + end + + it "maps showhide_the_name to author_credit_preference" do + import([ base_row("showhide_the_name" => "hide_full_name") ]) + + expect(StoryIdea.sole.author_credit_preference).to eq("anonymous") + end + + it "decodes HTML entities in the organization name and reuses the org" do + import([ + base_row("ID" => "1", "organization_name" => "Smith & Co"), + base_row("ID" => "2", "Title" => "Another", "organization_name" => "Smith & Co") + ]) + + expect(Organization.where("LOWER(name) = ?", "smith & co").count).to eq(1) + end + + it "derives windows type from audience tags" do + import([ + base_row("ID" => "1", "Title" => "Kids", "Tags" => "Children"), + base_row("ID" => "2", "Title" => "Grown", "Tags" => "Adults"), + base_row("ID" => "3", "Title" => "Both", "Tags" => "Families") + ]) + + expect(StoryIdea.find_by(title: "Kids").windows_type).to eq(children_wt) + expect(StoryIdea.find_by(title: "Grown").windows_type).to eq(adult_wt) + expect(StoryIdea.find_by(title: "Both").windows_type).to eq(combined_wt) + end + + it "tags a matching sector via the synonym map" do + sector = create(:sector, name: "Domestic Violence") + import([ base_row("Categories" => "Domestic Violence") ]) + + expect(StoryIdea.sole.sectors).to include(sector) + expect(Story.sole.sectors).to include(sector) + end + + it "warns when a category has no matching sector" do + result = import([ base_row("Categories" => "Self-Care & Personal Growth") ]) + + expect(result.warnings).to include(a_string_matching(/no Sector match/)) + expect(StoryIdea.sole.sectors).to be_empty + end + + it "warns about unmapped fields rather than dropping them" do + result = import([ base_row("state" => "California", "facilitator_name" => "Eydie") ]) + + expect(result.warnings).to include(a_string_matching(/unmapped state "California"/)) + expect(result.warnings).to include(a_string_matching(/unmapped facilitator "Eydie"/)) + end + + it "skips a published story whose title is already taken but still keeps the idea" do + create(:story, title: "A story of healing") + result = import([ base_row ]) + + expect(result.ideas_created).to eq(1) + expect(result.stories_created).to eq(0) + expect(result.warnings).to include(a_string_matching(/title already taken/)) + end + + it "is idempotent for story ideas across re-runs" do + rows = [ base_row("Status" => "draft") ] + import(rows) + result = import(rows) + + expect(result.ideas_created).to eq(0) + expect(result.skipped).to include(a_string_matching(/already exists/)) + expect(StoryIdea.count).to eq(1) + end + + it "skips rows with a blank title" do + result = import([ base_row("Title" => "") ]) + + expect(result.skipped).to include(a_string_matching(/blank title/)) + expect(StoryIdea.count).to eq(0) + end + + describe "dry run" do + it "writes nothing but reports what would be created" do + result = import([ base_row ], dry_run: true) + + expect(StoryIdea.count).to eq(0) + expect(Story.count).to eq(0) + expect(result.ideas_created).to eq(1) + expect(result.stories_created).to eq(1) + end + end +end