prettyprint_node function is too large for Chicory AOT

[headius]

The prettyprint_node function in prettyprint.c is almost 9000 lines long. This is far too big for Chicory's WASM-to-JVM compiler to cope with:

[ERROR] Failed to execute goal com.dylibso.chicory:chicory-compiler-maven-plugin:1.6.1:compile (prism) on project prism-parser-wasm: Execution prism of goal com.dylibso.chicory:chicory-compiler-maven-plugin:1.6.1:compile failed: WASM function size exceeds the Java method size limits and cannot be compiled to Java bytecode. It can only be run in the interpreter. Either reduce the size of the function or enable the interpreter fallback mode: WASM function index: 290 (name: prettyprint_node): Method too large: org/ruby_lang/prism/wasm/PrismParserMachineFuncGroup_0.func_290 (IIIILcom/dylibso/chicory/runtime/Memory;Lcom/dylibso/chicory/runtime/Instance;)V -> [Help 1]

Is there any reason we couldn't split this up into a few smaller methods, perhaps by moving the switch bodies and other grouped chunks of code to other functions?

[headius]

I see the JavaScript WASM build also excludes pretty printing, so perhaps this is not just a problem for Chicory.

[kddnewton]

Can we exclude it? It's a C API that isn't exposed through FFI (it's really only used by CRuby for --dump=parsetree). The main inspect is written in Ruby.

[headius]

@kddnewton Oh, if it's not necessary for the operation of the gem then it's not a problem. There's already a build variable to exclude it, I was just trying to go for total coverage .

If there's no other value in splitting that function up then this could be closed.