Fix combobox problems (#241)

stephannv · web-flow · commit 059c0e765607 · 2025-03-25T15:30:21.000-03:00
diff --git a/lib/ruby_ui/combobox/combobox_controller.js b/lib/ruby_ui/combobox/combobox_controller.js
@@ -25,7 +25,7 @@ export default class extends Controller {
   }
 
   disconnect() {
-    this.cleanup();
+    if (this.cleanup) { this.cleanup() }
   }
 
   inputChanged(e) {
@@ -41,7 +41,7 @@ export default class extends Controller {
   }
 
   inputContent(input) {
-    return input.dataset.text || input.parentElement.innerText
+    return input.dataset.text || input.parentElement.textContent
   }
 
   toggleAllItems() {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export default class extends Controller {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`disconnect() {`
`28`		`- this.cleanup();`
	`28`	`+ if (this.cleanup) { this.cleanup() }`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`inputChanged(e) {`
`@@ -41,7 +41,7 @@ export default class extends Controller {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`inputContent(input) {`
`44`		`- return input.dataset.text \|\| input.parentElement.innerText`
	`44`	`+ return input.dataset.text \|\| input.parentElement.textContent`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`toggleAllItems() {`