Skip to content

Commit 86d4b32

Browse files
yahondaclaude
andcommitted
Address review feedback on hidden columns test
- Make setup idempotent by dropping objects before creating them - Rename local variable proc to procedure to avoid ambiguity Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3759bfc commit 86d4b32

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

spec/plsql/procedure_spec.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2389,6 +2389,8 @@ def new_candidate(status)
23892389
describe "Procedure with %ROWTYPE parameter on table that has hidden columns" do
23902390
before(:all) do
23912391
plsql.connect! CONNECTION_PARAMS
2392+
plsql.execute "DROP PACKAGE test_hidden_cols_pkg" rescue nil
2393+
plsql.execute "DROP TABLE test_hidden_cols" rescue nil
23922394
plsql.execute "CREATE TABLE test_hidden_cols (col1 VARCHAR2(50), col2 VARCHAR2(50))"
23932395
# Functional index creates a hidden column in ALL_TAB_COLS
23942396
plsql.execute "CREATE INDEX test_hidden_cols_idx ON test_hidden_cols (UPPER(col1))"
@@ -2414,8 +2416,8 @@ def new_candidate(status)
24142416
end
24152417

24162418
it "should not include hidden columns in %ROWTYPE fields" do
2417-
proc = PLSQL::Procedure.find(plsql, :test_proc, "TEST_HIDDEN_COLS_PKG")
2418-
fields = proc.arguments[0][:p_rec][:fields]
2419+
procedure = PLSQL::Procedure.find(plsql, :test_proc, "TEST_HIDDEN_COLS_PKG")
2420+
fields = procedure.arguments[0][:p_rec][:fields]
24192421
field_names = fields.keys
24202422
expect(field_names).to include(:col1)
24212423
expect(field_names).to include(:col2)

0 commit comments

Comments
 (0)