Skip to content

vcs repos file existence check fails on Windows #229

@jacobperron

Description

@jacobperron

Description

I'm trying to point vcs-repo-file-url to a repos file that exists in the root of the same repository as where the action is being run. e.g.:

    vcs-repo-file-url: |
            https://raw.githubusercontent.com/ros2/ros2/dashing/ros2.repos
            "${{ github.workspace }}\ros2_java_desktop.repos"

But, curl fails since the necessary file:// prefix is not being appended by the action.

Expected Behavior

file:// is appended by the logic here:

if (fs.existsSync(vcsRepoFileUrl)) {
return "file://" + path.resolve(vcsRepoFileUrl);
} else {

and curl succeeds.

Actual Behavior

curl fails. For example.

To Reproduce

See example workflow in ros2-java/ros2_java#109.

System (please complete the following information)

  • OS: Windows
  • ROS 2 Distro: Dashing

Additional context

I'm not sure if this is user error, or a bug related to the use of fs.existsSync on Windows.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions