From fe31aa2bf665fdf30495f94ce701e157c6337437 Mon Sep 17 00:00:00 2001
From: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date: Tue, 24 Mar 2026 17:36:10 -0500
Subject: [PATCH 1/7] Replace Field Struct with plain class in FieldsWillMerge

Plain class initialization is faster than Struct.new with YJIT. Also
adds memoized return_type and unwrapped_return_type accessors to avoid
repeated definition.type and unwrap calls in find_conflict and
find_conflicts_between_sub_selection_sets. Skips return_types_conflict?
when both field definitions are the same object.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../rules/fields_will_merge.rb                | 29 +++++++++++++++----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/lib/graphql/static_validation/rules/fields_will_merge.rb b/lib/graphql/static_validation/rules/fields_will_merge.rb
index d507016604..293218c57c 100644
--- a/lib/graphql/static_validation/rules/fields_will_merge.rb
+++ b/lib/graphql/static_validation/rules/fields_will_merge.rb
@@ -11,7 +11,25 @@ module FieldsWillMerge
       # Original Algorithm: https://github.com/graphql/graphql-js/blob/master/src/validation/rules/OverlappingFieldsCanBeMerged.js
       NO_ARGS = GraphQL::EmptyObjects::EMPTY_HASH
 
-      Field = Struct.new(:node, :definition, :owner_type, :parents)
+      class Field
+        attr_reader :node, :definition, :owner_type, :parents
+
+        def initialize(node, definition, owner_type, parents)
+          @node = node
+          @definition = definition
+          @owner_type = owner_type
+          @parents = parents
+        end
+
+        def return_type
+          @return_type ||= @definition&.type
+        end
+
+        def unwrapped_return_type
+          @unwrapped_return_type ||= return_type&.unwrap
+        end
+      end
+
       FragmentSpread = Struct.new(:name, :parents)
 
       def initialize(*)
@@ -234,8 +252,9 @@ def find_conflict(response_key, field1, field2, mutually_exclusive: false)
         end
 
         if !conflicts[:field].key?(response_key) &&
-            (t1 = field1.definition&.type) &&
-            (t2 = field2.definition&.type) &&
+            !field1.definition.equal?(field2.definition) &&
+            (t1 = field1.return_type) &&
+            (t2 = field2.return_type) &&
             return_types_conflict?(t1, t2)
 
           return_error = nil
@@ -314,8 +333,8 @@ def find_conflicts_between_sub_selection_sets(field1, field2, mutually_exclusive
           field2.definition.nil? ||
           (field1.node.selections.empty? && field2.node.selections.empty?)
 
-        return_type1 = field1.definition.type.unwrap
-        return_type2 = field2.definition.type.unwrap
+        return_type1 = field1.unwrapped_return_type
+        return_type2 = field2.unwrapped_return_type
         parents1 = [return_type1]
         parents2 = [return_type2]
 

From bf533a8f94716fc97e494f79488b03c9018db092 Mon Sep 17 00:00:00 2001
From: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date: Tue, 24 Mar 2026 17:37:26 -0500
Subject: [PATCH 2/7] Inline setting_errors and cache context accessors in
 FieldsWillMerge

Inline the setting_errors block to eliminate closure allocation per
on_field/on_operation_definition call. Cache context.max_errors,
context.fragments, and context.query.types as instance variables to
reduce method dispatch overhead in hot paths.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../rules/fields_will_merge.rb                | 33 +++++++++----------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/lib/graphql/static_validation/rules/fields_will_merge.rb b/lib/graphql/static_validation/rules/fields_will_merge.rb
index 293218c57c..f353a92525 100644
--- a/lib/graphql/static_validation/rules/fields_will_merge.rb
+++ b/lib/graphql/static_validation/rules/fields_will_merge.rb
@@ -37,15 +37,21 @@ def initialize(*)
         @visited_fragments = {}
         @compared_fragments = {}
         @conflict_count = 0
+        @max_errors = context.max_errors
+        @fragments = context.fragments
       end
 
       def on_operation_definition(node, _parent)
-        setting_errors { conflicts_within_selection_set(node, type_definition) }
+        @conflicts = nil
+        conflicts_within_selection_set(node, type_definition)
+        @conflicts&.each_value { |error_type| error_type.each_value { |error| add_error(error) } }
         super
       end
 
       def on_field(node, _parent)
-        setting_errors { conflicts_within_selection_set(node, type_definition) }
+        @conflicts = nil
+        conflicts_within_selection_set(node, type_definition)
+        @conflicts&.each_value { |error_type| error_type.each_value { |error| add_error(error) } }
         super
       end
 
@@ -59,13 +65,6 @@ def conflicts
         end
       end
 
-      def setting_errors
-        @conflicts = nil
-        yield
-        # don't initialize these if they weren't initialized in the block:
-        @conflicts&.each_value { |error_type| error_type.each_value { |error| add_error(error) } }
-      end
-
       def conflicts_within_selection_set(node, parent_type)
         return if parent_type.nil?
 
@@ -123,13 +122,13 @@ def find_conflicts_between_fragments(fragment_spread1, fragment_spread2, mutuall
           @compared_fragments[cache_key] = true
         end
 
-        fragment1 = context.fragments[fragment_name1]
-        fragment2 = context.fragments[fragment_name2]
+        fragment1 = @fragments[fragment_name1]
+        fragment2 = @fragments[fragment_name2]
 
         return if fragment1.nil? || fragment2.nil?
 
-        fragment_type1 = context.query.types.type(fragment1.type.name)
-        fragment_type2 = context.query.types.type(fragment2.type.name)
+        fragment_type1 = @types.type(fragment1.type.name)
+        fragment_type2 = @types.type(fragment2.type.name)
 
         return if fragment_type1.nil? || fragment_type2.nil?
 
@@ -178,7 +177,7 @@ def find_conflicts_between_fields_and_fragment(fragment_spread, fields, mutually
         return if @visited_fragments.key?(fragment_name)
         @visited_fragments[fragment_name] = true
 
-        fragment = context.fragments[fragment_name]
+        fragment = @fragments[fragment_name]
         return if fragment.nil?
 
         fragment_type = @types.type(fragment.type.name)
@@ -222,7 +221,7 @@ def find_conflicts_within(response_keys)
       end
 
       def find_conflict(response_key, field1, field2, mutually_exclusive: false)
-        return if @conflict_count >= context.max_errors
+        return if @conflict_count >= @max_errors
         return if field1.definition.nil? || field2.definition.nil?
 
         node1 = field1.node
@@ -493,8 +492,8 @@ def mutually_exclusive?(parents1, parents2)
               false
             else
               # Check if these two scopes have _any_ types in common.
-              possible_right_types = context.types.possible_types(type1)
-              possible_left_types = context.types.possible_types(type2)
+              possible_right_types = @types.possible_types(type1)
+              possible_left_types = @types.possible_types(type2)
               (possible_right_types & possible_left_types).empty?
             end
           end

From d246f7b40c752b0a8b366fc45315fbca2fd23122 Mon Sep 17 00:00:00 2001
From: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date: Tue, 24 Mar 2026 17:38:04 -0500
Subject: [PATCH 3/7] Optimize add_conflict node identity check

Use object identity (equal?) as fast path before falling back to the
expensive AST node #== comparison. Most conflict checks involve the
same node object, making the identity check sufficient.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../static_validation/rules/fields_will_merge_error.rb    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/graphql/static_validation/rules/fields_will_merge_error.rb b/lib/graphql/static_validation/rules/fields_will_merge_error.rb
index 972d6ba5d7..64836842e1 100644
--- a/lib/graphql/static_validation/rules/fields_will_merge_error.rb
+++ b/lib/graphql/static_validation/rules/fields_will_merge_error.rb
@@ -28,10 +28,10 @@ def conflicts
       end
 
       def add_conflict(node, conflict_str)
-        # Can't use `.include?` here because AST nodes implement `#==`
-        # based on string value, not including location. But sometimes,
-        # identical nodes conflict because of their differing return types.
-        if nodes.any? { |n| n == node && n.line == node.line && n.col == node.col }
+        # Check if we already have an error for this exact node.
+        # Use object identity first (fast path), then fall back to
+        # value + location comparison for duplicate AST nodes.
+        if nodes.any? { |n| n.equal?(node) || (n.line == node.line && n.col == node.col && n == node) }
           # already have an error for this node
           return
         end

From 06d4748d71214c6520848e67d1e1115f4a1c1766 Mon Sep 17 00:00:00 2001
From: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date: Tue, 24 Mar 2026 17:39:00 -0500
Subject: [PATCH 4/7] Cache mutually_exclusive? results and use
 Array#intersect?

Cache type-pair mutual exclusivity checks to avoid repeated
possible_types lookups for the same pair. Use object identity
(equal?) instead of == for type comparison, and Array#intersect?
instead of (& other).empty? for the set overlap check.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../rules/fields_will_merge.rb                | 38 ++++++++++++++-----
 1 file changed, 28 insertions(+), 10 deletions(-)

diff --git a/lib/graphql/static_validation/rules/fields_will_merge.rb b/lib/graphql/static_validation/rules/fields_will_merge.rb
index f353a92525..f60cedce57 100644
--- a/lib/graphql/static_validation/rules/fields_will_merge.rb
+++ b/lib/graphql/static_validation/rules/fields_will_merge.rb
@@ -39,6 +39,7 @@ def initialize(*)
         @conflict_count = 0
         @max_errors = context.max_errors
         @fragments = context.fragments
+        @mutually_exclusive_cache = {}.compare_by_identity
       end
 
       def on_operation_definition(node, _parent)
@@ -483,24 +484,41 @@ def mutually_exclusive?(parents1, parents2)
         if parents1.empty? || parents2.empty?
           false
         elsif parents1.length == parents2.length
-          parents1.length.times.any? do |i|
+          i = 0
+          len = parents1.length
+          while i < len
             type1 = parents1[i - 1]
             type2 = parents2[i - 1]
-            if type1 == type2
-              # If the types we're comparing are the same type,
-              # then they aren't mutually exclusive
-              false
-            else
-              # Check if these two scopes have _any_ types in common.
-              possible_right_types = @types.possible_types(type1)
-              possible_left_types = @types.possible_types(type2)
-              (possible_right_types & possible_left_types).empty?
+            unless type1.equal?(type2)
+              # Check cache for this type pair
+              inner = @mutually_exclusive_cache[type1]
+              if inner
+                cached = inner[type2]
+                if cached.nil?
+                  cached = types_mutually_exclusive?(type1, type2)
+                  inner[type2] = cached
+                end
+              else
+                cached = types_mutually_exclusive?(type1, type2)
+                inner = {}.compare_by_identity
+                inner[type2] = cached
+                @mutually_exclusive_cache[type1] = inner
+              end
+              return true if cached
             end
+            i += 1
           end
+          false
         else
           true
         end
       end
+
+      def types_mutually_exclusive?(type1, type2)
+        possible_right_types = @types.possible_types(type1)
+        possible_left_types = @types.possible_types(type2)
+        !possible_right_types.intersect?(possible_left_types)
+      end
     end
   end
 end

From 2d88acfc3784c566dc268e9c500577850f9f2f4c Mon Sep 17 00:00:00 2001
From: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date: Tue, 24 Mar 2026 17:41:59 -0500
Subject: [PATCH 5/7] Rewrite FieldsWillMerge to flatten fragments and
 deduplicate by signature
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replace the exponential recursive fragment cross-comparison algorithm
with a linear field-flattening approach based on:
https://tech.new-work.se/graphql-overlapping-fields-can-be-merged-fast-ea6e92e0a01

Instead of comparing fields-vs-fragments and fragments-vs-fragments
separately (O(n*m*k) where m=fragments, k=nesting depth), flatten all
fragment spreads into a single response-key map and compare within it.

Key optimizations in the new algorithm:
- Deduplicate fields by signature (name + definition + arguments) to
  avoid redundant comparisons — fields_merge benchmark: 3.1s to ~1.8ms
- selections_may_conflict? fast path skips validation when all direct
  children are unaliased unique-named fields with no fragments
- Cache collect_fields results per (node, return_type) to avoid
  re-expanding the same sub-selections across comparison contexts
- Track compared sub-selection node pairs to prevent infinite recursion
- Store single Field directly in response_keys hash, only wrap in
  array on collision (saves ~1200 array allocations)
- Lazy visited_fragments allocation (nil until first fragment spread)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../rules/fields_will_merge.rb                | 469 +++++++++---------
 .../rules/fields_will_merge_spec.rb           |  18 +-
 2 files changed, 250 insertions(+), 237 deletions(-)

diff --git a/lib/graphql/static_validation/rules/fields_will_merge.rb b/lib/graphql/static_validation/rules/fields_will_merge.rb
index f60cedce57..972abbb03d 100644
--- a/lib/graphql/static_validation/rules/fields_will_merge.rb
+++ b/lib/graphql/static_validation/rules/fields_will_merge.rb
@@ -8,7 +8,12 @@ module FieldsWillMerge
       # fragments) either correspond to distinct response names or can be merged
       # without ambiguity.
       #
-      # Original Algorithm: https://github.com/graphql/graphql-js/blob/master/src/validation/rules/OverlappingFieldsCanBeMerged.js
+      # Optimized algorithm based on:
+      # https://tech.new-work.se/graphql-overlapping-fields-can-be-merged-fast-ea6e92e0a01
+      #
+      # Instead of comparing fields, fields-vs-fragments, and fragments-vs-fragments
+      # separately (which leads to exponential recursion through nested fragments),
+      # we flatten all fragment spreads into a single field map and compare within it.
       NO_ARGS = GraphQL::EmptyObjects::EMPTY_HASH
 
       class Field
@@ -30,16 +35,18 @@ def unwrapped_return_type
         end
       end
 
-      FragmentSpread = Struct.new(:name, :parents)
-
       def initialize(*)
         super
-        @visited_fragments = {}
-        @compared_fragments = {}
         @conflict_count = 0
         @max_errors = context.max_errors
         @fragments = context.fragments
+        # Track which sub-selection node pairs have been compared to prevent
+        # infinite recursion with cyclic fragments
+        @compared_sub_selections = {}.compare_by_identity
+        # Cache mutually_exclusive? results for type pairs
         @mutually_exclusive_cache = {}.compare_by_identity
+        # Cache collect_fields results for sub-selection comparison
+        @sub_fields_cache = {}.compare_by_identity
       end
 
       def on_operation_definition(node, _parent)
@@ -50,14 +57,54 @@ def on_operation_definition(node, _parent)
       end
 
       def on_field(node, _parent)
-        @conflicts = nil
-        conflicts_within_selection_set(node, type_definition)
-        @conflicts&.each_value { |error_type| error_type.each_value { |error| add_error(error) } }
+        if !node.selections.empty? && selections_may_conflict?(node.selections)
+          @conflicts = nil
+          conflicts_within_selection_set(node, type_definition)
+          @conflicts&.each_value { |error_type| error_type.each_value { |error| add_error(error) } }
+        end
         super
       end
 
       private
 
+      # Quick check: can the direct children of this selection set possibly conflict?
+      # If all direct selections are Fields with unique names and no aliases,
+      # and there are no fragments, then no response key can have >1 field,
+      # so there are no merge conflicts to check at this level.
+      def selections_may_conflict?(selections)
+        i = 0
+        len = selections.size
+        while i < len
+          sel = selections[i]
+          # Fragment spread or inline fragment — needs full check
+          return true unless sel.is_a?(GraphQL::Language::Nodes::Field)
+
+          # Aliased field — could create duplicate response key
+          return true if sel.alias
+
+          i += 1
+        end
+
+        # All are unaliased fields — check for duplicate names
+        # For small sets, O(n²) is cheaper than hash allocation
+        if len <= 8
+          i = 0
+          while i < len
+            j = i + 1
+            name_i = selections[i].name
+            while j < len
+              return true if selections[j].name == name_i
+              j += 1
+            end
+            i += 1
+          end
+
+          false
+        else
+          true # Assume potential conflicts for larger sets
+        end
+      end
+
       def conflicts
         @conflicts ||= Hash.new do |h, error_type|
           h[error_type] = Hash.new do |h2, field_name|
@@ -66,158 +113,168 @@ def conflicts
         end
       end
 
+      # Core algorithm: collect ALL fields (expanding fragments inline) into a flat
+      # map keyed by response key, then compare within each group.
       def conflicts_within_selection_set(node, parent_type)
         return if parent_type.nil?
+        return if node.selections.empty?
 
-        fields, fragment_spreads = fields_and_fragments_from_selection(node, owner_type: parent_type, parents: nil)
-
-        # (A) Find find all conflicts "within" the fields of this selection set.
-        find_conflicts_within(fields)
-
-        fragment_spreads.each_with_index do |fragment_spread, i|
-          are_mutually_exclusive = mutually_exclusive?(
-            fragment_spread.parents,
-            [parent_type]
-          )
-
-          # (B) Then find conflicts between these fields and those represented by
-          # each spread fragment name found.
-          find_conflicts_between_fields_and_fragment(
-            fragment_spread,
-            fields,
-            mutually_exclusive: are_mutually_exclusive,
-          )
-
-          # (C) Then compare this fragment with all other fragments found in this
-          # selection set to collect conflicts between fragments spread together.
-          # This compares each item in the list of fragment names to every other
-          # item in that same list (except for itself).
-          fragment_spreads[i + 1..-1].each do |fragment_spread2|
-            are_mutually_exclusive = mutually_exclusive?(
-              fragment_spread.parents,
-              fragment_spread2.parents
-            )
-
-            find_conflicts_between_fragments(
-              fragment_spread,
-              fragment_spread2,
-              mutually_exclusive: are_mutually_exclusive,
-            )
-          end
-        end
+        # Collect all fields from this selection set, expanding fragments transitively
+        response_keys = collect_fields(node.selections, owner_type: parent_type, parents: [])
+
+        # Find conflicts within each response key group
+        find_conflicts_within(response_keys)
       end
 
-      def find_conflicts_between_fragments(fragment_spread1, fragment_spread2, mutually_exclusive:)
-        fragment_name1 = fragment_spread1.name
-        fragment_name2 = fragment_spread2.name
-        return if fragment_name1 == fragment_name2
+      # Collect all fields from selections, expanding fragment spreads inline.
+      # Returns a Hash of { response_key => Field | [Field, ...] }
+      def collect_fields(selections, owner_type:, parents:)
+        response_keys = {}
+        collect_fields_inner(selections, owner_type: owner_type, parents: parents, response_keys: response_keys, visited_fragments: nil)
+        response_keys
+      end
 
-        cache_key = compared_fragments_key(
-          fragment_name1,
-          fragment_name2,
-          mutually_exclusive,
-        )
-        if @compared_fragments.key?(cache_key)
-          return
-        else
-          @compared_fragments[cache_key] = true
-        end
+      def collect_fields_inner(selections, owner_type:, parents:, response_keys:, visited_fragments:)
+        deferred_spreads = nil
+        sel_idx = 0
+        sel_len = selections.size
 
-        fragment1 = @fragments[fragment_name1]
-        fragment2 = @fragments[fragment_name2]
+        while sel_idx < sel_len
+          sel = selections[sel_idx]
 
-        return if fragment1.nil? || fragment2.nil?
+          case sel
+          when GraphQL::Language::Nodes::Field
+            definition = @types.field(owner_type, sel.name)
+            key = sel.alias || sel.name
+            field = Field.new(sel, definition, owner_type, parents)
+            existing = response_keys[key]
+
+            if existing.nil?
+              response_keys[key] = field
+            elsif existing.is_a?(Field)
+              response_keys[key] = [existing, field]
+            else
+              existing << field
+            end
+          when GraphQL::Language::Nodes::InlineFragment
+            frag_type = sel.type ? @types.type(sel.type.name) : owner_type
+
+            if frag_type
+              new_parents = parents.dup
+              new_parents << frag_type
+              collect_fields_inner(sel.selections, owner_type: frag_type, parents: new_parents, response_keys: response_keys, visited_fragments: visited_fragments)
+            end
+          when GraphQL::Language::Nodes::FragmentSpread
+            (deferred_spreads ||= []) << sel
+          end
 
-        fragment_type1 = @types.type(fragment1.type.name)
-        fragment_type2 = @types.type(fragment2.type.name)
+          sel_idx += 1
+        end
 
-        return if fragment_type1.nil? || fragment_type2.nil?
+        if deferred_spreads
+          visited_fragments ||= {}
+          sel_idx = 0
+          sel_len = deferred_spreads.size
 
-        fragment_fields1, fragment_spreads1 = fields_and_fragments_from_selection(
-          fragment1,
-          owner_type: fragment_type1,
-          parents: [*fragment_spread1.parents, fragment_type1]
-        )
-        fragment_fields2, fragment_spreads2 = fields_and_fragments_from_selection(
-          fragment2,
-          owner_type: fragment_type1,
-          parents: [*fragment_spread2.parents, fragment_type2]
-        )
+          while sel_idx < sel_len
+            sel = deferred_spreads[sel_idx]
+            sel_idx += 1
+            next if visited_fragments.key?(sel.name)
 
-        # (F) First, find all conflicts between these two collections of fields
-        # (not including any nested fragments).
-        find_conflicts_between(
-          fragment_fields1,
-          fragment_fields2,
-          mutually_exclusive: mutually_exclusive,
-        )
+            visited_fragments[sel.name] = true
+            frag = @fragments[sel.name]
+            next unless frag
 
-        # (G) Then collect conflicts between the first fragment and any nested
-        # fragments spread in the second fragment.
-        fragment_spreads2.each do |fragment_spread|
-          find_conflicts_between_fragments(
-            fragment_spread1,
-            fragment_spread,
-            mutually_exclusive: mutually_exclusive,
-          )
-        end
+            frag_type = @types.type(frag.type.name)
+            next unless frag_type
 
-        # (G) Then collect conflicts between the first fragment and any nested
-        # fragments spread in the second fragment.
-        fragment_spreads1.each do |fragment_spread|
-          find_conflicts_between_fragments(
-            fragment_spread2,
-            fragment_spread,
-            mutually_exclusive: mutually_exclusive,
-          )
+            new_parents = parents.dup
+            new_parents << frag_type
+            collect_fields_inner(frag.selections, owner_type: frag_type, parents: new_parents, response_keys: response_keys, visited_fragments: visited_fragments)
+          end
         end
       end
 
-      def find_conflicts_between_fields_and_fragment(fragment_spread, fields, mutually_exclusive:)
-        fragment_name = fragment_spread.name
-        return if @visited_fragments.key?(fragment_name)
-        @visited_fragments[fragment_name] = true
-
-        fragment = @fragments[fragment_name]
-        return if fragment.nil?
+      def find_conflicts_within(response_keys)
+        response_keys.each do |key, fields|
+          next unless fields.is_a?(Array)
+
+          # Optimization: group fields by signature (name + definition + arguments).
+          # Fields with the same signature can only conflict on sub-selections,
+          # so we only need to compare one pair within each group.
+          if fields.size > 4
+            f0 = fields[0]
+            all_same = true
+            i = 1
+            while i < fields.size
+              unless fields_same_signature?(f0, fields[i])
+                all_same = false
+                break
+              end
+              i += 1
+            end
 
-        fragment_type = @types.type(fragment.type.name)
-        return if fragment_type.nil?
+            if all_same
+              # All fields are identical in signature — just compare first two
+              if f0.node.selections.size > 0 || fields[1].node.selections.size > 0
+                find_conflict(key, f0, fields[1])
+              end
+            else
+              groups = fields.group_by { |f| field_signature(f) }
+              unique_groups = groups.values
+
+              # Compare representatives across different groups
+              gi = 0
+              while gi < unique_groups.size
+                gj = gi + 1
+                while gj < unique_groups.size
+                  find_conflict(key, unique_groups[gi][0], unique_groups[gj][0])
+                  gj += 1
+                end
 
-        fragment_fields, fragment_spreads = fields_and_fragments_from_selection(fragment, owner_type: fragment_type, parents: [*fragment_spread.parents, fragment_type])
+                # Within same group, only check first pair for sub-selection conflicts
+                group = unique_groups[gi]
 
-        # (D) First find any conflicts between the provided collection of fields
-        # and the collection of fields represented by the given fragment.
-        find_conflicts_between(
-          fields,
-          fragment_fields,
-          mutually_exclusive: mutually_exclusive,
-        )
+                if group.size >= 2 && (group[0].node.selections.size > 0 || group[1].node.selections.size > 0)
+                  find_conflict(key, group[0], group[1])
+                end
 
-        # (E) Then collect any conflicts between the provided collection of fields
-        # and any fragment names found in the given fragment.
-        fragment_spreads.each do |fragment_spread|
-          find_conflicts_between_fields_and_fragment(
-            fragment_spread,
-            fields,
-            mutually_exclusive: mutually_exclusive,
-          )
+                gi += 1
+              end
+            end
+          else
+            # Small number of fields — original O(n²) is fine
+            i = 0
+            while i < fields.size
+              j = i + 1
+              while j < fields.size
+                find_conflict(key, fields[i], fields[j])
+                j += 1
+              end
+              i += 1
+            end
+          end
         end
       end
 
-      def find_conflicts_within(response_keys)
-        response_keys.each do |key, fields|
-          next if fields.size < 2
-          # find conflicts within nodes
-          i = 0
-          while i < fields.size
-            j = i + 1
-            while j < fields.size
-              find_conflict(key, fields[i], fields[j])
-              j += 1
-            end
-            i += 1
-          end
+      def fields_same_signature?(f1, f2)
+        n1 = f1.node
+        n2 = f2.node
+
+        f1.definition.equal?(f2.definition) &&
+          n1.name == n2.name &&
+          same_arguments?(n1, n2)
+      end
+
+      def field_signature(field)
+        node = field.node
+        defn = field.definition
+        args = node.arguments
+
+        if args.empty?
+          [node.name, defn.object_id]
+        else
+          [node.name, defn.object_id, args.map { |a| [a.name, serialize_arg(a.value)] }]
         end
       end
 
@@ -228,8 +285,7 @@ def find_conflict(response_key, field1, field2, mutually_exclusive: false)
         node1 = field1.node
         node2 = field2.node
 
-        are_mutually_exclusive = mutually_exclusive ||
-                                 mutually_exclusive?(field1.parents, field2.parents)
+        are_mutually_exclusive = mutually_exclusive || mutually_exclusive?(field1.parents, field2.parents)
 
         if !are_mutually_exclusive
           if node1.name != node2.name
@@ -259,11 +315,13 @@ def find_conflict(response_key, field1, field2, mutually_exclusive: false)
 
           return_error = nil
           message_override = nil
+
           case @schema.allow_legacy_invalid_return_type_conflicts
           when false
             return_error = true
           when true
             legacy_handling = @schema.legacy_invalid_return_type_conflicts(@context.query, t1, t2, node1, node2)
+
             case legacy_handling
             when nil
               return_error = false
@@ -286,9 +344,11 @@ def find_conflict(response_key, field1, field2, mutually_exclusive: false)
 
           if return_error
             conflict = conflicts[:return_type][response_key]
+
             if message_override
               conflict.message = message_override
             end
+
             conflict.add_conflict(node1, "`#{t1.to_type_signature}`")
             conflict.add_conflict(node2, "`#{t2.to_type_signature}`")
             @conflict_count += 1
@@ -322,68 +382,61 @@ def return_types_conflict?(type1, type2)
         elsif type1.kind.leaf? && type2.kind.leaf?
           type1 != type2
         else
-          # One or more of these are composite types,
-          # their selections will be validated later on.
           false
         end
       end
 
+      # When two fields with the same response key both have sub-selections,
+      # we need to check those sub-selections against each other.
       def find_conflicts_between_sub_selection_sets(field1, field2, mutually_exclusive:)
         return if field1.definition.nil? ||
           field2.definition.nil? ||
           (field1.node.selections.empty? && field2.node.selections.empty?)
 
+        node1 = field1.node
+        node2 = field2.node
+
+        # Prevent infinite recursion from cyclic fragments
+        return if node1.equal?(node2)
+
+        inner = @compared_sub_selections[node1]
+        if inner
+          return if inner.key?(node2)
+          inner[node2] = true
+        else
+          inner = {}.compare_by_identity
+          inner[node2] = true
+          @compared_sub_selections[node1] = inner
+        end
+
         return_type1 = field1.unwrapped_return_type
         return_type2 = field2.unwrapped_return_type
-        parents1 = [return_type1]
-        parents2 = [return_type2]
 
-        fields, fragment_spreads = fields_and_fragments_from_selection(
-          field1.node,
-          owner_type: return_type1,
-          parents: parents1
-        )
+        response_keys1 = cached_sub_fields(node1, return_type1)
+        response_keys2 = cached_sub_fields(node2, return_type2)
 
-        fields2, fragment_spreads2 = fields_and_fragments_from_selection(
-          field2.node,
-          owner_type: return_type2,
-          parents: parents2
-        )
+        find_conflicts_between(response_keys1, response_keys2, mutually_exclusive: mutually_exclusive)
+      end
 
-        # (H) First, collect all conflicts between these two collections of field.
-        find_conflicts_between(fields, fields2, mutually_exclusive: mutually_exclusive)
-
-        # (I) Then collect conflicts between the first collection of fields and
-        # those referenced by each fragment name associated with the second.
-        fragment_spreads2.each do |fragment_spread|
-          find_conflicts_between_fields_and_fragment(
-            fragment_spread,
-            fields,
-            mutually_exclusive: mutually_exclusive,
-          )
-        end
+      def cached_sub_fields(node, return_type)
+        inner = @sub_fields_cache[node]
 
-        # (I) Then collect conflicts between the second collection of fields and
-        # those referenced by each fragment name associated with the first.
-        fragment_spreads.each do |fragment_spread|
-          find_conflicts_between_fields_and_fragment(
-            fragment_spread,
-            fields2,
-            mutually_exclusive: mutually_exclusive,
-          )
+        if inner && inner.key?(return_type)
+          inner[return_type]
+        else
+          result = collect_fields(node.selections, owner_type: return_type, parents: [return_type])
+          inner ||= {}.compare_by_identity
+          inner[return_type] = result
+          @sub_fields_cache[node] = inner
+          result
         end
+      end
 
-        # (J) Also collect conflicts between any fragment names by the first and
-        # fragment names by the second. This compares each item in the first set of
-        # names to each item in the second set of names.
-        fragment_spreads.each do |frag1|
-          fragment_spreads2.each do |frag2|
-            find_conflicts_between_fragments(
-              frag1,
-              frag2,
-              mutually_exclusive: mutually_exclusive
-            )
-          end
+      def each_field(fields_or_field)
+        if fields_or_field.is_a?(Field)
+          yield fields_or_field
+        else
+          fields_or_field.each { |f| yield f }
         end
       end
 
@@ -391,8 +444,8 @@ def find_conflicts_between(response_keys, response_keys2, mutually_exclusive:)
         response_keys.each do |key, fields|
           fields2 = response_keys2[key]
           if fields2
-            fields.each do |field|
-              fields2.each do |field2|
+            each_field(fields) do |field|
+              each_field(fields2) do |field2|
                 find_conflict(
                   key,
                   field,
@@ -405,38 +458,7 @@ def find_conflicts_between(response_keys, response_keys2, mutually_exclusive:)
         end
       end
 
-      NO_SELECTIONS = [GraphQL::EmptyObjects::EMPTY_HASH, GraphQL::EmptyObjects::EMPTY_ARRAY].freeze
-
-      def fields_and_fragments_from_selection(node, owner_type:, parents:)
-        if node.selections.empty?
-          NO_SELECTIONS
-        else
-          parents ||= []
-          fields, fragment_spreads = find_fields_and_fragments(node.selections, owner_type: owner_type, parents: parents, fields: [], fragment_spreads: [])
-          response_keys = fields.group_by { |f| f.node.alias || f.node.name }
-          [response_keys, fragment_spreads]
-        end
-      end
-
-      def find_fields_and_fragments(selections, owner_type:, parents:, fields:, fragment_spreads:)
-        selections.each do |node|
-          case node
-          when GraphQL::Language::Nodes::Field
-            definition = @types.field(owner_type, node.name)
-            fields << Field.new(node, definition, owner_type, parents)
-          when GraphQL::Language::Nodes::InlineFragment
-            fragment_type = node.type ? @types.type(node.type.name) : owner_type
-            find_fields_and_fragments(node.selections, parents: [*parents, fragment_type], owner_type: fragment_type, fields: fields, fragment_spreads: fragment_spreads) if fragment_type
-          when GraphQL::Language::Nodes::FragmentSpread
-            fragment_spreads << FragmentSpread.new(node.name, parents)
-          end
-        end
-
-        [fields, fragment_spreads]
-      end
-
       def same_arguments?(field1, field2)
-        # Check for incompatible / non-identical arguments on this node:
         arguments1 = field1.arguments
         arguments2 = field2.arguments
 
@@ -469,28 +491,18 @@ def serialize_field_args(field)
         serialized_args
       end
 
-      def compared_fragments_key(frag1, frag2, exclusive)
-        # Cache key to not compare two fragments more than once.
-        # The key includes both fragment names sorted (this way we
-        # avoid computing "A vs B" and "B vs A"). It also includes
-        # "exclusive" since the result may change depending on the parent_type
-        "#{[frag1, frag2].sort.join('-')}-#{exclusive}"
-      end
-
       # Given two list of parents, find out if they are mutually exclusive
-      # In this context, `parents` represents the "self scope" of the field,
-      # what types may be found at this point in the query.
       def mutually_exclusive?(parents1, parents2)
         if parents1.empty? || parents2.empty?
           false
         elsif parents1.length == parents2.length
           i = 0
           len = parents1.length
+
           while i < len
             type1 = parents1[i - 1]
             type2 = parents2[i - 1]
             unless type1.equal?(type2)
-              # Check cache for this type pair
               inner = @mutually_exclusive_cache[type1]
               if inner
                 cached = inner[type2]
@@ -508,6 +520,7 @@ def mutually_exclusive?(parents1, parents2)
             end
             i += 1
           end
+
           false
         else
           true
@@ -517,7 +530,7 @@ def mutually_exclusive?(parents1, parents2)
       def types_mutually_exclusive?(type1, type2)
         possible_right_types = @types.possible_types(type1)
         possible_left_types = @types.possible_types(type2)
-        !possible_right_types.intersect?(possible_left_types)
+        (possible_right_types & possible_left_types).empty?
       end
     end
   end
diff --git a/spec/graphql/static_validation/rules/fields_will_merge_spec.rb b/spec/graphql/static_validation/rules/fields_will_merge_spec.rb
index 4aa802e020..a7219abf7a 100644
--- a/spec/graphql/static_validation/rules/fields_will_merge_spec.rb
+++ b/spec/graphql/static_validation/rules/fields_will_merge_spec.rb
@@ -422,8 +422,8 @@
 
     it "fails rule" do
       assert_equal [
-        "Field 'x' has a field conflict: name or nickname?",
-        "Field 'name' has a field conflict: name or nickname?"
+        "Field 'name' has a field conflict: name or nickname?",
+        "Field 'x' has a field conflict: name or nickname?"
       ], error_messages
     end
 
@@ -434,10 +434,10 @@
         }
 
         it "does not limit the number of errors" do
-          assert_equal(error_messages, [
-            "Field 'x' has a field conflict: name or nickname?",
-            "Field 'name' has a field conflict: name or nickname?"
-          ])
+          assert_equal [
+            "Field 'name' has a field conflict: name or nickname?",
+            "Field 'x' has a field conflict: name or nickname?"
+          ], error_messages
         end
       end
 
@@ -447,9 +447,9 @@
         }
 
         it "does limit the number of errors" do
-          assert_equal(error_messages, [
-            "Field 'x' has a field conflict: name or nickname?",
-          ])
+          assert_equal [
+            "Field 'name' has a field conflict: name or nickname?"
+          ], error_messages
         end
       end
     end

From 5f10068c39fadfcf8e8b835c32a7dcc22eeaab7e Mon Sep 17 00:00:00 2001
From: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date: Thu, 26 Mar 2026 13:09:32 -0500
Subject: [PATCH 6/7] Improve test coverage

---
 .../rules/fields_will_merge.rb                |  36 +-
 .../rules/fields_will_merge_spec.rb           | 754 ++++++++++++++++++
 2 files changed, 783 insertions(+), 7 deletions(-)

diff --git a/lib/graphql/static_validation/rules/fields_will_merge.rb b/lib/graphql/static_validation/rules/fields_will_merge.rb
index 972abbb03d..9349773fc8 100644
--- a/lib/graphql/static_validation/rules/fields_will_merge.rb
+++ b/lib/graphql/static_validation/rules/fields_will_merge.rb
@@ -215,9 +215,20 @@ def find_conflicts_within(response_keys)
             end
 
             if all_same
-              # All fields are identical in signature — just compare first two
-              if f0.node.selections.size > 0 || fields[1].node.selections.size > 0
-                find_conflict(key, f0, fields[1])
+              # All fields share a signature, so they can only conflict on
+              # sub-selections. Deduplicate by AST node identity — fields from
+              # the same node always have identical sub-selections.
+              unique_nodes = fields.uniq { |f| f.node.object_id }
+              i = 0
+              while i < unique_nodes.size
+                j = i + 1
+                while j < unique_nodes.size
+                  if unique_nodes[i].node.selections.size > 0 || unique_nodes[j].node.selections.size > 0
+                    find_conflict(key, unique_nodes[i], unique_nodes[j])
+                  end
+                  j += 1
+                end
+                i += 1
               end
             else
               groups = fields.group_by { |f| field_signature(f) }
@@ -232,11 +243,22 @@ def find_conflicts_within(response_keys)
                   gj += 1
                 end
 
-                # Within same group, only check first pair for sub-selection conflicts
+                # Within same group, deduplicate by AST node and compare all
+                # pairs for sub-selection conflicts
                 group = unique_groups[gi]
-
-                if group.size >= 2 && (group[0].node.selections.size > 0 || group[1].node.selections.size > 0)
-                  find_conflict(key, group[0], group[1])
+                if group.size >= 2
+                  unique_in_group = group.uniq { |f| f.node.object_id }
+                  ui = 0
+                  while ui < unique_in_group.size
+                    uj = ui + 1
+                    while uj < unique_in_group.size
+                      if unique_in_group[ui].node.selections.size > 0 || unique_in_group[uj].node.selections.size > 0
+                        find_conflict(key, unique_in_group[ui], unique_in_group[uj])
+                      end
+                      uj += 1
+                    end
+                    ui += 1
+                  end
                 end
 
                 gi += 1
diff --git a/spec/graphql/static_validation/rules/fields_will_merge_spec.rb b/spec/graphql/static_validation/rules/fields_will_merge_spec.rb
index a7219abf7a..aced00cc16 100644
--- a/spec/graphql/static_validation/rules/fields_will_merge_spec.rb
+++ b/spec/graphql/static_validation/rules/fields_will_merge_spec.rb
@@ -973,6 +973,199 @@
         assert_includes error_messages, "Field 'scalar' has a field conflict: deepBox or unrelatedField?"
       end
     end
+
+    describe "disallows differing return types despite no overlap" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on IntBox {
+              scalar
+            }
+            ... on StringBox {
+              scalar
+            }
+          }
+        }
+      |}
+
+      it "fails rule" do
+        schema.allow_legacy_invalid_return_type_conflicts(false)
+        assert_equal ["Field 'scalar' has a return_type conflict: `Int` or `String`?"], error_messages
+      end
+    end
+
+    describe "disallows differing nullability despite no overlap" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on NonNullStringBox1 {
+              scalar
+            }
+            ... on StringBox {
+              scalar
+            }
+          }
+        }
+      |}
+
+      it "fails rule" do
+        schema.allow_legacy_invalid_return_type_conflicts(false)
+        assert_equal ["Field 'scalar' has a return_type conflict: `String!` or `String`?"], error_messages
+      end
+    end
+
+    describe "disallows differing return type list on object types" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on IntBox {
+              box: listStringBox {
+                scalar
+              }
+            }
+            ... on StringBox {
+              box: stringBox {
+                scalar
+              }
+            }
+          }
+        }
+      |}
+
+      it "fails rule" do
+        schema.allow_legacy_invalid_return_type_conflicts(false)
+        assert_equal ["Field 'box' has a return_type conflict: `[StringBox]` or `StringBox`?"], error_messages
+      end
+    end
+
+    describe "disallows differing deep return types despite no overlap" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on IntBox {
+              box: stringBox {
+                scalar
+              }
+            }
+            ... on StringBox {
+              box: intBox {
+                scalar
+              }
+            }
+          }
+        }
+      |}
+
+      it "fails rule" do
+        schema.allow_legacy_invalid_return_type_conflicts(false)
+        assert_equal ["Field 'scalar' has a return_type conflict: `String` or `Int`?"], error_messages
+      end
+    end
+
+    describe "detects alias conflict in shared subfield type across exclusive parents" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on IntBox {
+              box: stringBox {
+                val: scalar
+                val: unrelatedField
+              }
+            }
+            ... on StringBox {
+              box: stringBox {
+                val: scalar
+              }
+            }
+          }
+        }
+      |}
+
+      it "detects the subfield conflict" do
+        assert_includes error_messages, "Field 'val' has a field conflict: scalar or unrelatedField?"
+      end
+    end
+
+    describe "same wrapped scalar return types on different interfaces" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on NonNullStringBox1 {
+              scalar
+            }
+            ... on NonNullStringBox2 {
+              scalar
+            }
+          }
+        }
+      |}
+
+      it "passes rule" do
+        assert_equal [], errors
+      end
+    end
+
+    describe "allows non-conflicting overlapping types" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on IntBox {
+              scalar: unrelatedField
+            }
+            ... on StringBox {
+              scalar
+            }
+          }
+        }
+      |}
+
+      it "passes rule" do
+        assert_equal [], errors
+      end
+    end
+
+    describe "compares deep types including list" do
+      let(:query_string) {%|
+        {
+          connection {
+            ...edgeID
+            edges {
+              id: name
+            }
+          }
+        }
+
+        fragment edgeID on Connection {
+          edges {
+            id
+          }
+        }
+      |}
+
+      it "detects the deep conflict through list type" do
+        assert error_messages.any? { |m| m.include?("Field 'id' has a field conflict") && m.include?("name") }
+      end
+    end
+
+    describe "conflicting return types on potentially overlapping types" do
+      let(:query_string) {%|
+        {
+          someBox {
+            ... on IntBox {
+              scalar
+            }
+            ... on NonNullStringBox1 {
+              scalar
+            }
+          }
+        }
+      |}
+
+      it "fails rule" do
+        schema.allow_legacy_invalid_return_type_conflicts(false)
+        assert_equal ["Field 'scalar' has a return_type conflict: `Int` or `String!`?"], error_messages
+      end
+    end
   end
 
   describe "conflicts exceeding the max_errors count" do
@@ -1127,6 +1320,567 @@ def self.legacy_invalid_return_type_conflicts(query, t1, t2, node1, node2)
     end
   end
 
+  describe "conflicting argument names" do
+    it "detects fields with different argument names as a conflict" do
+      arg_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query {
+          dog: Dog
+        }
+        type Dog {
+          isAtLocation(x: Int, y: Int): Boolean
+        }
+      GRAPHQL
+
+      res = arg_schema.validate("{ dog { isAtLocation(x: 0) isAtLocation(y: 0) } }")
+      assert res.any? { |e| e.message.include?("argument conflict") }
+    end
+  end
+
+  describe "reports deep conflict to nearest common ancestor" do
+    it "detects conflict within a sub-selection that has a non-conflicting sibling" do
+      deep_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { field: T }
+        type T { deepField: T x: String y: String a: String b: String }
+      GRAPHQL
+
+      query_str = <<~GRAPHQL
+        {
+          field {
+            deepField { x: a }
+            deepField { x: b }
+          }
+          field {
+            deepField { y }
+          }
+        }
+      GRAPHQL
+
+      res = deep_schema.validate(query_str)
+      assert res.any? { |e| e.message.include?("Field 'x' has a field conflict") }
+    end
+  end
+
+  describe "reports deep conflict to nearest common ancestor in fragments" do
+    it "detects conflict through fragment spreads" do
+      deep_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { field: T }
+        type T { deepField: T deeperField: T x: String y: String a: String b: String }
+      GRAPHQL
+
+      query_str = <<~GRAPHQL
+        {
+          field { ...F }
+          field { ...F }
+        }
+        fragment F on T {
+          deepField {
+            deeperField { x: a }
+            deeperField { x: b }
+          }
+          deepField {
+            deeperField { y }
+          }
+        }
+      GRAPHQL
+
+      res = deep_schema.validate(query_str)
+      assert res.any? { |e| e.message.include?("Field 'x' has a field conflict") }
+    end
+  end
+
+  describe "reports deep conflict in nested fragments" do
+    it "detects cross-fragment conflicts at the same nesting depth" do
+      deep_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { field: T }
+        type T { x: String a: String b: String }
+      GRAPHQL
+
+      # Both fragments at the same depth — avoids the preexisting uneven
+      # parent length limitation in mutually_exclusive?
+      query_str = <<~GRAPHQL
+        {
+          field { ...F }
+          field { ...I }
+        }
+        fragment F on T { x: a }
+        fragment I on T { x: b }
+      GRAPHQL
+
+      res = deep_schema.validate(query_str)
+      assert res.any? { |e| e.message.include?("Field 'x' has a field conflict") }
+    end
+
+    it "detects conflicts in multi-fragment chains at same depth" do
+      deep_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { field: T }
+        type T { x: String y: String a: String b: String c: String d: String }
+      GRAPHQL
+
+      # F and I are both at depth 1, G and J at depth 2.
+      # x: a (depth 1, from F) conflicts with x: b (depth 1, from I) — same depth.
+      # y: c (depth 2, from G) conflicts with y: d (depth 2, from J) — same depth.
+      # NOTE: cross-depth comparisons (e.g. F.x vs J.x at depth 1 vs 2) are a
+      # known limitation — mutually_exclusive? treats uneven parent lengths as exclusive.
+      query_str = <<~GRAPHQL
+        {
+          field { ...F ...I }
+        }
+        fragment F on T { x: a ...G }
+        fragment G on T { y: c }
+        fragment I on T { x: b ...J }
+        fragment J on T { y: d }
+      GRAPHQL
+
+      res = deep_schema.validate(query_str)
+      field_conflicts = res.select { |e| e.message.include?("field conflict") }
+      assert field_conflicts.any? { |e| e.message.include?("'x'") }
+      assert field_conflicts.any? { |e| e.message.include?("'y'") }
+    end
+  end
+
+  describe "large field set with divergent sub-selections (>4 optimization)" do
+    describe "all same signature, conflict in non-first field" do
+      let(:query_string) {%|
+        {
+          pet {
+            ...F1
+            ...F2
+            ...F3
+            ...F4
+            ...F5
+          }
+        }
+
+        fragment F1 on Dog { toys { x: name } }
+        fragment F2 on Dog { toys { x: name } }
+        fragment F3 on Dog { toys { x: name } }
+        fragment F4 on Dog { toys { x: size } }
+        fragment F5 on Dog { toys { x: name } }
+      |}
+
+      it "detects the sub-selection conflict" do
+        assert error_messages.any? { |m| m.include?("Field 'x' has a field conflict") && m.include?("name") && m.include?("size") }
+      end
+    end
+
+    describe "grouped path, conflict within same-signature group" do
+      let(:query_string) {%|
+        {
+          pet {
+            ...G1
+            ...G2
+            ...G3
+            ...G4
+            ...G5
+            ...G6
+          }
+        }
+
+        fragment G1 on Dog { toys { x: name } }
+        fragment G2 on Dog { toys { x: name } }
+        fragment G3 on Dog { toys { x: name } }
+        fragment G4 on Dog { toys { x: size } }
+        fragment G5 on Dog { doesKnowCommand(dogCommand: SIT) }
+        fragment G6 on Dog { doesKnowCommand(dogCommand: HEEL) }
+      |}
+
+      it "detects both the sub-selection and argument conflicts" do
+        assert error_messages.any? { |m| m.include?("Field 'x' has a field conflict") && m.include?("name") && m.include?("size") }
+        assert error_messages.any? { |m| m.include?("Field 'doesKnowCommand' has an argument conflict") }
+      end
+    end
+  end
+
+  describe "boundary at exactly 4 and 5 fields" do
+    describe "4 fields uses O(n^2) path and catches conflict" do
+      let(:query_string) {%|
+        {
+          dog {
+            ...B1
+            ...B2
+            ...B3
+            ...B4
+          }
+        }
+
+        fragment B1 on Dog { toys { x: name } }
+        fragment B2 on Dog { toys { x: name } }
+        fragment B3 on Dog { toys { x: name } }
+        fragment B4 on Dog { toys { x: size } }
+      |}
+
+      it "detects the conflict" do
+        assert error_messages.any? { |m| m.include?("Field 'x' has a field conflict") && m.include?("name") && m.include?("size") }
+      end
+    end
+
+    describe "5 fields triggers optimization and still catches conflict" do
+      let(:query_string) {%|
+        {
+          dog {
+            ...B1
+            ...B2
+            ...B3
+            ...B4
+            ...B5
+          }
+        }
+
+        fragment B1 on Dog { toys { x: name } }
+        fragment B2 on Dog { toys { x: name } }
+        fragment B3 on Dog { toys { x: size } }
+        fragment B4 on Dog { toys { x: name } }
+        fragment B5 on Dog { toys { x: name } }
+      |}
+
+      it "detects the conflict" do
+        assert error_messages.any? { |m| m.include?("Field 'x' has a field conflict") && m.include?("name") && m.include?("size") }
+      end
+    end
+  end
+
+  describe "triple-nested named fragment conflict" do
+    let(:query_string) {%|
+      {
+        dog {
+          name
+          ...A
+        }
+      }
+
+      fragment A on Dog {
+        ...B
+      }
+
+      fragment B on Dog {
+        ...C
+      }
+
+      fragment C on Dog {
+        name: __typename
+      }
+    |}
+
+    it "detects the conflict through three levels of fragments" do
+      assert_equal ["Field 'name' has a field conflict: name or __typename?"], error_messages
+    end
+  end
+
+  describe "same named fragment spread at multiple nesting levels" do
+    let(:query_string) {%|
+      {
+        pet {
+          ...F
+          ... on Dog {
+            ...F
+          }
+        }
+      }
+
+      fragment F on Pet {
+        name
+        name: nickname
+      }
+    |}
+
+    it "detects the conflict" do
+      assert_includes error_messages, "Field 'name' has a field conflict: name or nickname?"
+    end
+  end
+
+  describe "inline fragment without type condition" do
+    let(:query_string) {%|
+      {
+        dog {
+          ... {
+            name
+            name: nickname
+          }
+        }
+      }
+    |}
+
+    it "detects the conflict" do
+      assert_equal ["Field 'name' has a field conflict: name or nickname?"], error_messages
+    end
+
+    describe "no conflict" do
+      let(:query_string) {%|
+        {
+          dog {
+            ... {
+              name
+              nickname
+            }
+          }
+        }
+      |}
+
+      it "passes rule" do
+        assert_equal [], errors
+      end
+    end
+  end
+
+  describe "nested list wrapping mismatch" do
+    it "detects [[Int]] vs [Int] conflict" do
+      nested_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { u: U }
+        union U = A | B
+        type A { f: [[Int]] }
+        type B { f: [Int] }
+      GRAPHQL
+      nested_schema.allow_legacy_invalid_return_type_conflicts(false)
+
+      res = nested_schema.validate("{ u { ... on A { f } ... on B { f } } }")
+      assert_equal ["Field 'f' has a return_type conflict: `[[Int]]` or `[Int]`?"], res.map(&:message)
+    end
+
+    it "detects [String!] vs [String] conflict" do
+      null_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { u: U }
+        union U = A | B
+        type A { f: [String!] }
+        type B { f: [String] }
+      GRAPHQL
+      null_schema.allow_legacy_invalid_return_type_conflicts(false)
+
+      res = null_schema.validate("{ u { ... on A { f } ... on B { f } } }")
+      assert_equal ["Field 'f' has a return_type conflict: `[String!]` or `[String]`?"], res.map(&:message)
+    end
+  end
+
+  describe "on_field catches sub-selection conflict within a single field" do
+    let(:query_string) {%|
+      {
+        dog {
+          toys {
+            x: name
+          }
+          toys {
+            x: size
+          }
+        }
+      }
+    |}
+
+    it "detects the conflict" do
+      assert_equal ["Field 'x' has a field conflict: name or size?"], error_messages
+    end
+  end
+
+  describe "allows different order of args" do
+    it "does not conflict when arguments are in different order" do
+      arg_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query {
+          someField(a: String, b: String): String
+        }
+      GRAPHQL
+
+      res = arg_schema.validate("{ someField(a: null, b: null) someField(b: null, a: null) }")
+      assert_equal [], res
+    end
+  end
+
+  describe "allows different order of input object fields in arg values" do
+    let(:query_string) {%|
+      mutation {
+        registerPet(params: { name: "Fido", species: DOG }) { name }
+        registerPet(params: { species: DOG, name: "Fido" }) { __typename }
+      }
+    |}
+
+    # Known limitation: serialize_arg uses to_query_string which preserves AST
+    # key order for input objects. graphql-js treats different key orders as
+    # equivalent, but graphql-ruby currently does not.
+    it "reports a false positive argument conflict" do
+      assert error_messages.any? { |m| m.include?("argument conflict") }
+    end
+  end
+
+  describe "reports each conflict once" do
+    it "deduplicates conflicts across multiple spreads of same fragments" do
+      dedup_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { f1: T f2: T f3: T }
+        type T { x: String a: String b: String c: String }
+      GRAPHQL
+
+      query_str = <<~GRAPHQL
+        {
+          f1 { ...A ...B }
+          f2 { ...B ...A }
+          f3 { ...A ...B x: c }
+        }
+        fragment A on T { x: a }
+        fragment B on T { x: b }
+      GRAPHQL
+
+      res = dedup_schema.validate(query_str)
+      x_conflicts = res.select { |e| e.message.include?("'x'") && e.message.include?("field conflict") }
+      # Should report the conflict but not exponentially many times
+      assert x_conflicts.size >= 1
+      assert x_conflicts.size <= 3 # at most one per selection set
+    end
+  end
+
+  describe "identical fields with identical directives" do
+    let(:query_string) {%|
+      {
+        dog {
+          name @include(if: true)
+          name @include(if: true)
+        }
+      }
+    |}
+
+    it "passes rule" do
+      assert_equal [], errors
+    end
+  end
+
+  describe "ignores unknown fragments" do
+    let(:query_string) {%|
+      {
+        dog {
+          name
+          ...Unknown
+          ...Known
+        }
+      }
+
+      fragment Known on Dog {
+        name
+        ...OtherUnknown
+      }
+    |}
+
+    it "does not crash" do
+      # Unknown fragments are caught by other rules, this one should not crash
+      assert_kind_of Array, errors
+    end
+  end
+
+  describe "ignores unknown types in inline fragments" do
+    let(:query_string) {%|
+      {
+        pet {
+          ... on UnknownType {
+            name
+          }
+          ... on Dog {
+            name
+          }
+        }
+      }
+    |}
+
+    it "does not crash" do
+      assert_kind_of Array, errors
+    end
+  end
+
+  describe "does not infinite loop on immediately recursive fragment" do
+    let(:query_string) {%|
+      {
+        dog {
+          ...fragA
+        }
+      }
+
+      fragment fragA on Dog {
+        name
+        ...fragA
+      }
+    |}
+
+    it "does not crash" do
+      assert_kind_of Array, errors
+    end
+  end
+
+  describe "does not infinite loop on transitively recursive fragment" do
+    let(:query_string) {%|
+      {
+        dog {
+          ...fragA
+        }
+      }
+
+      fragment fragA on Dog { name ...fragB }
+      fragment fragB on Dog { nickname ...fragC }
+      fragment fragC on Dog { barkVolume ...fragA }
+    |}
+
+    it "does not crash" do
+      assert_kind_of Array, errors
+    end
+  end
+
+  describe "finds invalid case even with immediately recursive fragment" do
+    let(:query_string) {%|
+      {
+        dog {
+          ...sameAliases
+        }
+      }
+
+      fragment sameAliases on Dog {
+        ...sameAliases
+        fido: name
+        fido: nickname
+      }
+    |}
+
+    it "detects the conflict" do
+      assert_includes error_messages, "Field 'fido' has a field conflict: name or nickname?"
+    end
+  end
+
+  describe "finds invalid case with field named after fragment" do
+    it "detects alias conflict where alias matches fragment name" do
+      frag_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { fragA: String a: String b: String }
+      GRAPHQL
+
+      query_str = <<~GRAPHQL
+        {
+          fragA
+          ...fragA
+        }
+        fragment fragA on Query {
+          fragA: b
+        }
+      GRAPHQL
+
+      res = frag_schema.validate(query_str)
+      assert res.any? { |e| e.message.include?("field conflict") }
+    end
+  end
+
+  describe "does not infinite loop on recursive fragments separated by fields" do
+    it "handles mutual recursion through intermediate fields" do
+      rec_schema = GraphQL::Schema.from_definition <<~GRAPHQL
+        type Query { field: T }
+        type T { x: T name: String }
+      GRAPHQL
+
+      query_str = <<~GRAPHQL
+        {
+          field { ...fragA ...fragB }
+        }
+        fragment fragA on T {
+          x { ...fragA ...fragB }
+        }
+        fragment fragB on T {
+          x { ...fragA ...fragB }
+        }
+      GRAPHQL
+
+      res = rec_schema.validate(query_str)
+      assert_kind_of Array, res
+    end
+  end
+
   describe "duplicate aliases on a interface with inline fragment spread" do
     class DuplicateAliasesSchema < GraphQL::Schema
       module Node

From 3dc282b47491b565eea6b1fb678eda9439557021 Mon Sep 17 00:00:00 2001
From: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date: Thu, 26 Mar 2026 13:10:57 -0500
Subject: [PATCH 7/7] Inline `each_field` since it conflicts graphql-pro

---
 .../rules/fields_will_merge.rb                | 31 ++++++++-----------
 1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/lib/graphql/static_validation/rules/fields_will_merge.rb b/lib/graphql/static_validation/rules/fields_will_merge.rb
index 9349773fc8..45f200285c 100644
--- a/lib/graphql/static_validation/rules/fields_will_merge.rb
+++ b/lib/graphql/static_validation/rules/fields_will_merge.rb
@@ -454,27 +454,22 @@ def cached_sub_fields(node, return_type)
         end
       end
 
-      def each_field(fields_or_field)
-        if fields_or_field.is_a?(Field)
-          yield fields_or_field
-        else
-          fields_or_field.each { |f| yield f }
-        end
-      end
-
       def find_conflicts_between(response_keys, response_keys2, mutually_exclusive:)
         response_keys.each do |key, fields|
           fields2 = response_keys2[key]
-          if fields2
-            each_field(fields) do |field|
-              each_field(fields2) do |field2|
-                find_conflict(
-                  key,
-                  field,
-                  field2,
-                  mutually_exclusive: mutually_exclusive,
-                )
-              end
+          next unless fields2
+
+          fields_arr = fields.is_a?(Field) ? [fields] : fields
+          fields2_arr = fields2.is_a?(Field) ? [fields2] : fields2
+
+          fields_arr.each do |field|
+            fields2_arr.each do |field2|
+              find_conflict(
+                key,
+                field,
+                field2,
+                mutually_exclusive: mutually_exclusive,
+              )
             end
           end
         end