Add a generic fallback block

Author: AdityaHegde

runtime/ai/developer_agent.go

@@ -161,7 +161,7 @@ This may not relate to the user's task, but for context, the project's default O
 {{ if .default_olap_readwrite }} The default OLAP is in readwrite mode, so you can use it in models if you want.
 {{ else }} The default OLAP is in read-only mode, so you cannot create models in it. {{ end }}
 
-Call "navigate" tool for the main file created/edited in the conversation. Use type "file" and pass the written file path.
+Call "navigate" tool for the main file created/edited in the conversation. Use kind "file" and pass the written file path.
 Prefer dashboard or metrics view files over other files.
 
 Task: {{ .prompt }}

runtime/ai/navigate.go

@@ -21,8 +21,7 @@ type NavigateArgs struct {
 	Name string `json:"name" jsonschema:"The name of the item to navigate to."`
 }
 
-type NavigateResult struct {
-}
+type NavigateResult struct {}
 
 func (t *Navigate) Spec() *mcp.Tool {
 	return &mcp.Tool{

web-common/src/features/chat/core/conversation.ts

@@ -319,10 +319,7 @@ export class Conversation {
       }
 
       this.addMessageToCache(response.message);
-      if (
-        response.message.tool === ToolName.NAVIGATE &&
-        response.message.type === MessageType.CALL
-      ) {
+      if (response.message.type === MessageType.CALL) {
         const config = getToolConfig(response.message.tool);
         config?.onResult?.(response.message);
       }

web-common/src/features/chat/core/messages/Messages.svelte

@@ -14,6 +14,7 @@
   import UserMessage from "./text/UserMessage.svelte";
   import ThinkingBlock from "./thinking/ThinkingBlock.svelte";
   import WorkingBlock from "./working/WorkingBlock.svelte";
+  import GenericBlock from "@rilldata/web-common/features/chat/core/messages/generic/GenericBlock.svelte";
 
   export let conversationManager: ConversationManager;
   export let layout: "sidebar" | "fullpage";
@@ -123,6 +124,8 @@
         <ChartBlock {block} {tools} />
       {:else if block.type === "file-diff"}
         <FileDiffBlock {block} {tools} />
+      {:else if block.type === "generic-block"}
+        <GenericBlock {block} {tools} />
       {/if}
     {/each}
   {/if}

web-common/src/features/chat/core/messages/block-transform.ts

@@ -15,6 +15,7 @@ import {
 } from "./thinking/thinking-block";
 import { getToolConfig, type ToolConfig } from "./tools/tool-registry";
 import { shouldShowWorking, type WorkingBlock } from "./working/working-block";
+import type { GenericBlock } from "@rilldata/web-common/features/chat/core/messages/generic/generic-block.ts";
 
 // =============================================================================
 // TYPES & TRANSFORMATION
@@ -25,7 +26,8 @@ export type Block =
   | ThinkingBlock
   | ChartBlock
   | FileDiffBlock
-  | WorkingBlock;
+  | WorkingBlock
+  | GenericBlock;
 
 // Re-export individual block types for convenience
 export type {
@@ -34,6 +36,7 @@ export type {
   TextBlock,
   ThinkingBlock,
   WorkingBlock,
+  GenericBlock,
 };
 
 /**
@@ -91,6 +94,7 @@ export function transformToBlocks(
         if (block) {
           blocks.push(block);
         }
+        console.log(block);
         break;
       }
 

web-common/src/features/chat/core/messages/generic/GenericBlock.svelte

@@ -0,0 +1,27 @@
+<!--
+  Renders a file diff block with collapsible tool call header.
+  Shows the diff visualization with expandable request/response details.
+-->
+<script lang="ts">
+  import type { V1Tool } from "../../../../../runtime-client";
+  import ToolCall from "../tools/ToolCall.svelte";
+  import type { GenericBlock } from "@rilldata/web-common/features/chat/core/messages/generic/generic-block.ts";
+
+  export let block: GenericBlock;
+  export let tools: V1Tool[] | undefined = undefined;
+</script>
+
+<div class="generic-block">
+  <ToolCall
+    message={block.message}
+    resultMessage={block.resultMessage}
+    {tools}
+    variant="block"
+  />
+</div>
+
+<style lang="postcss">
+  .generic-block {
+    @apply w-full max-w-full self-start;
+  }
+</style>

web-common/src/features/chat/core/messages/generic/generic-block.ts

@@ -0,0 +1,24 @@
+import type { V1Message } from "@rilldata/web-common/runtime-client";
+
+/**
+ * Generic block that doesnt really have specific rendering.
+ */
+export type GenericBlock = {
+  type: "generic-block";
+  id: string;
+  message: V1Message;
+  resultMessage: V1Message;
+};
+
+export function createGenericBlock(
+  message: V1Message,
+  resultMessage: V1Message | undefined,
+): GenericBlock | null {
+  if (!resultMessage) return null;
+  return {
+    type: "generic-block",
+    id: `generic-block-${message.id}`,
+    message,
+    resultMessage,
+  };
+}

web-common/src/features/chat/core/messages/tools/tool-registry.ts

@@ -15,7 +15,11 @@ import {
   type FileDiffBlock,
 } from "../file-diff/file-diff-block";
 import { goto } from "$app/navigation";
-import { maybePrependSlash } from "@rilldata/web-common/features/entity-management/file-path-utils.ts";
+import { addLeadingSlash } from "@rilldata/web-common/features/entity-management/entity-mappers.ts";
+import {
+  createGenericBlock,
+  type GenericBlock,
+} from "@rilldata/web-common/features/chat/core/messages/generic/generic-block.ts";
 
 // =============================================================================
 // RENDER MODES
@@ -34,7 +38,7 @@ export type ToolRenderMode = "inline" | "block" | "hidden";
 // =============================================================================
 
 /** Block types that can be created by tools */
-export type ToolBlockType = ChartBlock | FileDiffBlock;
+export type ToolBlockType = ChartBlock | FileDiffBlock | GenericBlock;
 
 /**
  * Configuration for a tool's rendering behavior.
@@ -89,7 +93,8 @@ const TOOL_CONFIGS: Partial<Record<string, ToolConfig>> = {
   },
 
   [ToolName.NAVIGATE]: {
-    renderMode: "hidden",
+    renderMode: "block",
+    createBlock: createGenericBlock,
     onResult: handleNavigateToolCall,
   },
 
@@ -123,7 +128,7 @@ function handleNavigateToolCall(callMessage: V1Message) {
     if (!content.kind || !content.name) return;
     switch (content.kind) {
       case "file":
-        void goto(`/files${maybePrependSlash(content.name)}`);
+        void goto(`/files${addLeadingSlash(content.name)}`);
     }
   } catch (err) {
     console.error(err);

web-common/src/features/entity-management/entity-mappers.ts

@@ -115,7 +115,7 @@ export function removeLeadingSlash(path: string): string {
 }
 
 // Add a leading slash if it doesn't exist.
-// Temporary, we should eventually make sure this is added in all places
+// While all files returned by Repo APIs have this already, AI interactions might not always have it.
 export function addLeadingSlash(path: string): string {
   if (path.startsWith("/")) return path;
   return "/" + path;

web-common/src/features/entity-management/file-path-utils.ts

@@ -50,7 +50,3 @@ export function splitFolderFileNameAndExtension(
 export function getTopLevelFolder(filePath: string): string {
   return "/" + (filePath.split(FILE_PATH_SPLIT_REGEX)[1] ?? "");
 }
-
-export function maybePrependSlash(path: string) {
-  return path.startsWith("/") ? path : "/" + path;
-}