Skip to content

Commit cc4e56b

Browse files
committed
refactor(ci): use download-dists for the artifact half
Reworks the previous commit. Composite actions were not the problem -- one creates no new workflow context, so the job keeps this repo's own OIDC identity, which is why it works where a reusable workflow does not. Only pypa/gh-action-pypi-publish had to come out of it, because nesting a Docker container action makes GitHub resolve its image against the wrapping action's repository. So the download goes back to a shared action, renamed download-dists now that it no longer publishes, and only the publish step stays inline. Still pinned at @main here; reqstool/.github#94 has to merge before a commit SHA exists to pin to. That pin lands before this PR merges. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
1 parent faec9f7 commit cc4e56b

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,12 @@ jobs:
109109
permissions:
110110
id-token: write
111111
steps:
112-
- uses: actions/download-artifact@v8.0.1
112+
- uses: reqstool/.github/.github/actions/download-dists@main
113113
with:
114-
name: dist-tagged
115-
path: dist
114+
artifact: dist-tagged
115+
# Inline, not inside download-dists: nesting this Docker action in a
116+
# composite action makes GitHub resolve its image against the wrapper's
117+
# repo. See reqstool/.github#95.
116118
- uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # v1.14.2
117119
with:
118120
attestations: true

0 commit comments

Comments
 (0)