Skip to content

Commit e8f9fc1

Browse files
committed
fix: address review round 4 for migrate-wizard (#564)
- Prevent rename target from colliding with staged field additions
1 parent 26a79dc commit e8f9fc1

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

redisvl/migration/wizard.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,14 @@ def _build_patch(
260260
)
261261
field_rename = self._prompt_rename_field(rename_schema)
262262
if field_rename:
263-
changes.rename_fields.append(field_rename)
263+
# Check rename target doesn't collide with staged additions
264+
if field_rename.new_name in staged_add_names:
265+
print(
266+
f"Cannot rename to '{field_rename.new_name}': "
267+
"a field with that name is already staged for addition."
268+
)
269+
else:
270+
changes.rename_fields.append(field_rename)
264271
elif action == "5":
265272
new_name = self._prompt_rename_index(working_schema)
266273
if new_name:

0 commit comments

Comments
 (0)