fix(search): correct INDEXMISSING placement (#3179)

fixes #3170

Author: nkaradzhov

packages/search/lib/commands/CREATE.spec.ts

@@ -233,6 +233,25 @@ describe('FT.CREATE', () => {
             ]
           );
         });
+
+        it('with INDEXMISSING', () => {
+          assert.deepEqual(
+            parseArgs(CREATE, 'index', {
+              field: {
+                type: SCHEMA_FIELD_TYPE.VECTOR,
+                ALGORITHM: SCHEMA_VECTOR_FIELD_ALGORITHM.FLAT,
+                TYPE: 'FLOAT32',
+                DIM: 2,
+                DISTANCE_METRIC: 'L2',
+                INDEXMISSING: true
+              }
+            }),
+            [
+              'FT.CREATE', 'index', 'SCHEMA', 'field', 'VECTOR', 'FLAT', '6', 'TYPE',
+              'FLOAT32', 'DIM', '2', 'DISTANCE_METRIC', 'L2', 'INDEXMISSING'
+            ]
+          );
+        });
       });
 
       describe('GEOSHAPE', () => {
@@ -270,7 +289,7 @@ describe('FT.CREATE', () => {
           );
         });
       });
-  
+
       it('with AS', () => {
         assert.deepEqual(
           parseArgs(CREATE, 'index', {
@@ -514,6 +533,23 @@ describe('FT.CREATE', () => {
     });
   });
 
+  testUtils.testWithClient('no', async client => {
+    await client.ft.create(
+      'idx:example',
+      {
+        vector1: {
+          type: 'VECTOR',
+          ALGORITHM: 'HNSW',
+          TYPE: 'FLOAT32',
+          DIM: 5,
+          DISTANCE_METRIC: 'L2',
+          INDEXMISSING: true,
+        },
+      },
+      { ON: 'HASH' }
+    );
+  }, GLOBAL.SERVERS.OPEN);
+
   testUtils.testWithClient('client.ft.create', async client => {
     assert.equal(
       await client.ft.create('index', {
@@ -578,7 +614,7 @@ describe('FT.CREATE', () => {
       }),
       "OK"
     );
-   
+
     assert.equal(
       await client.ft.create("index_int8", {
         field: {

packages/search/lib/commands/CREATE.ts

@@ -1,6 +1,6 @@
-import { CommandParser } from '@redis/client/dist/lib/client/parser';
-import { RedisArgument, SimpleStringReply, Command } from '@redis/client/dist/lib/RESP/types';
-import { RedisVariadicArgument, parseOptionalVariadicArgument } from '@redis/client/dist/lib/commands/generic-transformers';
+import { CommandParser } from '@redis/client/lib/client/parser';
+import { RedisArgument, SimpleStringReply, Command } from '@redis/client/lib/RESP/types';
+import { RedisVariadicArgument, parseOptionalVariadicArgument } from '@redis/client/lib/commands/generic-transformers';
 
 export const SCHEMA_FIELD_TYPE = {
   TEXT: 'TEXT',
@@ -195,12 +195,12 @@ export function parseSchema(parser: CommandParser, schema: RediSearchSchema) {
 
       parser.push(fieldOptions.type);
 
-      if (fieldOptions.INDEXMISSING) {
-        parser.push('INDEXMISSING');
-      }
-
       switch (fieldOptions.type) {
         case SCHEMA_FIELD_TYPE.TEXT:
+          if (fieldOptions.INDEXMISSING) {
+            parser.push('INDEXMISSING');
+          }
+
           if (fieldOptions.NOSTEM) {
             parser.push('NOSTEM');
           }
@@ -226,10 +226,18 @@ export function parseSchema(parser: CommandParser, schema: RediSearchSchema) {
 
         case SCHEMA_FIELD_TYPE.NUMERIC:
         case SCHEMA_FIELD_TYPE.GEO:
+          if (fieldOptions.INDEXMISSING) {
+            parser.push('INDEXMISSING');
+          }
+
           parseCommonSchemaFieldOptions(parser, fieldOptions)
           break;
 
         case SCHEMA_FIELD_TYPE.TAG:
+          if (fieldOptions.INDEXMISSING) {
+            parser.push('INDEXMISSING');
+          }
+
           if (fieldOptions.SEPARATOR) {
             parser.push('SEPARATOR', fieldOptions.SEPARATOR);
           }
@@ -320,13 +328,21 @@ export function parseSchema(parser: CommandParser, schema: RediSearchSchema) {
           }
           parser.pushVariadicWithLength(args);
 
+          if (fieldOptions.INDEXMISSING) {
+            parser.push('INDEXMISSING');
+          }
+
           break;
 
         case SCHEMA_FIELD_TYPE.GEOSHAPE:
           if (fieldOptions.COORD_SYSTEM !== undefined) {
             parser.push('COORD_SYSTEM', fieldOptions.COORD_SYSTEM);
           }
 
+          if (fieldOptions.INDEXMISSING) {
+            parser.push('INDEXMISSING');
+          }
+
           break;
       }
     }