From f2a1db03c4b1dec66d9f6ec72d3658de0a33b7aa Mon Sep 17 00:00:00 2001 From: rohitratannagar Date: Sat, 1 Aug 2026 02:40:46 +0530 Subject: [PATCH 1/6] fix(intelligent-assistant): show notebook file attachments sidebar separator Restore the missing horizontal divider between the notebook title and documents sections, and make the drawer resize splitter visible again. Fixes: RHDHBUGS-3511 Assisted-by: Composer Co-authored-by: Cursor --- .../components/__tests__/DocumentSidebar.test.tsx | 5 +++++ .../src/components/notebooks/DocumentSidebar.tsx | 14 +++++++++++++- .../src/components/notebooks/NotebookView.tsx | 1 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx index f01c397457f..68947d02023 100644 --- a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx +++ b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx @@ -55,6 +55,11 @@ describe('DocumentSidebar', () => { expect(screen.getByText('Test Notebook')).toBeInTheDocument(); }); + it('should render a separator between the title and documents sections', () => { + render(); + expect(screen.getByRole('separator')).toBeInTheDocument(); + }); + it('should render nothing when collapsed', () => { const { container } = render( , diff --git a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx index 34111003bb8..3422fae54fc 100644 --- a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx +++ b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx @@ -47,9 +47,15 @@ const useStyles = makeStyles(theme => ({ display: 'flex', alignItems: 'center', justifyContent: 'space-between', - marginBottom: theme.spacing(2), gap: theme.spacing(1), }, + sectionDivider: { + borderTop: '1px solid var(--pf-t--global--border--color--default)', + marginTop: theme.spacing(2), + marginBottom: theme.spacing(2), + marginLeft: -theme.spacing(2), + marginRight: -theme.spacing(2), + }, title: { fontWeight: 500, fontSize: '1.25rem', @@ -178,6 +184,12 @@ export const DocumentSidebar = ({ +
+
{t('notebook.view.documents.count', { diff --git a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/NotebookView.tsx b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/NotebookView.tsx index b07d0bd4688..7dc442bce77 100644 --- a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/NotebookView.tsx +++ b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/NotebookView.tsx @@ -93,6 +93,7 @@ const useStyles = makeStyles(theme => ({ '& .pf-v6-c-drawer__splitter, & .pf-v5-c-drawer__splitter': { backgroundColor: 'var(--pf-t--global--background--color--floating--default)', + borderRight: '1px solid var(--pf-t--global--border--color--default)', }, }, expandStrip: { From 9d11bc59750ca50b9d6ba520c4f762b77854dca5 Mon Sep 17 00:00:00 2001 From: rohitratannagar Date: Sat, 1 Aug 2026 04:56:36 +0530 Subject: [PATCH 2/6] fix(intelligent-assistant): add border fallback and changeset for sidebar separator Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3511 Signed-off-by: rohitratannagar Co-authored-by: Cursor --- .../.changeset/brave-dividers-show.md | 5 +++++ .../__tests__/DocumentSidebar.test.tsx | 17 ++++++++++++++++- .../components/notebooks/DocumentSidebar.tsx | 2 +- 3 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 workspaces/intelligent-assistant/.changeset/brave-dividers-show.md diff --git a/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md b/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md new file mode 100644 index 00000000000..42a0fab0d75 --- /dev/null +++ b/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md @@ -0,0 +1,5 @@ +--- +'@red-hat-developer-hub/backstage-plugin-intelligent-assistant': patch +--- + +Restore the missing horizontal divider between the notebook title and documents sections in the file attachments sidebar, and make the drawer resize splitter visible again. diff --git a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx index 68947d02023..d5e107cee95 100644 --- a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx +++ b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/__tests__/DocumentSidebar.test.tsx @@ -57,7 +57,22 @@ describe('DocumentSidebar', () => { it('should render a separator between the title and documents sections', () => { render(); - expect(screen.getByRole('separator')).toBeInTheDocument(); + const separator = screen.getByRole('separator'); + expect(separator).toBeInTheDocument(); + expect(separator.className).toMatch(/sectionDivider/); + expect( + Array.from(document.styleSheets).some(sheet => { + try { + return Array.from(sheet.cssRules).some(rule => + rule.cssText.includes( + '--pf-t--global--border--color--default, #c7c7c7', + ), + ); + } catch { + return false; + } + }), + ).toBe(true); }); it('should render nothing when collapsed', () => { diff --git a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx index 3422fae54fc..7c92bb48fa0 100644 --- a/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx +++ b/workspaces/intelligent-assistant/plugins/intelligent-assistant/src/components/notebooks/DocumentSidebar.tsx @@ -50,7 +50,7 @@ const useStyles = makeStyles(theme => ({ gap: theme.spacing(1), }, sectionDivider: { - borderTop: '1px solid var(--pf-t--global--border--color--default)', + borderTop: '1px solid var(--pf-t--global--border--color--default, #c7c7c7)', marginTop: theme.spacing(2), marginBottom: theme.spacing(2), marginLeft: -theme.spacing(2), From 63434f7ce0cff259c0f459a8cde17ac74cf6ae50 Mon Sep 17 00:00:00 2001 From: rohitratannagar Date: Sat, 1 Aug 2026 15:32:20 +0530 Subject: [PATCH 3/6] address review: improve PR description with fix context Expand the changeset summary to document the problem, both UI fixes, and the PatternFly CSS variable fallback rationale for RHDHBUGS-3511. Co-authored-by: Cursor --- .../intelligent-assistant/.changeset/brave-dividers-show.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md b/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md index 42a0fab0d75..4ae1bae3de0 100644 --- a/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md +++ b/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md @@ -2,4 +2,4 @@ '@red-hat-developer-hub/backstage-plugin-intelligent-assistant': patch --- -Restore the missing horizontal divider between the notebook title and documents sections in the file attachments sidebar, and make the drawer resize splitter visible again. +Restore missing visual separators in the notebook file attachments sidebar. Adds a horizontal divider between the notebook title and documents sections, a visible border on the drawer resize splitter, and a CSS fallback color when PatternFly theme variables are unavailable. From f7b9e695059319d3dca5a5b6496e91d957ff77e2 Mon Sep 17 00:00:00 2001 From: rohitratannagar Date: Sun, 2 Aug 2026 23:43:21 +0530 Subject: [PATCH 4/6] address review: add author name to PR description Add @rohitratannagar as author in the PR description and include the RHDHBUGS-3511 ticket reference in the changeset summary. Co-authored-by: Cursor --- .../intelligent-assistant/.changeset/brave-dividers-show.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md b/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md index 4ae1bae3de0..6c4d4338b54 100644 --- a/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md +++ b/workspaces/intelligent-assistant/.changeset/brave-dividers-show.md @@ -2,4 +2,4 @@ '@red-hat-developer-hub/backstage-plugin-intelligent-assistant': patch --- -Restore missing visual separators in the notebook file attachments sidebar. Adds a horizontal divider between the notebook title and documents sections, a visible border on the drawer resize splitter, and a CSS fallback color when PatternFly theme variables are unavailable. +Restore missing visual separators in the notebook file attachments sidebar (RHDHBUGS-3511). Adds a horizontal divider between the notebook title and documents sections, a visible border on the drawer resize splitter, and a CSS fallback color when PatternFly theme variables are unavailable. From 4c132771b9857a3bdd2e176fef6a3ce19860618f Mon Sep 17 00:00:00 2001 From: rohitratannagar Date: Sun, 2 Aug 2026 23:52:18 +0530 Subject: [PATCH 5/6] address review: add author name to PR description Restore @rohitratannagar as author in the PR description per review feedback. Co-authored-by: Cursor From ed1d0e18b4899506487c171ef80d04477f0fd253 Mon Sep 17 00:00:00 2001 From: rohitratannagar Date: Mon, 3 Aug 2026 15:23:15 +0530 Subject: [PATCH 6/6] address review: remove author name from PR description Remove the Author line from the PR description per review feedback. Co-authored-by: Cursor