Skip to content

Commit def489c

Browse files
committed
fix(lightspeed): moved CustomDrawer out of the packages/app
1 parent 9df40cc commit def489c

8 files changed

Lines changed: 26 additions & 8 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@red-hat-developer-hub/backstage-plugin-lightspeed': patch
3+
---
4+
5+
Moved the `CustomDrawer` component from `packages/app` to `plugins/lightspeed/dev` to resolve workspace accessibility issues during development.

workspaces/lightspeed/packages/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"@material-ui/core": "^4.12.2",
4848
"@material-ui/icons": "^4.9.1",
4949
"@mui/material": "^5.12.2",
50-
"@red-hat-developer-hub/backstage-plugin-lightspeed": "*",
50+
"@red-hat-developer-hub/backstage-plugin-lightspeed": "workspace:^",
5151
"@red-hat-developer-hub/backstage-plugin-theme": "^0.12.0",
5252
"react": "^18.0.2",
5353
"react-dom": "^18.0.2",

workspaces/lightspeed/packages/app/src/components/Root/ApplicationDrawer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
useEffect,
2323
useRef,
2424
} from 'react';
25-
import { CustomDrawer } from './CustomDrawer';
25+
import { CustomDrawer } from '@red-hat-developer-hub/backstage-plugin-lightspeed/dev';
2626

2727
/**
2828
* Partial drawer state exposed by drawer plugins

workspaces/lightspeed/packages/app/src/components/Root/CustomDrawer.tsx renamed to workspaces/lightspeed/plugins/lightspeed/dev/CustomDrawer.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@
1414
* limitations under the License.
1515
*/
1616

17-
/* eslint-disable no-restricted-imports */
1817
import Box from '@mui/material/Box';
1918
import Drawer from '@mui/material/Drawer';
20-
/* eslint-enable no-restricted-imports */
2119

2220
import { ThemeConfig } from '@red-hat-developer-hub/backstage-plugin-theme';
2321

22+
/**
23+
* @internal
24+
*/
2425
export type CustomDrawerProps = {
2526
children: React.ReactNode;
2627
minWidth?: number;
@@ -32,6 +33,9 @@ export type CustomDrawerProps = {
3233
[key: string]: any;
3334
};
3435

36+
/**
37+
* @internal
38+
*/
3539
export const CustomDrawer = (props: CustomDrawerProps) => {
3640
const {
3741
children,

workspaces/lightspeed/plugins/lightspeed/dev/DrawerComponent.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ import { PropsWithChildren } from 'react';
1818

1919
import { ChatbotDisplayMode } from '@patternfly/chatbot';
2020

21-
// eslint-disable-next-line @backstage/no-relative-monorepo-imports
22-
import { CustomDrawer } from '../../../packages/app/src/components/Root/CustomDrawer';
2321
import { useLightspeedDrawerContext } from '../src/hooks/useLightspeedDrawerContext';
22+
import { CustomDrawer } from './CustomDrawer';
2423

2524
export const DrawerComponent = ({ children }: PropsWithChildren) => {
2625
const { displayMode, drawerWidth, setDrawerWidth } =

workspaces/lightspeed/plugins/lightspeed/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"exports": {
1111
".": "./src/index.ts",
1212
"./alpha": "./src/alpha.ts",
13+
"./dev": "./dev/CustomDrawer.tsx",
1314
"./package.json": "./package.json"
1415
},
1516
"typesVersions": {
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
## API Report File for "@red-hat-developer-hub/backstage-plugin-lightspeed"
2+
3+
> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
4+
5+
```ts
6+
7+
// (No @packageDocumentation comment for this package)
8+
9+
```

workspaces/lightspeed/yarn.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10387,7 +10387,7 @@ __metadata:
1038710387
languageName: unknown
1038810388
linkType: soft
1038910389

10390-
"@red-hat-developer-hub/backstage-plugin-lightspeed@npm:*, @red-hat-developer-hub/backstage-plugin-lightspeed@workspace:plugins/lightspeed":
10390+
"@red-hat-developer-hub/backstage-plugin-lightspeed@workspace:^, @red-hat-developer-hub/backstage-plugin-lightspeed@workspace:plugins/lightspeed":
1039110391
version: 0.0.0-use.local
1039210392
resolution: "@red-hat-developer-hub/backstage-plugin-lightspeed@workspace:plugins/lightspeed"
1039310393
dependencies:
@@ -14900,7 +14900,7 @@ __metadata:
1490014900
"@material-ui/icons": "npm:^4.9.1"
1490114901
"@mui/material": "npm:^5.12.2"
1490214902
"@playwright/test": "npm:1.58.2"
14903-
"@red-hat-developer-hub/backstage-plugin-lightspeed": "npm:*"
14903+
"@red-hat-developer-hub/backstage-plugin-lightspeed": "workspace:^"
1490414904
"@red-hat-developer-hub/backstage-plugin-theme": "npm:^0.12.0"
1490514905
"@testing-library/dom": "npm:^9.0.0"
1490614906
"@testing-library/jest-dom": "npm:^6.0.0"

0 commit comments

Comments
 (0)