Modernize build files, upgrade Bazel

* Upgrade to Bazel 7
* Upgrade to `rules_proto` 1.0.0 and fix breakage
* Upgrade to protobuf 29.5
* Use `py_proto_library` from the protobuf repo, not `rules_proto` (deprecated)
* Use `cc_proto_library` from the protobuf repo, not `rules_cc` (deprecated)
* Actually run the cpp test in `bazel test`
* Remove `repo_mapping` cruft (isn't supported in modern Bazel versions anyway).

Author: neilconway

.bazeliskrc

@@ -1 +1,2 @@
-USE_BAZEL_VERSION=5.4.1
+USE_BAZEL_VERSION=7.6.1
+

.bazelrc

@@ -1,8 +1,16 @@
-# Use a remote build cache that's world-readable. Don't write unless told otherwise.
+# Disable Bazel modules (for now).
+common --enable_bzlmod=false
+
+build --cxxopt='-std=c++17'
+build --host_cxxopt='-std=c++17'
 
+# Use a remote build cache that's world-readable. Don't write unless told otherwise.
 build --remote_cache=https://storage.googleapis.com/reboot-dev-bazel-remote-cache-reboot-us
 build --remote_upload_local_results=false
 
 # Print full test logs for failed tests.
-
 test --test_output=errors
+
+# To debug errors using the remote cache we need the `--verbose_failures` flag to
+# get any useful information whatsoever.
+build --verbose_failures

WORKSPACE.bazel

@@ -2,7 +2,7 @@ workspace(name = "com_github_reboot_dev_pyprotoc_plugin")
 
 load("//bazel:repos.bzl", "repos")
 
-repos(external = False)
+repos()
 
 load("//bazel:py_toolchains.bzl", "py_toolchains")
 

bazel/deps.bzl

@@ -3,7 +3,7 @@
 load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
 load("@pyprotoc_plugin_pypi//:requirements.bzl", pypi_deps = "install_deps")
 
-def deps(repo_mapping = {}):
+def deps():
     protobuf_deps()
 
-    pypi_deps(repo_mapping = repo_mapping)
+    pypi_deps()

bazel/py_toolchains.bzl

@@ -2,11 +2,10 @@
 
 load("@rules_python//python:repositories.bzl", "py_repositories", "python_register_toolchains")
 
-def py_toolchains(repo_mapping = {}):
+def py_toolchains():
     py_repositories()
 
     python_register_toolchains(
         name = "python3_10_12",
         python_version = "3.10.12",
-        repo_mapping = repo_mapping,
     )

bazel/pypi_repos.bzl

@@ -3,12 +3,11 @@ should be installed later in WORKSPACE file to be accessible.
 `pip_parse` takes a `requirements_lock` file as input, which is
 generated by the `bazel run :requirements.update` command."""
 
-load("@python3_10_12//:defs.bzl", "interpreter")
 load("@rules_python//python:pip.bzl", "pip_parse")
 
 def pypi_repos():
     pip_parse(
         name = "pyprotoc_plugin_pypi",
-        python_interpreter_target = interpreter,
+        python_interpreter_target = "@python3_10_12_host//:python",
         requirements_lock = "@com_github_reboot_dev_pyprotoc_plugin//:requirements_lock.txt",
     )

bazel/repos.bzl

@@ -9,43 +9,26 @@
 # instructions at https://github.com/reboot-dev/pyprotoc-plugin.
 ########################################################################
 
-load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
 
-def repos(external = True, repo_mapping = {}):
-    """Adds repositories/archives needed by pyprotoc-plugin
+def repos():
+    """Adds repositories/archives needed by pyprotoc-plugin."""
 
-    Args:
-          external: whether or not we're invoking this function as though
-            though we're an external dependency
-          repo_mapping: passed through to all other functions that expect/use
-            repo_mapping, e.g., 'git_repository'
-    """
-    http_archive(
+    maybe(
+        http_archive,
         name = "rules_python",
-        sha256 = "9acc0944c94adb23fba1c9988b48768b1bacc6583b52a2586895c5b7491e2e31",
-        strip_prefix = "rules_python-0.27.0",
-        url = "https://github.com/bazelbuild/rules_python/releases/download/0.27.0/rules_python-0.27.0.tar.gz",
-        repo_mapping = repo_mapping,
+        sha256 = "4f7e2aa1eb9aa722d96498f5ef514f426c1f55161c3c9ae628c857a7128ceb07",
+        strip_prefix = "rules_python-1.0.0",
+        url = "https://github.com/bazelbuild/rules_python/releases/download/1.0.0/rules_python-1.0.0.tar.gz",
     )
 
-    if "com_google_protobuf" not in native.existing_rules():
-        git_repository(
-            name = "com_google_protobuf",
-            remote = "https://github.com/protocolbuffers/protobuf",
-            # Release v3.19.4.
-            # TODO(codingcanuck): Update to a newer release after
-            # https://github.com/protocolbuffers/protobuf/issues/9688 is fixed.
-            commit = "22d0e265de7d2b3d2e9a00d071313502e7d4cccf",
-            shallow_since = "1643340956 -0800",
-            repo_mapping = repo_mapping,
-        )
-
-    if external and "com_github_reboot_dev_pyprotoc_plugin" not in native.existing_rules():
-        git_repository(
-            name = "com_github_reboot_dev_pyprotoc_plugin",
-            remote = "https://github.com/reboot-dev/pyprotoc-plugin",
-            commit = "9f7a281670f03b77140c4437ac2a56b86f978af6",
-            shallow_since = "1649038239 +0000",
-            repo_mapping = repo_mapping,
-        )
+    maybe(
+        http_archive,
+        name = "com_google_protobuf",
+        sha256 = "955ef3235be41120db4d367be81efe6891c9544b3a71194d80c3055865b26e09",
+        strip_prefix = "protobuf-29.5",
+        urls = [
+            "https://github.com/protocolbuffers/protobuf/archive/v29.5.tar.gz",
+        ],
+    )

tests/cpp/BUILD.bazel

@@ -1,5 +1,6 @@
-load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_proto_library")
-load("@rules_proto//proto:defs.bzl", "proto_library")
+load("@com_google_protobuf//bazel:cc_proto_library.bzl", "cc_proto_library")
+load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")
+load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
 load("@rules_python//python:defs.bzl", "py_binary")
 load(":cpp_rule.bzl", "cc_generate_library")
 
@@ -54,7 +55,7 @@ cc_library(
     ],
 )
 
-cc_binary(
+cc_test(
     name = "cc_test",
     srcs = ["cc_generated_test.cc"],
     deps = [

tests/python/BUILD.bazel

@@ -1,10 +1,11 @@
-load("@com_google_protobuf//:protobuf.bzl", "py_proto_library")
-load("@rules_proto//proto:defs.bzl", "proto_library")
+load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")
+load("@com_google_protobuf//bazel:py_proto_library.bzl", "py_proto_library")
 load("@rules_python//python:defs.bzl", "py_binary", "py_library", "py_test")
 load(":sample_rule.bzl", "py_sample_library")
 
 py_test(
     name = "library_tests",
+    size = "small",
     srcs = [
         "library_tests.py",
     ],
@@ -30,7 +31,7 @@ proto_library(
 
 py_proto_library(
     name = "sample_messages_py_proto",
-    srcs = ["sample_messages.proto"],
+    deps = [":sample_messages_proto"],
 )
 
 proto_library(
@@ -41,8 +42,7 @@ proto_library(
 
 py_proto_library(
     name = "sample_service_py_proto",
-    srcs = ["sample_service.proto"],
-    deps = [":sample_messages_py_proto"],
+    deps = [":sample_messages_proto"],
 )
 
 py_sample_library(
@@ -62,6 +62,7 @@ py_library(
 
 py_test(
     name = "sample_generated_library_test",
+    size = "small",
     srcs = [
         "sample_generated_library_test.py",
     ],