From 0a441ec0c25019e001730290ecd905c781438440 Mon Sep 17 00:00:00 2001
From: Hashim1999164 <64767361+Hashim1999164@users.noreply.github.com>
Date: Thu, 20 Aug 2026 00:15:48 +0500
Subject: [PATCH] Avoid vector insert in mixed shared children persistence test

---
 tests/YGPersistenceTest.cpp | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/tests/YGPersistenceTest.cpp b/tests/YGPersistenceTest.cpp
index 929aee07ec..b3076f2bda 100644
--- a/tests/YGPersistenceTest.cpp
+++ b/tests/YGPersistenceTest.cpp
@@ -274,9 +274,16 @@ TEST(YogaTest, mixed_shared_and_owned_children) {
   YGNodeInsertChild(root1, root1_child0, 0);
   YGNodeInsertChild(root1, root1_child2, 1);
 
-  auto children = static_cast<yoga::Node*>(root1)->getChildren();
-  children.insert(children.begin() + 1, static_cast<yoga::Node*>(root0_child0));
-  static_cast<yoga::Node*>(root1)->setChildren(children);
+  // Build the child list without vector::insert. GCC 16 at -O2/-O3 reports a
+  // false array-bounds warning on insert(begin()+1, ...) and the test is
+  // compiled with -Werror.
+  auto* node1 = static_cast<yoga::Node*>(root1);
+  std::vector<yoga::Node*> children{
+      node1->getChild(0),
+      static_cast<yoga::Node*>(root0_child0),
+      node1->getChild(1),
+  };
+  node1->setChildren(children);
 
   auto secondChild = YGNodeGetChild(root1, 1);
   ASSERT_EQ(secondChild, YGNodeGetChild(root0, 0));