RDKEMW-15927 ,RDKEMW-15007 : [APACA/Xione DE] rbus self-deadlock in XConf privacy mode fetch causing ~188s T2 init delay

Reason for change: When UserSettings sets privacy mode to DO_NOT_SHARE during boot,
the rbus SET handler (t2PropertyDataSetHandler) runs synchronously
on the single rbus callback thread — executing deleteAllProfiles()
with pthread_join, disk I/O, and XConf client restart.

The restarted XConf thread calls appendRequestParams() which uses
getParameterValue(PRIVACYMODES_RFC) to fetch privacy mode. This
issues rbus_get() on T2's own bus handle, requiring the same rbus
callback thread that is already blocked processing the SET handler.
This creates a self-deadlock with a 15s rbus timeout per attempt,
compounded by XCONF_RETRY_TIMEOUT (180s), stalling T2 initialization.

Cascading effect: While T2 is stalled, external callers (e.g.
WPEFramework SystemServices plugin) invoking t2_event_s() block
15s each on rbus_getUint(Telemetry.OperationalStatus), delaying
the dispatch thread by ~188s and blocking sendNotify() for
EVT_ONSYSTEMPOWERSTATECHANGED.

Fix:
- xconfclient.c: Replace getParameterValue(PRIVACYMODES_RFC) with
  direct getPrivacyMode() call from privacycontrol library. The
  platform implementation (provided via meta layer bbappend) reads
  from a local in-memory cache (PRIVACY_STATE), with fallback to
  Thunder JSON-RPC (local HTTP) and persistent storage — none of
  which use rbus, eliminating the self-deadlock.
`
- xconf-client/Makefile.am: Add privacycontrol include path and
  build dependency when IS_PRIVACYCONTROL_ENABLED is set.

- telemetry_busmessage_sender.c: Add fast-fail file marker check
  (T2_COMPONENT_READY) before rbus_getUint() in isCachingRequired()
  to avoid 15s blocking timeout when T2 is not yet ready.
Test Procedure: please refer the ticket comments
Risks: Medium
Signed-off-by: Thamim Razith <ThamimRazith_AbbasAli@comcast.com>

Author: tabbas651

source/commonlib/telemetry_busmessage_sender.c

@@ -663,6 +663,13 @@ static bool isCachingRequired( )
         return false ;
     }
 
+    // Fast-fail: check file marker before making rbus call to avoid blocking on timeout
+    if (access(T2_COMPONENT_READY, F_OK) != 0)
+    {
+        EVENT_DEBUG("T2 component not ready (marker file absent), caching event\n");
+        return true;
+    }
+
     // Always check for t2 is ready to accept events. Shutdown target can bring down t2 process at runtime
     uint32_t t2ReadyStatus;
     rbusError_t retVal = RBUS_ERROR_SUCCESS;

source/xconf-client/Makefile.am

@@ -41,3 +41,9 @@ libxconfclient_la_CPPFLAGS = -fPIC -I${PKG_CONFIG_SYSROOT_DIR}$(includedir)/dbus
                                 -I${top_srcdir}/source/protocol/http
 
 libxconfclient_la_DEPENDENCIES = ${top_builddir}/source/ccspinterface/libccspinterface.la ${top_builddir}/source/t2parser/libt2parser.la
+
+if IS_PRIVACYCONTROL_ENABLED
+libxconfclient_la_CFLAGS += $(PRIVACYCONTROL_FLAG)
+libxconfclient_la_CPPFLAGS += -I${top_srcdir}/source/privacycontrol
+libxconfclient_la_DEPENDENCIES += ${top_builddir}/source/privacycontrol/libt2thunder_privacycontrol.la
+endif

source/xconf-client/xconfclient.c

@@ -42,6 +42,9 @@
 #include "persistence.h"
 #include "telemetry2_0.h"
 #include "busInterface.h"
+#if defined(PRIVACYMODES_CONTROL)
+#include "rdkservices_privacyutils.h"
+#endif
 #ifdef GTEST_ENABLE
 #define curl_easy_setopt curl_easy_setopt_mock
 #define curl_easy_getinfo curl_easy_getinfo_mock
@@ -503,22 +506,13 @@ T2ERROR appendRequestParams(CURLU *uri)
     rc = curl_url_set(uri, CURLUPART_QUERY, "version=2", CURLU_APPENDQUERY);
     T2_CURL_APPENDREQUEST_ERROR(rc);
 #if defined(PRIVACYMODES_CONTROL)
-    if(T2ERROR_SUCCESS == getParameterValue(PRIVACYMODES_RFC, &paramVal))
-    {
-        memset(tempBuf, 0, MAX_URL_ARG_LEN);
-        snprintf(tempBuf, MAX_URL_ARG_LEN, "privacyModes=%s", paramVal);
-        rc = curl_url_set(uri, CURLUPART_QUERY, tempBuf, CURLU_URLENCODE | CURLU_APPENDQUERY);
-        T2_CURL_APPENDREQUEST_ERROR(rc);
-        free(paramVal);
-        paramVal = NULL;
-    }
-    else
-    {
-        T2Error("Failed to get Value for %s\n", PRIVACYMODES_RFC);
-        ret = T2ERROR_FAILURE;
-        goto error;
-    }
-
+    getPrivacyMode(&paramVal);
+    memset(tempBuf, 0, MAX_URL_ARG_LEN);
+    snprintf(tempBuf, MAX_URL_ARG_LEN, "privacyModes=%s", paramVal);
+    rc = curl_url_set(uri, CURLUPART_QUERY, tempBuf, CURLU_URLENCODE | CURLU_APPENDQUERY);
+    T2_CURL_APPENDREQUEST_ERROR(rc);
+    free(paramVal);
+    paramVal = NULL;
 #endif
 error:
     if (NULL != tempBuf)