Optimize query

Author: indykoning

src/Models/Scopes/ForCurrentStoreWithoutLimitScope.php

@@ -14,8 +14,7 @@ class ForCurrentStoreWithoutLimitScope implements Scope
 {
     public array $uniquePerStoreKeys;
 
-    public function __construct(string|array $uniquePerStoreKey, public $storeIdColumn = 'store_id')
-    {
+    public function __construct(string|array $uniquePerStoreKey, public $storeIdColumn = 'store_id') {
         $this->uniquePerStoreKeys = is_array($uniquePerStoreKey) ? $uniquePerStoreKey : [$uniquePerStoreKey];
     }
 
@@ -35,18 +34,16 @@ public function apply(Builder $query, Model $model)
             ->where(fn ($query) => $query
                 // Remove values where we already have values in the current store.
                 ->where(function ($query) use ($scope, $model) {
-                    $columnKey = count($scope->uniquePerStoreKeys) === 1 ? $query->qualifyColumn($scope->uniquePerStoreKeys[0]) : DB::Raw('CONCAT(' . collect($scope->uniquePerStoreKeys)->map(fn ($key) => $query->qualifyColumn($key))->implode(",'-',") . ')');
-
                     $query
-                        ->whereNotIn($columnKey, function ($query) use ($scope, $model, $columnKey) {
+                        ->whereNotExists(function ($query) use ($scope, $model) {
                             $query
-                                ->select($columnKey)
-                                ->from($model->getTable())
-                                ->where($model->qualifyColumn($scope->storeIdColumn), config('rapidez.store'));
-                            foreach ($scope->uniquePerStoreKeys as $uniquePerStoreKey) {
-                                $query->whereColumn($model->qualifyColumn($uniquePerStoreKey), $model->qualifyColumn($uniquePerStoreKey));
+                                ->select(DB::raw(1))
+                                ->from($model->getTable() . ' as comparison')
+                                ->where('comparison.'.$this->storeIdColumn, config('rapidez.store'));
+                            foreach($scope->uniquePerStoreKeys as $uniquePerStoreKey) {
+                                $query->whereColumn('comparison.'.$uniquePerStoreKey, $model->qualifyColumn($uniquePerStoreKey));
                             }
-                        });
+                    });
                 })
                 // Unless the value IS the current store.
                 ->orWhere($query->qualifyColumn($this->storeIdColumn), config('rapidez.store'))