Support trust_server_certificate option in dbconsole (#1383)

* Support trust_server_certificate option in dbconsole

ODBC Driver 18+ encrypts connections by default and validates SSL
certificates, causing `rails dbconsole` to fail against SQL Server
instances using self-signed certificates (e.g. Docker). Pass the -C
flag to sqlcmd when trust_server_certificate is set in database.yml.

---------

Co-authored-by: Justin Dell <justin.dell@healthstrategyllc.com>
Co-authored-by: Aidan Haran <aidanharan@yahoo.com>

Author: 3 people

.github/workflows/ci.yml

@@ -1,12 +1,6 @@
 name: CI
 
-on:
-  push:
-    branches: [ main ]
-  pull_request:
-    branches: [ main ]
-  schedule:
-    - cron: '0 4 * * 0'
+on: [push, pull_request]
 
 jobs:
   test:

CHANGELOG.md

@@ -1,3 +1,9 @@
+## Unreleased
+
+#### Added
+
+- [#1383](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1383) Support trust_server_certificate option in dbconsole.
+
 ## v8.1.2
 
 #### Fixed

Gemfile

@@ -9,9 +9,10 @@ gemspec
 gem "bcrypt"
 gem "pg", "1.5.9"
 gem "sqlite3", ">= 2.1"
-gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]
+gem "tzinfo-data"
 gem "benchmark-ips"
-gem "minitest", ">= 5.15.0"
+gem "minitest", "~> 6.0"
+gem "minitest-mock"
 gem "msgpack", ">= 1.7.0"
 
 if ENV["RAILS_SOURCE"]

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -104,6 +104,7 @@ def dbconsole(config, options = {})
           args += ["-d", config.database.to_s] if config.database
           args += ["-U", sqlserver_config[:username].to_s] if sqlserver_config[:username]
           args += ["-P", sqlserver_config[:password].to_s] if sqlserver_config[:password]
+          args += ["-C"] if sqlserver_config[:trust_server_certificate]
 
           if sqlserver_config[:host]
             host_arg = "tcp:#{sqlserver_config[:host]}"

test/cases/dbconsole.rb test/cases/dbconsole_test_sqlserver.rbtest/cases/dbconsole.rb renamed to test/cases/dbconsole_test_sqlserver.rb

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
 class DbConsole < ActiveRecord::TestCase
-  subject { ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter }
+  subject { ActiveRecord::ConnectionAdapters::SQLServerAdapter }
 
-  it "uses sqlplus to connect to database" do
-    subject.expects(:find_cmd_and_exec).with("sqlcmd", "-d", "db", "-U", "user", "-P", "secret", "-S", "tcp:localhost,1433")
+  it "uses sqlcmd to connect to database" do
+    subject.expects(:find_cmd_and_exec).with("sqlcmd", "-d", "db", "-U", "user", "-P", "secret", "-C", "-S",
+      "tcp:localhost,1433")
 
-    config = make_db_config(adapter: "sqlserver", database: "db", username: "user", password: "secret", host: "localhost", port: 1433)
+    config = make_db_config(adapter: "sqlserver", database: "db", username: "user", password: "secret",
+      host: "localhost", port: 1433, trust_server_certificate: true)
 
     subject.dbconsole(config)
   end