Skip to content

Enforcement of locks #1188

@errge

Description

@errge

When intentionally changing the lock file by hand for enforcement of locks, I noticed this:

Cloning with-editor...

Warning (straight): Could not reset to commit "ca902ae02972bdd6919a902be2593d8cb6bd991c" in repository "with-editor"
Cloning with-editor...done

(Correct git hash would be with 991b at the end instead of c.)

I understand that in the name of user-friendliness if the lock file is screwed up, straight.el prefers to go ahead and just continue, but for me this is kind of an issue, as I consider this even security related (e.g. a package author can push malware at unchecked new master commits and make the locked commit go away with a rebase or something, so the next time I pull, I get the incorrect malwarish commit automatically). I know this is a convoluted attack, and I shouldn't be paranoid, but it still seems to me that this user friendliness is against the spirit of lock files.

Do I misunderstand something? If not, would it be possible to provide a flag, that I could just flip, e.g. something like straight-enforce-lock-files, I'm OK if it defaults to nil to be backward compatible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions