From ce3df09d9835f9f746c4c39528fdd367829d953b Mon Sep 17 00:00:00 2001 From: Jon Janzen Date: Thu, 18 Jun 2026 15:49:40 -0700 Subject: [PATCH 1/3] drop redundant TARGETS files that duplicate sister BUCK files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Initial chunk of fbcode/executorch TARGETS->BUCK migration. Removes 40 TARGETS files where: - 7 are byte-identical to their sister BUCK file, OR - 33 contain only a no-arg `define_common_targets()` call matching a sister BUCK that also calls `define_common_targets()` with no args In both cases fbcode falls through to the BUCK file (via `name_v2 = TARGETS,BUCK`) and evaluates the exact same content it did before. Any TARGETS that passes any argument to define_common_targets (positional or keyword) is intentionally excluded — those are the `is_fbcode = True` cases that need a separate, more careful treatment. Differential Revision: D109082060 --- backends/qualcomm/aot/wrappers/TARGETS | 5 ----- backends/qualcomm/builders/TARGETS | 5 ----- codegen/test/TARGETS | 8 -------- configurations/TARGETS | 8 -------- examples/devtools/example_runner/TARGETS | 8 -------- examples/qualcomm/executor_runner/TARGETS | 8 -------- extension/aten_util/TARGETS | 8 -------- extension/aten_util/test/TARGETS | 8 -------- extension/cuda/TARGETS | 8 -------- extension/image/TARGETS | 5 ----- extension/image/benchmark/TARGETS | 5 ----- extension/image/test/TARGETS | 5 ----- extension/pytree/aten_util/TARGETS | 7 ------- extension/pytree/aten_util/test/TARGETS | 8 -------- extension/runner_util/TARGETS | 8 -------- extension/tensor/TARGETS | 8 -------- extension/tensor/test/TARGETS | 8 -------- extension/testing_util/TARGETS | 8 -------- extension/testing_util/test/TARGETS | 8 -------- extension/threadpool/TARGETS | 8 -------- extension/threadpool/test/TARGETS | 8 -------- kernels/optimized/cpu/TARGETS | 8 -------- kernels/optimized/test/TARGETS | 8 -------- kernels/portable/cpu/util/TARGETS | 8 -------- kernels/portable/cpu/util/test/TARGETS | 8 -------- kernels/prim_ops/TARGETS | 7 ------- runtime/backend/TARGETS | 8 -------- runtime/backend/test/TARGETS | 8 -------- runtime/core/TARGETS | 8 -------- runtime/core/exec_aten/TARGETS | 8 -------- runtime/core/exec_aten/testing_util/TARGETS | 8 -------- runtime/core/exec_aten/testing_util/test/TARGETS | 8 -------- runtime/core/exec_aten/util/TARGETS | 8 -------- runtime/platform/TARGETS | 8 -------- runtime/platform/test/TARGETS | 8 -------- schema/TARGETS | 8 -------- schema/test/TARGETS | 8 -------- test/TARGETS | 8 -------- 38 files changed, 287 deletions(-) delete mode 100644 backends/qualcomm/aot/wrappers/TARGETS delete mode 100644 backends/qualcomm/builders/TARGETS delete mode 100644 codegen/test/TARGETS delete mode 100644 configurations/TARGETS delete mode 100644 examples/devtools/example_runner/TARGETS delete mode 100644 examples/qualcomm/executor_runner/TARGETS delete mode 100644 extension/aten_util/TARGETS delete mode 100644 extension/aten_util/test/TARGETS delete mode 100644 extension/cuda/TARGETS delete mode 100644 extension/image/TARGETS delete mode 100644 extension/image/benchmark/TARGETS delete mode 100644 extension/image/test/TARGETS delete mode 100644 extension/pytree/aten_util/TARGETS delete mode 100644 extension/pytree/aten_util/test/TARGETS delete mode 100644 extension/runner_util/TARGETS delete mode 100644 extension/tensor/TARGETS delete mode 100644 extension/tensor/test/TARGETS delete mode 100644 extension/testing_util/TARGETS delete mode 100644 extension/testing_util/test/TARGETS delete mode 100644 extension/threadpool/TARGETS delete mode 100644 extension/threadpool/test/TARGETS delete mode 100644 kernels/optimized/cpu/TARGETS delete mode 100644 kernels/optimized/test/TARGETS delete mode 100644 kernels/portable/cpu/util/TARGETS delete mode 100644 kernels/portable/cpu/util/test/TARGETS delete mode 100644 kernels/prim_ops/TARGETS delete mode 100644 runtime/backend/TARGETS delete mode 100644 runtime/backend/test/TARGETS delete mode 100644 runtime/core/TARGETS delete mode 100644 runtime/core/exec_aten/TARGETS delete mode 100644 runtime/core/exec_aten/testing_util/TARGETS delete mode 100644 runtime/core/exec_aten/testing_util/test/TARGETS delete mode 100644 runtime/core/exec_aten/util/TARGETS delete mode 100644 runtime/platform/TARGETS delete mode 100644 runtime/platform/test/TARGETS delete mode 100644 schema/TARGETS delete mode 100644 schema/test/TARGETS delete mode 100644 test/TARGETS diff --git a/backends/qualcomm/aot/wrappers/TARGETS b/backends/qualcomm/aot/wrappers/TARGETS deleted file mode 100644 index 0a42614a385..00000000000 --- a/backends/qualcomm/aot/wrappers/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/backends/qualcomm/builders/TARGETS b/backends/qualcomm/builders/TARGETS deleted file mode 100644 index 0a42614a385..00000000000 --- a/backends/qualcomm/builders/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/codegen/test/TARGETS b/codegen/test/TARGETS deleted file mode 100644 index 1e8cc179228..00000000000 --- a/codegen/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/configurations/TARGETS b/configurations/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/configurations/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/examples/devtools/example_runner/TARGETS b/examples/devtools/example_runner/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/examples/devtools/example_runner/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/examples/qualcomm/executor_runner/TARGETS b/examples/qualcomm/executor_runner/TARGETS deleted file mode 100644 index 1e8cc179228..00000000000 --- a/examples/qualcomm/executor_runner/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/aten_util/TARGETS b/extension/aten_util/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/aten_util/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/aten_util/test/TARGETS b/extension/aten_util/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/aten_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/cuda/TARGETS b/extension/cuda/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/cuda/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/image/TARGETS b/extension/image/TARGETS deleted file mode 100644 index 0a42614a385..00000000000 --- a/extension/image/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/image/benchmark/TARGETS b/extension/image/benchmark/TARGETS deleted file mode 100644 index 0a42614a385..00000000000 --- a/extension/image/benchmark/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/image/test/TARGETS b/extension/image/test/TARGETS deleted file mode 100644 index 0a42614a385..00000000000 --- a/extension/image/test/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/pytree/aten_util/TARGETS b/extension/pytree/aten_util/TARGETS deleted file mode 100644 index 77b38349334..00000000000 --- a/extension/pytree/aten_util/TARGETS +++ /dev/null @@ -1,7 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/pytree/aten_util/test/TARGETS b/extension/pytree/aten_util/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/pytree/aten_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/runner_util/TARGETS b/extension/runner_util/TARGETS deleted file mode 100644 index 1e8cc179228..00000000000 --- a/extension/runner_util/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/tensor/TARGETS b/extension/tensor/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/tensor/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/tensor/test/TARGETS b/extension/tensor/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/tensor/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/testing_util/TARGETS b/extension/testing_util/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/testing_util/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/testing_util/test/TARGETS b/extension/testing_util/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/testing_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/threadpool/TARGETS b/extension/threadpool/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/threadpool/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/threadpool/test/TARGETS b/extension/threadpool/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/threadpool/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/kernels/optimized/cpu/TARGETS b/kernels/optimized/cpu/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/kernels/optimized/cpu/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/kernels/optimized/test/TARGETS b/kernels/optimized/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/kernels/optimized/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/kernels/portable/cpu/util/TARGETS b/kernels/portable/cpu/util/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/kernels/portable/cpu/util/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/kernels/portable/cpu/util/test/TARGETS b/kernels/portable/cpu/util/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/kernels/portable/cpu/util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/kernels/prim_ops/TARGETS b/kernels/prim_ops/TARGETS deleted file mode 100644 index 77b38349334..00000000000 --- a/kernels/prim_ops/TARGETS +++ /dev/null @@ -1,7 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/backend/TARGETS b/runtime/backend/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/backend/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/backend/test/TARGETS b/runtime/backend/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/backend/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/core/TARGETS b/runtime/core/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/core/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/core/exec_aten/TARGETS b/runtime/core/exec_aten/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/core/exec_aten/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/core/exec_aten/testing_util/TARGETS b/runtime/core/exec_aten/testing_util/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/core/exec_aten/testing_util/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/core/exec_aten/testing_util/test/TARGETS b/runtime/core/exec_aten/testing_util/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/core/exec_aten/testing_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/core/exec_aten/util/TARGETS b/runtime/core/exec_aten/util/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/core/exec_aten/util/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/platform/TARGETS b/runtime/platform/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/platform/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/runtime/platform/test/TARGETS b/runtime/platform/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/runtime/platform/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/schema/TARGETS b/schema/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/schema/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/schema/test/TARGETS b/schema/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/schema/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/test/TARGETS b/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() From d42b8c87d0fe8468662e513f9fe62ec70e3ea416 Mon Sep 17 00:00:00 2001 From: Jon Janzen Date: Thu, 18 Jun 2026 15:49:40 -0700 Subject: [PATCH 2/3] migrate is_fbcode-flagged TARGETS files to BUCK with runtime detection Summary: Chunk 2 of fbcode/executorch TARGETS->BUCK migration. 5 directories where TARGETS called `define_common_targets(is_fbcode = True)` and the sister BUCK called `define_common_targets()`. The shared targets.bzl actually branches on is_fbcode, so the flag must be preserved. Replaces the BUCK call with `define_common_targets(is_fbcode = is_fbcode())` using `fbsource_utils.is_fbcode()` for runtime cell detection, then deletes TARGETS. fbcode falls through to BUCK and gets the True branch as before; xplat keeps getting the False branch. Directories migrated: - backends/vulkan/test/custom_ops - backends/vulkan/test/op_tests - codegen/tools - extension/runner_util/test - kernels/optimized Differential Revision: D109082061 --- backends/vulkan/test/custom_ops/BUCK | 5 +++-- backends/vulkan/test/custom_ops/TARGETS | 5 ----- backends/vulkan/test/op_tests/BUCK | 5 +++-- backends/vulkan/test/op_tests/TARGETS | 5 ----- codegen/tools/BUCK | 5 +++-- codegen/tools/TARGETS | 5 ----- extension/runner_util/test/BUCK | 5 +++-- extension/runner_util/test/TARGETS | 8 -------- kernels/optimized/BUCK | 5 +++-- kernels/optimized/TARGETS | 8 -------- 10 files changed, 15 insertions(+), 41 deletions(-) delete mode 100644 backends/vulkan/test/custom_ops/TARGETS delete mode 100644 backends/vulkan/test/op_tests/TARGETS delete mode 100644 codegen/tools/TARGETS delete mode 100644 extension/runner_util/test/TARGETS delete mode 100644 kernels/optimized/TARGETS diff --git a/backends/vulkan/test/custom_ops/BUCK b/backends/vulkan/test/custom_ops/BUCK index 1e8cc179228..f559a6f1cfe 100644 --- a/backends/vulkan/test/custom_ops/BUCK +++ b/backends/vulkan/test/custom_ops/BUCK @@ -1,8 +1,9 @@ # Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. +# targets.bzl. +load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode") load(":targets.bzl", "define_common_targets") oncall("executorch") -define_common_targets() +define_common_targets(is_fbcode = is_fbcode()) diff --git a/backends/vulkan/test/custom_ops/TARGETS b/backends/vulkan/test/custom_ops/TARGETS deleted file mode 100644 index e84397dc20e..00000000000 --- a/backends/vulkan/test/custom_ops/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(is_fbcode = True) diff --git a/backends/vulkan/test/op_tests/BUCK b/backends/vulkan/test/op_tests/BUCK index 1e8cc179228..f559a6f1cfe 100644 --- a/backends/vulkan/test/op_tests/BUCK +++ b/backends/vulkan/test/op_tests/BUCK @@ -1,8 +1,9 @@ # Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. +# targets.bzl. +load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode") load(":targets.bzl", "define_common_targets") oncall("executorch") -define_common_targets() +define_common_targets(is_fbcode = is_fbcode()) diff --git a/backends/vulkan/test/op_tests/TARGETS b/backends/vulkan/test/op_tests/TARGETS deleted file mode 100644 index e84397dc20e..00000000000 --- a/backends/vulkan/test/op_tests/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(is_fbcode = True) diff --git a/codegen/tools/BUCK b/codegen/tools/BUCK index 1e8cc179228..f559a6f1cfe 100644 --- a/codegen/tools/BUCK +++ b/codegen/tools/BUCK @@ -1,8 +1,9 @@ # Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. +# targets.bzl. +load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode") load(":targets.bzl", "define_common_targets") oncall("executorch") -define_common_targets() +define_common_targets(is_fbcode = is_fbcode()) diff --git a/codegen/tools/TARGETS b/codegen/tools/TARGETS deleted file mode 100644 index e84397dc20e..00000000000 --- a/codegen/tools/TARGETS +++ /dev/null @@ -1,5 +0,0 @@ -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(is_fbcode = True) diff --git a/extension/runner_util/test/BUCK b/extension/runner_util/test/BUCK index 1e8cc179228..f559a6f1cfe 100644 --- a/extension/runner_util/test/BUCK +++ b/extension/runner_util/test/BUCK @@ -1,8 +1,9 @@ # Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. +# targets.bzl. +load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode") load(":targets.bzl", "define_common_targets") oncall("executorch") -define_common_targets() +define_common_targets(is_fbcode = is_fbcode()) diff --git a/extension/runner_util/test/TARGETS b/extension/runner_util/test/TARGETS deleted file mode 100644 index 7ace4add7f9..00000000000 --- a/extension/runner_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(is_fbcode = True) diff --git a/kernels/optimized/BUCK b/kernels/optimized/BUCK index 1e8cc179228..f559a6f1cfe 100644 --- a/kernels/optimized/BUCK +++ b/kernels/optimized/BUCK @@ -1,8 +1,9 @@ # Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. +# targets.bzl. +load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode") load(":targets.bzl", "define_common_targets") oncall("executorch") -define_common_targets() +define_common_targets(is_fbcode = is_fbcode()) diff --git a/kernels/optimized/TARGETS b/kernels/optimized/TARGETS deleted file mode 100644 index beaebb81eeb..00000000000 --- a/kernels/optimized/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(True) From b0a41f63b1807d119a7dd57f9ba42225868a65f5 Mon Sep 17 00:00:00 2001 From: Jon Janzen Date: Thu, 18 Jun 2026 15:56:41 -0700 Subject: [PATCH 3/3] rename pure-boilerplate fbcode-only TARGETS to BUCK MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Chunk 3 of fbcode/executorch TARGETS->BUCK migration. 8 directories where only a TARGETS file existed (no sister BUCK). Each TARGETS is a no-arg `define_common_targets()` call, and each shared `targets.bzl` was verified to be xplat-compatible (no fbcode_macros loads, no fbcode-only kwargs like keep_gpu_sections or re_test_utils). Renaming TARGETS -> BUCK exposes these directories to xplat via dirsync. Because the targets.bzl is xplat-compatible, the rules will materialize in xplat for the first time — that is a deliberate side effect of the migration to a single canonical build file per directory. Directories migrated: - backends/aoti - backends/aoti/slim/c10/core - backends/aoti/slim/util - backends/aoti/slim/util/test - backends/qualcomm/partition - devtools/etdump/data_sinks/tests - examples/models/llama/experimental - extension/kernel_util/test extension/training/examples/CIFAR was excluded after a trial run — its targets.bzl uses a runtime.python_binary srcs attribute that the xplat python_binary macro rejects ("default_only is not allowed to be specified, but got [data_utils.py]"). It needs a manual fix to the targets.bzl before it can be migrated. Differential Revision: D109082059 --- backends/aoti/{TARGETS => BUCK} | 0 backends/aoti/slim/c10/core/{TARGETS => BUCK} | 0 backends/aoti/slim/util/{TARGETS => BUCK} | 0 backends/aoti/slim/util/test/{TARGETS => BUCK} | 0 backends/qualcomm/partition/{TARGETS => BUCK} | 0 devtools/etdump/data_sinks/tests/{TARGETS => BUCK} | 0 examples/models/llama/experimental/{TARGETS => BUCK} | 0 extension/kernel_util/test/{TARGETS => BUCK} | 0 8 files changed, 0 insertions(+), 0 deletions(-) rename backends/aoti/{TARGETS => BUCK} (100%) rename backends/aoti/slim/c10/core/{TARGETS => BUCK} (100%) rename backends/aoti/slim/util/{TARGETS => BUCK} (100%) rename backends/aoti/slim/util/test/{TARGETS => BUCK} (100%) rename backends/qualcomm/partition/{TARGETS => BUCK} (100%) rename devtools/etdump/data_sinks/tests/{TARGETS => BUCK} (100%) rename examples/models/llama/experimental/{TARGETS => BUCK} (100%) rename extension/kernel_util/test/{TARGETS => BUCK} (100%) diff --git a/backends/aoti/TARGETS b/backends/aoti/BUCK similarity index 100% rename from backends/aoti/TARGETS rename to backends/aoti/BUCK diff --git a/backends/aoti/slim/c10/core/TARGETS b/backends/aoti/slim/c10/core/BUCK similarity index 100% rename from backends/aoti/slim/c10/core/TARGETS rename to backends/aoti/slim/c10/core/BUCK diff --git a/backends/aoti/slim/util/TARGETS b/backends/aoti/slim/util/BUCK similarity index 100% rename from backends/aoti/slim/util/TARGETS rename to backends/aoti/slim/util/BUCK diff --git a/backends/aoti/slim/util/test/TARGETS b/backends/aoti/slim/util/test/BUCK similarity index 100% rename from backends/aoti/slim/util/test/TARGETS rename to backends/aoti/slim/util/test/BUCK diff --git a/backends/qualcomm/partition/TARGETS b/backends/qualcomm/partition/BUCK similarity index 100% rename from backends/qualcomm/partition/TARGETS rename to backends/qualcomm/partition/BUCK diff --git a/devtools/etdump/data_sinks/tests/TARGETS b/devtools/etdump/data_sinks/tests/BUCK similarity index 100% rename from devtools/etdump/data_sinks/tests/TARGETS rename to devtools/etdump/data_sinks/tests/BUCK diff --git a/examples/models/llama/experimental/TARGETS b/examples/models/llama/experimental/BUCK similarity index 100% rename from examples/models/llama/experimental/TARGETS rename to examples/models/llama/experimental/BUCK diff --git a/extension/kernel_util/test/TARGETS b/extension/kernel_util/test/BUCK similarity index 100% rename from extension/kernel_util/test/TARGETS rename to extension/kernel_util/test/BUCK