adding more tests

Author: jpchauvel

src/edit_python_pe/main.py

@@ -21,10 +21,9 @@
 class MemberApp(App):
     """Single app that toggles between a file list and a form while connected to a GitHub fork+push flow."""
 
-    def __init__(self, token: str, original_repo: Repository) -> None:
+    def __init__(self, repo_path: str) -> None:
         super().__init__()
-        self.token = token
-        self.original_repo = original_repo
+        self.repo_path = repo_path
 
     def compose(self) -> ComposeResult:
         # Two main containers: self.list_container for the file list, self.form_container for the form.
@@ -35,23 +34,7 @@ def compose(self) -> ComposeResult:
         yield self.form_container
 
     def on_mount(self) -> None:
-        """Perform setup: do fork if needed, set up UI."""
-        self.forked_repo = self.original_repo.create_fork()
-        self.FORKED_REPO_URL = self.forked_repo.clone_url
-        self.REPO_PATH = user_data_dir(
-            appname="edit-python-pe", appauthor="python.pe"
-        )
-
-        if not os.path.exists(self.REPO_PATH):
-            callbacks = pygit2.callbacks.RemoteCallbacks(
-                credentials=pygit2.UserPass(self.token, "x-oauth-basic")
-            )
-            sleep(3)
-            pygit2.clone_repository(
-                self.FORKED_REPO_URL, self.REPO_PATH, callbacks=callbacks
-            )
-
-        # 2) Build the list portion
+        # 1) Build the list portion
         self.list_title = Static("Archivos en 'blog/members':")
         self.list_view = ListView()
         self.quit_list_button = Button("Salir", id="quit_list")
@@ -63,13 +46,13 @@ def on_mount(self) -> None:
         self.list_container.mount(self.quit_list_button)
 
         md_files = glob.glob(
-            os.path.join(self.REPO_PATH, "blog", "members", "*.md")
+            os.path.join(self.repo_path, "blog", "members", "*.md")
         )
         for f in md_files:
             basename = os.path.basename(f)
             self.list_view.append(ListItem(Static(basename)))
 
-        # 3) Build the form portion, hidden at first
+        # 2) Build the form portion, hidden at first
         self.form_header = Static("Formulario de Miembro", classes="header")
         self.name_input = Input(placeholder="Nombre")
         self.email_input = Input(placeholder="Correo electrónico")
@@ -175,7 +158,7 @@ def on_list_view_selected(self, event: ListView.Selected) -> None:
         self.show_form()
 
     def load_file_into_form(self, filename: str) -> None:
-        path_md = os.path.join(self.REPO_PATH, "blog", "members", filename)
+        path_md = os.path.join(self.repo_path, "blog", "members", filename)
         if not os.path.exists(path_md):
             return
         try:
@@ -494,20 +477,20 @@ def save_member(self) -> None:
 
             # Write file
             file_path = os.path.join(
-                self.REPO_PATH, "blog", "members", f"{name_file}.md"
+                self.repo_path, "blog", "members", f"{name_file}.md"
             )
         else:
             name_file = self.current_file
             file_path = os.path.join(
-                self.REPO_PATH, "blog", "members", f"{name_file}"
+                self.repo_path, "blog", "members", f"{name_file}"
             )
         os.makedirs(os.path.dirname(file_path), exist_ok=True)
         with open(file_path, "w", encoding="utf-8") as f:
             f.write(md_content)
 
         # commit & push
-        repo = pygit2.Repository(self.REPO_PATH)
-        rel_path = os.path.relpath(file_path, self.REPO_PATH)
+        repo = pygit2.Repository(self.repo_path)
+        rel_path = os.path.relpath(file_path, self.repo_path)
         rel_path = pathlib.Path(rel_path).as_posix() # Force path to POSIX format so Windows backslashes (\) don't break pygit2
         repo.index.add(rel_path)
         repo.index.write()
@@ -592,7 +575,7 @@ async def on_event(self, event: Event) -> None:
 
 
 def get_repo() -> tuple[str, Repository]:
-    token: str = getpass.getpass(
+    token = getpass.getpass(
         "Por favor ingrese su access token personal de GitHub: "
     )
     g = Github(token)
@@ -609,9 +592,28 @@ def get_repo() -> tuple[str, Repository]:
         exit(1)
 
 
+def fork_repo(token: str, original_repo: Repository) -> str:
+    forked_repo = original_repo.create_fork()
+    forked_repo_url = forked_repo.clone_url
+    repo_path = user_data_dir(
+        appname="edit-python-pe", appauthor="python.pe"
+    )
+
+    if not os.path.exists(repo_path):
+        callbacks = pygit2.callbacks.RemoteCallbacks(
+            credentials=pygit2.UserPass(token, "x-oauth-basic")
+        )
+        sleep(3)
+        pygit2.clone_repository(
+            forked_repo_url, repo_path, callbacks=callbacks
+        )
+    return repo_path
+
+
 def main() -> None:
     token, original_repo = get_repo()
-    app = MemberApp(token=token, original_repo=original_repo)
+    repo_path = fork_repo(token, original_repo)
+    app = MemberApp(repo_path)
     app.run()
 
 

tests/test_member_app.py

@@ -16,7 +16,7 @@ def setUp(self):
         # Patch Github and Repository for testing
         self.token = "fake-token"
         self.repo = MagicMock()
-        self.app = MemberApp(token=self.token, original_repo=self.repo)
+        self.app = MemberApp(repo_path="test_repo")
         self.app.social_container = MagicMock()
         self.app.alias_container = MagicMock()
         self.app.list_container = MagicMock()
@@ -447,4 +447,77 @@ def stub_add_alias_entry():
         self.assertEqual(self.app.city_input.value, "Lima")
         self.assertEqual(self.app.homepage_input.value, "https://joe-doe.org")
         self.assertGreaterEqual(len(self.app.social_entries), 1)
-        self.assertGreaterEqual(len(self.app.alias_entries), 1)
+
+# Test for get_repo function
+import builtins
+from edit_python_pe.main import get_repo
+
+class TestGetRepo(unittest.TestCase):
+    @patch("edit_python_pe.main.getpass.getpass", return_value="valid-token")
+    @patch("edit_python_pe.main.Github")
+    def test_get_repo_success(self, mock_github, mock_getpass):
+        mock_repo = MagicMock()
+        mock_github.return_value.get_repo.return_value = mock_repo
+        token, repo = get_repo()
+        self.assertEqual(token, "valid-token")
+        self.assertEqual(repo, mock_repo)
+
+    @patch("edit_python_pe.main.getpass.getpass", return_value="invalid-token")
+    @patch("edit_python_pe.main.Github")
+    def test_get_repo_bad_credentials(self, mock_github, mock_getpass):
+        from github.GithubException import BadCredentialsException
+        mock_github.return_value.get_repo.side_effect = BadCredentialsException(401, "Bad credentials", None)
+        with self.assertRaises(SystemExit):
+            get_repo()
+
+    @patch("edit_python_pe.main.getpass.getpass", return_value="valid-token")
+    @patch("edit_python_pe.main.Github")
+    def test_get_repo_github_exception(self, mock_github, mock_getpass):
+        from github.GithubException import GithubException
+        mock_github.return_value.get_repo.side_effect = GithubException(404, "Not found", None)
+        with self.assertRaises(SystemExit):
+            get_repo()
+
+
+from edit_python_pe.main import fork_repo
+
+class TestForkRepo(unittest.TestCase):
+    @patch("edit_python_pe.main.user_data_dir", return_value="/tmp/testrepo")
+    @patch("edit_python_pe.main.os.path.exists", return_value=False)
+    @patch("edit_python_pe.main.pygit2.clone_repository")
+    @patch("edit_python_pe.main.sleep", return_value=None)
+    def test_fork_repo_clones_if_not_exists(self, mock_sleep, mock_clone, mock_exists, mock_user_data_dir):
+        mock_forked_repo = MagicMock()
+        mock_forked_repo.clone_url = "https://github.com/fake/fork.git"
+        mock_original_repo = MagicMock()
+        mock_original_repo.create_fork.return_value = mock_forked_repo
+        token = "fake-token"
+        repo_path = fork_repo(token, mock_original_repo)
+        mock_original_repo.create_fork.assert_called_once()
+        mock_clone.assert_called_once_with(
+            mock_forked_repo.clone_url, repo_path, callbacks=unittest.mock.ANY
+        )
+        self.assertEqual(repo_path, "/tmp/testrepo")
+
+    @patch("edit_python_pe.main.user_data_dir", return_value="/tmp/testrepo")
+    @patch("edit_python_pe.main.os.path.exists", return_value=True)
+    @patch("edit_python_pe.main.pygit2.clone_repository")
+    def test_fork_repo_no_clone_if_exists(self, mock_clone, mock_exists, mock_user_data_dir):
+        mock_forked_repo = MagicMock()
+
+from edit_python_pe.main import main
+
+class TestMainFunction(unittest.TestCase):
+    @patch("edit_python_pe.main.get_repo")
+    @patch("edit_python_pe.main.fork_repo")
+    @patch("edit_python_pe.main.MemberApp")
+    def test_main_runs_app(self, mock_member_app, mock_fork_repo, mock_get_repo):
+        mock_get_repo.return_value = ("token", MagicMock())
+        mock_fork_repo.return_value = "/tmp/testrepo"
+        mock_app_instance = MagicMock()
+        mock_member_app.return_value = mock_app_instance
+        main()
+        mock_get_repo.assert_called_once()
+        mock_fork_repo.assert_called_once()
+        mock_member_app.assert_called_once_with("/tmp/testrepo")
+        mock_app_instance.run.assert_called_once()