fix: foreign key 객체를 제대로 수정할 수 있도록 ModificationAudit 수정

Author: MU-Software

app/participant_portal_api/models.py

@@ -60,10 +60,28 @@ def __str__(self) -> str:
 
     def apply_modification(self, save: bool = False) -> models.Model:
         for field, value in self.modification_data.items():
-            setattr(self.instance, field, value)
+            if isinstance(value, list):
+                if not (sub_qs := getattr(self.instance, field, None)):
+                    continue
+                if not isinstance(sub_qs, models.manager.BaseManager):
+                    continue
+                for sub_value in value:
+                    if not isinstance(sub_value, dict):
+                        continue
+                    if not (sub_instance_id := sub_value.get("id")):
+                        continue
+                    sub_qs.filter(pk=sub_instance_id).update(**sub_value)
+            elif isinstance(value, dict):
+                if not (sub_instance := getattr(self.instance, field, None)):
+                    continue
+                for sub_field, sub_value in value.items():
+                    setattr(sub_instance, sub_field, sub_value)
+                sub_instance.save()
+            else:
+                setattr(self.instance, field, value)
 
         if save:
-            self.instance.save(update_fields=self.modification_data.keys())
+            self.instance.save()
 
         return self.instance
 

app/participant_portal_api/serializers/presentation.py

@@ -2,7 +2,6 @@
 import uuid
 
 from core.util.thread_local import get_current_user
-from django.db import transaction
 from event.presentation.models import Presentation, PresentationSpeaker
 from file.models import PublicFile
 from participant_portal_api.serializers.modification_audit import ModificationAuditCreationPortalSerializer
@@ -71,27 +70,22 @@ def to_representation(self, instance):
 
         return result
 
-    def create(self, validated_data):
-        raise NotImplementedError("Creation of presentations is not allowed in the participant portal.")
+    def validate(self, attrs: dict) -> dict:
+        attrs = super().validate(attrs)
 
-    @transaction.atomic
-    def update(self, presentation, validated_data):
-        speakers = typing.cast(list[PresentationSpeakerPortalData], validated_data["speakers"])
+        speakers = typing.cast(list[PresentationSpeakerPortalData], attrs["speakers"])
         if not isinstance(speakers, list):
             raise serializers.ValidationError("Speakers must be a list.")
 
         for speaker_data in speakers:
             if not (speaker_instance := self.get_speaker_instance(speaker_data["id"])):
-                raise serializers.ValidationError(
-                    f"Speaker with ID {speaker_data['id']} not found or does not belong to this presentation."
-                )
+                err_msg = f"Speaker with ID {speaker_data['id']} not found or does not belong to this presentation."
+                raise serializers.ValidationError(err_msg)
 
-            speaker_serializer = PresentationSpeakerPortalSerializer(
+            PresentationSpeakerPortalSerializer(
                 instance=speaker_instance,
                 data=speaker_data,
                 partial=True,
-            )
-            speaker_serializer.is_valid(raise_exception=True)
-            speaker_serializer.save()
+            ).is_valid(raise_exception=True)
 
-        return super().update(presentation, validated_data)
+        return attrs