address review

Author: skirpichev

pythoncapi_compat.h

@@ -1762,13 +1762,6 @@ typedef struct PyLongLayout {
     int8_t digit_endianness;
 } PyLongLayout;
 
-static const PyLongLayout PyLong_LAYOUT = {
-    PyLong_SHIFT,
-    sizeof(digit),
-    -1,  // least significant first
-    PY_LITTLE_ENDIAN ? -1 : 1,
-};
-
 typedef struct PyLongExport {
     int64_t value;
     uint8_t negative;
@@ -1782,6 +1775,13 @@ typedef struct PyLongWriter PyLongWriter;
 static inline const PyLongLayout*
 PyLong_GetNativeLayout(void)
 {
+    static const PyLongLayout PyLong_LAYOUT = {
+        PyLong_SHIFT,
+        sizeof(digit),
+        -1,  // least significant first
+        PY_LITTLE_ENDIAN ? -1 : 1,
+    };
+
     return &PyLong_LAYOUT;
 }
 

tests/test_pythoncapi_compat_cext.c

@@ -1439,6 +1439,7 @@ test_long_api(PyObject *Py_UNUSED(module), PyObject *Py_UNUSED(args))
     digits[0] = 123;
     obj = PyLongWriter_Finish(writer);
 
+    check_int(obj, -123);
     PyLong_Export(obj, &long_export);
     assert(long_export.value == -123);
     assert(long_export.digits == NULL);