Skip to content

Commit d4d6986

Browse files
committed
gh-155053: Address review comments
1 parent 7972d8c commit d4d6986

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Fix a crash in :class:`types.GenericAlias` when ``tuple_extend()`` fails
2-
during substitution of a ``TypeVarTuple`` under allocation failure.
1+
Fix a crash in :class:`types.GenericAlias` during substitution of a
2+
``TypeVarTuple`` under allocation failure.

Objects/genericaliasobject.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,8 @@ subs_tvars(PyObject *obj, PyObject *params,
302302
PyTuple_GET_SIZE(arg));
303303
if (j < 0) {
304304
Py_DECREF(subparams);
305-
/* tuple_extend() clears subargs on failure, so there is no
306-
reference left to decref here. */
305+
assert(subargs == NULL);
306+
/* tuple_extend() clears subargs on failure. */
307307
return NULL;
308308
}
309309
continue;

0 commit comments

Comments
 (0)