Corrected Indentation and moved test to seperate class

Author: priyanshu2282-cyber

Lib/test/test_socket.py

@@ -3573,41 +3573,6 @@ class SendmsgStreamTests(SendmsgTests):
     # Tests for sendmsg() which require a stream socket and do not
     # involve recvmsg() or recvmsg_into().
 
-    @unittest.skipUnless(hasattr(socket.socket, "sendmsg"),
-                     "sendmsg not supported")
-    def test_sendmsg_reentrant_ancillary_mutation(self):
-        self._test_sendmsg_reentrant_ancillary_mutation()
-
-    def _test_sendmsg_reentrant_ancillary_mutation(self):
-        import socket
-
-        seq = []
-
-        class Mut:
-            def __init__(self):
-                self.tripped = False
-            def __index__(self):
-                if not self.tripped:
-                    self.tripped = True
-                    seq.clear()
-                return 0
-
-        seq[:] = [
-            (socket.SOL_SOCKET, Mut(), b'x'),
-            (socket.SOL_SOCKET, 0, b'x'),
-        ]
-
-        left, right = socket.socketpair()
-        self.addCleanup(left.close)
-        self.addCleanup(right.close)
-
-        self.assertRaises(
-            (TypeError, OSError),
-            left.sendmsg,
-            [b'x'],
-            seq,
-        )
-
     def testSendmsgExplicitNoneAddr(self):
         # Check that peer address can be specified as None.
         self.assertEqual(self.serv_sock.recv(len(MSG)), MSG)
@@ -7526,6 +7491,32 @@ def detach():
             pass
 
 
+class SendmsgReentrancyTests(unittest.TestCase):
+
+    @unittest.skipUnless(hasattr(socket.socket, "sendmsg"),
+                         "sendmsg not supported")
+    def test_sendmsg_reentrant_ancillary_mutation(self):
+
+        class Mut:
+            def __index__(self):
+                seq.clear()
+                return 0
+
+        seq = [
+            (socket.SOL_SOCKET, Mut(), b'x'),
+            (socket.SOL_SOCKET, 0, b'x'),
+        ]
+
+        left, right = socket.socketpair()
+        self.addCleanup(left.close)
+        self.addCleanup(right.close)
+        self.assertRaises(
+            (TypeError, OSError),
+            left.sendmsg,
+            [b'x'],
+            seq,
+        )
+
 def setUpModule():
     thread_info = threading_helper.threading_setup()
     unittest.addModuleCleanup(threading_helper.threading_cleanup, *thread_info)

Modules/socketmodule.c

@@ -4982,8 +4982,8 @@ _socket_socket_sendmsg_impl(PySocketSockObject *s, PyObject *data_arg,
             PyErr_SetString(PyExc_TypeError,
                 "sendmsg() argument 2 must be an iterable");
             goto finally;
-    }
-    ncmsgs = PyTuple_GET_SIZE(cmsg_fast);
+        }
+        ncmsgs = PyTuple_GET_SIZE(cmsg_fast);
     }
 
 #ifndef CMSG_SPACE
@@ -5008,13 +5008,11 @@ _socket_socket_sendmsg_impl(PySocketSockObject *s, PyObject *data_arg,
         item = PyTuple_GET_ITEM(cmsg_fast, ncmsgbufs);
 
         if (!PyArg_Parse(item,
-                        "(iiy*):[sendmsg() ancillary data items]",
-                        &cmsgs[ncmsgbufs].level,
-                        &cmsgs[ncmsgbufs].type,
-                        &cmsgs[ncmsgbufs].data)){
+                       "(iiy*):[sendmsg() ancillary data items]",
+                       &cmsgs[ncmsgbufs].level,
+                       &cmsgs[ncmsgbufs].type,
+                       &cmsgs[ncmsgbufs].data))
             goto finally;
-        }
-
         bufsize = cmsgs[ncmsgbufs++].data.len;
 
 #ifdef CMSG_SPACE