Merge pull request #1087 from andre-motta/fix/scan-compiled-extensions-broken-symlinks

fix(sources): catch FileNotFoundError for broken symlinks

Author: mergify[bot]

src/fromager/sources.py

@@ -883,10 +883,11 @@ def scan_compiled_extensions(
             elif suffix not in ignore_suffixes:
                 # Path.walk() lists symlinks to directories as filenames
                 # rather than dirnames, causing IsADirectoryError on open().
+                # Broken symlinks raise FileNotFoundError on open().
                 try:
                     with filepath.open("rb") as f:
                         header = f.read(_MAGIC_HEADERS_READ)
-                except IsADirectoryError:
+                except (IsADirectoryError, FileNotFoundError):
                     continue
                 if header.startswith(magic_headers):
                     relpath = filepath.relative_to(root_dir)

tests/test_sources.py

@@ -285,3 +285,11 @@ def test_scan_compiled_extensions(
         assert matches == [pathlib.Path(filename)]
     else:
         assert matches == []
+
+
+def test_scan_compiled_extensions_broken_symlink(tmp_path: pathlib.Path) -> None:
+    """Verify broken symlinks are skipped without raising an error."""
+    broken_link = tmp_path / "broken_link"
+    broken_link.symlink_to(tmp_path / "nonexistent_target")
+    matches = sources.scan_compiled_extensions(tmp_path)
+    assert matches == []