Replace ends_with_case_insensitive with prefix_stricmp (closes #212)

Author: python-processing-unit

src/common.h

@@ -21,13 +21,6 @@
 #define prefix_stricmp strcasecmp
 #endif
 
-static inline int ends_with_case_insensitive(const char *s, const char *suffix) {
-    if (!s || !suffix)
-        return 0;
-    size_t ls = strlen(s), lf = strlen(suffix);
-    return lf <= ls && prefix_stricmp(s + (ls - lf), suffix) == 0;
-}
-
 static inline char *prefix_fullpath_dup(const char *path) {
     if (!path || path[0] == '\0') {
         return NULL;

src/extensions.c

@@ -129,8 +129,13 @@ static const char *platform_dynlib_suffix(void) {
 }
 
 static int has_dynlib_suffix(const char *path) {
-    return ends_with_case_insensitive(path, ".dll") || ends_with_case_insensitive(path, ".so") ||
-           ends_with_case_insensitive(path, ".dylib");
+    if (!path) {
+        return 0;
+    }
+    size_t plen = strlen(path);
+    return (plen >= 4 && prefix_stricmp(path + plen - 4, ".dll") == 0) ||
+           (plen >= 3 && prefix_stricmp(path + plen - 3, ".so") == 0) ||
+           (plen >= 6 && prefix_stricmp(path + plen - 6, ".dylib") == 0);
 }
 
 static char *path_join2(const char *a, const char *b) {

src/main.c

@@ -19,8 +19,10 @@ static int is_extension_arg(const char *arg) {
     if (!arg) {
         return 0;
     }
-    return ends_with_case_insensitive(arg, ".dll") || ends_with_case_insensitive(arg, ".so") ||
-           ends_with_case_insensitive(arg, ".dylib");
+    size_t alen = strlen(arg);
+    return (alen >= 4 && prefix_stricmp(arg + alen - 4, ".dll") == 0) ||
+           (alen >= 3 && prefix_stricmp(arg + alen - 3, ".so") == 0) ||
+           (alen >= 6 && prefix_stricmp(arg + alen - 6, ".dylib") == 0);
 }
 
 static char *path_dirname_dup(const char *path) {