OBF loading fixes (and info display enhancement)#1675
Open
csoeller wants to merge 6 commits into
Open
Conversation
- also provide some dimension info on OBF stacks in a series; this assists picking the right data during stack selection short of generating previews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing OBF loader (very usefully provided by @barentine) croaks when presented with 2D data as experienced locally with data from Abberior STEDYCON system.
This PR fixes that.
In addition, it provides slightly more detailed info when many stacks are contained in the OBF file (this includes MINFLUX
.msrfiles etc). We often have 10-15 datasets in a single OBF file and short of a full previewer (as implemented in Fiji Bioformats interface) getting at least the shape info can significantly help identifying the right confocal scan to select etc.Finally, this PR sneaks in a fix for VisGUI session file saving. The existing code did not enforce the
.pvsextension which in practice becomes quite problematic. The small fix tovisCore.pyseeks to rectify this. We use session files now all the time and getting a fix in would be great. Hopefully ok to make it part of this PR.Is this a bugfix or an enhancement?
Mostly bugfix but also some enhancement aspect, see above.
Proposed changes:
Checks for 2D in OBF load and some stack info printing enhancement. Plus session file extension enforcement which I'd view as a bugfix.
Checklist:
Checked with latest code from github mostly on macos, all changes though should be platform agnostic.