Extend `self` deprecation to module/package/session scoped fixtures inside classes

[The-Compiler]

#14071 added a deprecation warning for:

import pytest

class TestFixture:

    @pytest.fixture(scope="class")
    # without @classmethod
    def fixt(self):
        self.x = 23

    def test_fixt(self, fixt):
        print(self.x)

because that doesn't work which might be surprising to people.

However, the same issue exists with scopes module, package and session as well. We should extend the deprecation to those, and require that those are @staticmethod.

[pablopupo]

I can work on this. I’ll keep the existing class-scope behavior and add coverage for module, package, and session scopes, where fixture methods need to be static.

[The-Compiler]

@pablopupo Thanks for the offer, but I already started working on related changes during the development sprint, so I would prefer to finish this up myself. Forgot to assign myself though, just did so.

[pablopupo]

Thanks for letting me know. I’ll leave this with you.