fix: test cases

Author: mohammeds1992

.github/workflows/ci.yml

@@ -15,13 +15,33 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version: "1.24"
 
       - name: Build
         run: go build -v ./...
 
-      - name: Test
-        run: go test -v ./...
+      - name: Test with Coverage
+        run: |
+          mkdir -p .coverage
+          go test -v -race -covermode=atomic -coverprofile=.coverage/coverage.out ./cmd/... ./internal/...
+
+      - name: Coverage Summary
+        if: always()
+        run: |
+          if [ -f .coverage/coverage.out ]; then
+            echo "### Test Coverage" >> $GITHUB_STEP_SUMMARY
+            echo '```' >> $GITHUB_STEP_SUMMARY
+            go tool cover -func=.coverage/coverage.out | grep -E '(total:|^github)' >> $GITHUB_STEP_SUMMARY
+            echo '```' >> $GITHUB_STEP_SUMMARY
+          fi
+
+      - name: Upload Coverage
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report
+          path: .coverage/coverage.out
+          retention-days: 14
 
   lint:
     runs-on: ubuntu-latest
@@ -31,7 +51,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
+          go-version: "1.24"
 
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v7

.gitignore

@@ -1,3 +1,8 @@
 scripts/build/pchaind
 /push-validator
 /push-validator.backup
+
+# Coverage artifacts
+.coverage/
+coverage.out
+coverage.html

Makefile

@@ -0,0 +1,58 @@
+# push-validator-cli Makefile
+
+COVERAGE_DIR := .coverage
+COVERAGE_PROFILE := $(COVERAGE_DIR)/coverage.out
+COVERAGE_HTML := $(COVERAGE_DIR)/coverage.html
+PACKAGES := ./cmd/... ./internal/...
+MIN_COVERAGE ?= 10
+
+.PHONY: test coverage coverage-html coverage-check coverage-summary clean-coverage build lint help
+
+## test: Run all tests with race detection
+test:
+	go test -v -race $(PACKAGES)
+
+## coverage: Run tests with coverage and show per-package breakdown
+coverage: clean-coverage
+	@mkdir -p $(COVERAGE_DIR)
+	go test -v -race -covermode=atomic -coverprofile=$(COVERAGE_PROFILE) $(PACKAGES)
+	@echo ""
+	@echo "=== Coverage Summary ==="
+	@go tool cover -func=$(COVERAGE_PROFILE) | grep total:
+	@echo ""
+	@echo "=== Per-Package Coverage ==="
+	@go tool cover -func=$(COVERAGE_PROFILE)
+	@echo ""
+	@echo "Coverage profile: $(COVERAGE_PROFILE)"
+
+## coverage-html: Generate HTML coverage report and open it
+coverage-html: coverage
+	go tool cover -html=$(COVERAGE_PROFILE) -o $(COVERAGE_HTML)
+	@echo "HTML report: $(COVERAGE_HTML)"
+	@command -v open >/dev/null 2>&1 && open $(COVERAGE_HTML) || true
+
+## coverage-check: Verify coverage meets minimum threshold
+coverage-check: coverage
+	@bash scripts/check-coverage.sh $(MIN_COVERAGE)
+
+## coverage-summary: Print only the total coverage percentage
+coverage-summary:
+	@mkdir -p $(COVERAGE_DIR)
+	@go test -covermode=atomic -coverprofile=$(COVERAGE_PROFILE) $(PACKAGES) > /dev/null 2>&1
+	@go tool cover -func=$(COVERAGE_PROFILE) | grep total: | awk '{print $$3}'
+
+## clean-coverage: Remove coverage artifacts
+clean-coverage:
+	@rm -rf $(COVERAGE_DIR)
+
+## build: Build the push-validator binary
+build:
+	go build -o push-validator ./cmd/push-validator/
+
+## lint: Run golangci-lint
+lint:
+	golangci-lint run ./...
+
+## help: Show available targets
+help:
+	@grep -E '^## ' Makefile | sed 's/## //' | column -t -s ':'

cmd/push-validator/cmd_chain.go

@@ -39,7 +39,7 @@ Examples:
   push-validator chain install --force      # Force reinstall`,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			cfg := loadCfg()
-			p := ui.NewPrinter(flagOutput)
+			p := getPrinter()
 
 			installer := chain.NewInstaller(cfg.HomeDir)
 
@@ -107,9 +107,9 @@ Examples:
 					return fmt.Errorf("checksum verification failed: %w", err)
 				}
 				if verified {
-					fmt.Printf("  %s Checksum verified\n", p.Colors.Success("✓"))
+					fmt.Printf("  %s Checksum verified\n", p.Colors.Success(p.Colors.Emoji("✓")))
 				} else {
-					fmt.Printf("  %s Checksum file not available, skipping verification\n", p.Colors.Warning("⚠"))
+					fmt.Printf("  %s Checksum file not available, skipping verification\n", p.Colors.Warning(p.Colors.Emoji("⚠")))
 				}
 			}
 
@@ -130,9 +130,9 @@ Examples:
 			}
 
 			if installedVer != "" {
-				fmt.Printf("  %s Installed pchaind (%s)\n", p.Colors.Success("✓"), installedVer)
+				fmt.Printf("  %s Installed pchaind (%s)\n", p.Colors.Success(p.Colors.Emoji("✓")), installedVer)
 			} else {
-				fmt.Printf("  %s Installed pchaind %s\n", p.Colors.Success("✓"), release.TagName)
+				fmt.Printf("  %s Installed pchaind %s\n", p.Colors.Success(p.Colors.Emoji("✓")), release.TagName)
 			}
 
 			return nil

cmd/push-validator/cmd_cosmovisor.go

@@ -9,7 +9,6 @@ import (
 	"github.com/spf13/cobra"
 
 	"github.com/pushchain/push-validator-cli/internal/cosmovisor"
-	ui "github.com/pushchain/push-validator-cli/internal/ui"
 )
 
 var cosmovisorCmd = &cobra.Command{
@@ -69,7 +68,7 @@ Example:
 func runCosmovisorStatus(cmd *cobra.Command, args []string) error {
 	cfg := loadCfg()
 	p := getPrinter()
-	c := ui.NewColorConfigFromGlobal()
+	c := getPrinter().Colors
 
 	detection := cosmovisor.Detect(cfg.HomeDir)
 	svc := cosmovisor.New(cfg.HomeDir)
@@ -167,7 +166,7 @@ func runCosmovisorUpgradeInfo(cmd *cobra.Command, args []string) error {
 	}
 
 	p := getPrinter()
-	c := ui.NewColorConfigFromGlobal()
+	c := getPrinter().Colors
 
 	ctx, cancel := context.WithTimeout(cmd.Context(), 2*time.Minute)
 	defer cancel()

cmd/push-validator/cmd_doctor.go

@@ -45,7 +45,7 @@ func runDoctor(cmd *cobra.Command, args []string) error {
 		cfg.HomeDir = flagHome
 	}
 
-	c := ui.NewColorConfigFromGlobal()
+	c := getPrinter().Colors
 	results := []checkResult{}
 
 	// Header

cmd/push-validator/cmd_increase_stake.go

@@ -15,7 +15,7 @@ import (
 )
 
 // handleIncreaseStake allows validators to increase their stake after registration
-func handleIncreaseStake(cfg config.Config) {
+func handleIncreaseStake(cfg config.Config) error {
 	v := validator.NewWith(validator.Options{
 		BinPath:       findPchaind(),
 		HomeDir:       cfg.HomeDir,
@@ -35,27 +35,27 @@ func handleIncreaseStake(cfg config.Config) {
 			getPrinter().JSON(map[string]any{"ok": false, "error": valErr.Error()})
 		} else {
 			fmt.Println()
-			fmt.Println(getPrinter().Colors.Error("⚠️ Failed to retrieve validator information"))
+			fmt.Println(getPrinter().Colors.Error(getPrinter().Colors.Emoji("⚠️") + " Failed to retrieve validator information"))
 			fmt.Printf("Error: %v\n\n", valErr)
 			fmt.Println(getPrinter().Colors.Info("Make sure you are registered as a validator first:"))
 			fmt.Println(getPrinter().Colors.Apply(getPrinter().Colors.Theme.Command, "  push-validator register-validator"))
 			fmt.Println()
 		}
-		return
+		return fmt.Errorf("failed to retrieve validator information: %w", valErr)
 	}
 
 	if !myValInfo.IsValidator {
 		if flagOutput == "json" {
 			getPrinter().JSON(map[string]any{"ok": false, "error": "not a registered validator"})
 		} else {
 			fmt.Println()
-			fmt.Println(getPrinter().Colors.Error("❌ This node is not registered as a validator"))
+			fmt.Println(getPrinter().Colors.Error(getPrinter().Colors.Emoji("❌") + " This node is not registered as a validator"))
 			fmt.Println()
 			fmt.Println(getPrinter().Colors.Info("To register, use:"))
 			fmt.Println(getPrinter().Colors.Apply(getPrinter().Colors.Theme.Command, "  push-validator register-validator"))
 			fmt.Println()
 		}
-		return
+		return fmt.Errorf("not a registered validator")
 	}
 
 	// Display current validator info
@@ -87,10 +87,10 @@ func handleIncreaseStake(cfg config.Config) {
 		if flagOutput == "json" {
 			getPrinter().JSON(map[string]any{"ok": false, "error": convErr.Error()})
 		} else {
-			fmt.Println(p.Colors.Error("⚠️ Failed to convert validator address"))
+			fmt.Println(p.Colors.Error(p.Colors.Emoji("⚠️") + " Failed to convert validator address"))
 			fmt.Printf("Error: %v\n\n", convErr)
 		}
-		return
+		return fmt.Errorf("failed to convert validator address: %w", convErr)
 	}
 
 	// Get account balance from Cosmos SDK
@@ -102,10 +102,10 @@ func handleIncreaseStake(cfg config.Config) {
 		if flagOutput == "json" {
 			getPrinter().JSON(map[string]any{"ok": false, "error": balErr.Error()})
 		} else {
-			fmt.Println(p.Colors.Error("⚠️ Failed to retrieve balance"))
+			fmt.Println(p.Colors.Error(p.Colors.Emoji("⚠️") + " Failed to retrieve balance"))
 			fmt.Printf("Error: %v\n\n", balErr)
 		}
-		return
+		return fmt.Errorf("failed to retrieve balance: %w", balErr)
 	}
 
 	// Display balance info
@@ -141,12 +141,12 @@ func handleIncreaseStake(cfg config.Config) {
 		if flagOutput == "json" {
 			getPrinter().JSON(map[string]any{"ok": false, "error": "insufficient balance"})
 		} else {
-			fmt.Println(p.Colors.Error("❌ Insufficient balance to delegate"))
+			fmt.Println(p.Colors.Error(p.Colors.Emoji("❌") + " Insufficient balance to delegate"))
 			fmt.Println()
 			fmt.Println("You need at least 0.2 PC to increase stake (0.1 PC to delegate + 0.1 PC for fees).")
 			fmt.Println()
 		}
-		return
+		return fmt.Errorf("insufficient balance")
 	}
 
 	// Prompt for delegation amount
@@ -161,32 +161,32 @@ func handleIncreaseStake(cfg config.Config) {
 		input = strings.TrimSpace(input)
 
 		if input == "" {
-			fmt.Println(p.Colors.Error("⚠ Amount is required. Try again."))
+			fmt.Println(p.Colors.Error(p.Colors.Emoji("⚠") + " Amount is required. Try again."))
 			continue
 		}
 
 		// Parse user input
 		delegateAmount, err := strconv.ParseFloat(input, 64)
 		if err != nil {
-			fmt.Println(p.Colors.Error("⚠ Invalid amount. Enter a number. Try again."))
+			fmt.Println(p.Colors.Error(p.Colors.Emoji("⚠") + " Invalid amount. Enter a number. Try again."))
 			continue
 		}
 
 		// Validate bounds
 		if delegateAmount < minDelegatePC {
-			fmt.Printf(p.Colors.Error("⚠ Amount too low. Minimum delegation is %.1f PC. Try again.\n"), minDelegatePC)
+			fmt.Printf(p.Colors.Error(p.Colors.Emoji("⚠") + " Amount too low. Minimum delegation is %.1f PC. Try again.\n"), minDelegatePC)
 			continue
 		}
 		if delegateAmount > maxDelegatePCVal {
-			fmt.Printf(p.Colors.Error("⚠ Insufficient balance. Maximum: %.1f PC. Try again.\n"), maxDelegatePCVal)
+			fmt.Printf(p.Colors.Error(p.Colors.Emoji("⚠") + " Insufficient balance. Maximum: %.1f PC. Try again.\n"), maxDelegatePCVal)
 			continue
 		}
 
 		// Convert to wei
 		delegateWei := new(big.Float).Mul(new(big.Float).SetFloat64(delegateAmount), new(big.Float).SetFloat64(1e18))
 		delegationAmount = delegateWei.Text('f', 0)
 
-		fmt.Printf(p.Colors.Success("✓ Will delegate %.6f PC\n"), delegateAmount)
+		fmt.Printf(p.Colors.Success(p.Colors.Emoji("✓") + " Will delegate %.6f PC\n"), delegateAmount)
 		fmt.Println()
 		break
 	}
@@ -211,7 +211,7 @@ func handleIncreaseStake(cfg config.Config) {
 				keyName = foundKey
 				if flagOutput != "json" {
 					fmt.Println()
-					fmt.Printf("🔑 Using key: %s\n", keyName)
+					fmt.Printf("%s Using key: %s\n", p.Colors.Emoji("🔑"), keyName)
 				}
 			} else {
 				// Fall back to default if key not found
@@ -229,10 +229,10 @@ func handleIncreaseStake(cfg config.Config) {
 		if flagOutput == "json" {
 			getPrinter().JSON(map[string]any{"ok": false, "error": "could not determine key name"})
 		} else {
-			fmt.Println(p.Colors.Error("⚠️ Could not determine key name"))
+			fmt.Println(p.Colors.Error(p.Colors.Emoji("⚠️") + " Could not determine key name"))
 			fmt.Println()
 		}
-		return
+		return fmt.Errorf("could not determine key name")
 	}
 
 	// Execute delegation
@@ -252,10 +252,10 @@ func handleIncreaseStake(cfg config.Config) {
 			getPrinter().JSON(map[string]any{"ok": false, "error": delegErr.Error()})
 		} else {
 			fmt.Println()
-			fmt.Println(p.Colors.Error("❌ Delegation failed"))
+			fmt.Println(p.Colors.Error(p.Colors.Emoji("❌") + " Delegation failed"))
 			fmt.Printf("Error: %v\n\n", delegErr)
 		}
-		return
+		return fmt.Errorf("delegation transaction failed: %w", delegErr)
 	}
 
 	// Success output
@@ -267,7 +267,7 @@ func handleIncreaseStake(cfg config.Config) {
 		})
 	} else {
 		fmt.Println()
-		p.Success("✅ Delegation successful!")
+		p.Success(p.Colors.Emoji("✅") + " Delegation successful!")
 		fmt.Println()
 
 		// Display delegation details
@@ -291,4 +291,5 @@ func handleIncreaseStake(cfg config.Config) {
 		fmt.Println(p.Colors.Apply(p.Colors.Theme.Command, "     push-validator dashboard"))
 		fmt.Println()
 	}
+	return nil
 }