Unify pulp_labels key validation to allow hyphens, spaces, and dots

The three places validating label keys (pulp_labels_validator,
SetLabelSerializer/UnsetLabelSerializer, and LabelFilter) each allowed
different characters, making it possible to create labels that couldn't
be modified or filtered. Unify them all to accept alphanumerics,
underscores, spaces, hyphens, and dots.

closes #6456

Assisted-by: Claude (Cursor)
Made-with: Cursor

Author: gerrod3

CHANGES/6456.bugfix

@@ -0,0 +1,2 @@
+Unified `pulp_labels` key validation across create/update, `set_label`/`unset_label`, and label
+filters to consistently allow alphanumerics, underscores, spaces, hyphens, and dots.

pulpcore/app/serializers/base.py

@@ -564,7 +564,7 @@ class SetLabelSerializer(serializers.Serializer):
     Serializer for synchronously setting a label.
     """
 
-    key = serializers.SlugField(required=True)
+    key = serializers.RegexField(regex=r"^[\w .\-]+$", required=True)
     value = serializers.CharField(required=True, allow_null=True, allow_blank=True)
 
 
@@ -573,7 +573,7 @@ class UnsetLabelSerializer(serializers.Serializer):
     Serializer for synchronously UNsetting a label.
     """
 
-    key = serializers.SlugField(required=True)
+    key = serializers.RegexField(regex=r"^[\w .\-]+$", required=True)
     value = serializers.CharField(read_only=True)
 
     def validate_key(self, value):

pulpcore/app/serializers/fields.py

@@ -427,8 +427,11 @@ def pulp_labels_validator(value):
         value = json.loads(value)
 
     for k, v in value.items():
-        if not re.match(r"^[\w ]+$", k):
-            raise serializers.ValidationError(_("Key '{}' contains non-alphanumerics.").format(k))
+        if not re.match(r"^[\w .\-]+$", k):
+            raise serializers.ValidationError(
+                _("Key '{}' contains invalid characters. Only alphanumerics, underscores,"
+                  " spaces, hyphens, and dots are allowed.").format(k)
+            )
         if v is not None and re.search(r"[,()]", v):
             raise serializers.ValidationError(
                 _("Key '{}' contains value with comma or parenthesis.").format(k)

pulpcore/app/viewsets/custom_filters.py

@@ -313,7 +313,7 @@ def filter(self, qs, value):
             return qs
 
         for term in value.split(","):
-            match = re.match(r"(!?[\w\s]+)(=|!=|~)?(.*)?", term)
+            match = re.match(r"(!?[\w\s.\-]+)(=|!=|~)?(.*)?", term)
             if not match:
                 raise DRFValidationError(_("Invalid search term: '{}'.").format(term))
             key, op, val = match.groups()

pulpcore/tests/unit/serializers/test_fields.py

@@ -12,6 +12,11 @@
         {"key": ""},
         {"key": None},
         {"key1": "value", "key2": None, "key3": ""},
+        {"my-key": "value"},
+        {"my.key": "value"},
+        {"my key": "value"},
+        {"my-dotted.key": "value"},
+        {"spaced key-with.mixed_chars": "value"},
     ],
 )
 def test_pulp_labels_validator_valid(labels):
@@ -27,6 +32,8 @@ def test_pulp_labels_validator_valid(labels):
         {"key": "val(ue"},
         {"key": "val)ue"},
         {"bad!key": "value"},
+        {"bad:key": "value"},
+        {"bad@key": "value"},
     ],
 )
 def test_pulp_labels_validator_invalid(labels):