how to ignore the extend proto file

[chenjie199234]

here is the proto file

syntax="proto3";
package test;
option go_package="test/api;api";
import "pbex/pbex.proto";
service test{
    rpc hello_world(hello_world_req)returns(hello_world_resp){
        option (pbex.method)="get";
    }
}

message hello_world_req{
    string str=1[(pbex.string_bytes_len_eq)=10];
}
message hello_world_resp{
    string str=1;
}

here is the command to generate code

protoc -I ./ -I /path/to/pbex.proto --js_out=import_style=commonjs,binary:. *.proto

here is the generated code

var jspb = require('google-protobuf');
var goog = jspb;
var global = globalThis;

var pbex_pbex_pb = require('../pbex/pbex_pb.js');
goog.object.extend(proto, pbex_pbex_pb);
goog.exportSymbol('proto.test.hello_world_req', null, global);
goog.exportSymbol('proto.test.hello_world_resp', null, global);
......

the code will require pbex_pb.js,this should not be generated.

if i use golang's protoc-gen-go to generate the golang's code,it will ignore the extend,only generate the message struct

[dibenede]

Generally speaking, the generated code may differ between languages depending on what's needed. I'm not familiar with golang's in particular.

On the surface level, you have a proto file importing another and using its contents (pbex.string_bytes_len_eq, etc...). Is the require of pbex_pb.js causing a specific issue for you or is your concern more about trying to optimize the output?

[dibenede]

Oh, I think see. Using -I /.../pbex.proto doesn't result in pbex_pb.js being generated, but it's required nonetheless and will cause the original module to fail to load.

[dibenede]

As another data point, using plain C++ protobuf (--cpp_out) has the same behavior as us.

[timostamm]

I do not believe that this is a bug in protobuf-javascript. This looks like a mistake in the protoc invocation.

I'm assuming this directory tree:

.
├── pbex
│   └── pbex.proto
└── test.proto

The following command:

protoc -I ./ -I ./pbex/pbex.proto --js_out=import_style=commonjs,binary:. *.proto

Will expand to:

protoc -I ./ -I ./pbex/pbex.proto --js_out=import_style=commonjs,binary:. test.proto

This means that protoc is only asked to generate code for test.proto. It will not generate code for pbex/pbex.proto by design.

The correct invocation to generate code for both files would be:

protoc -I ./ -I ./pbex/pbex.proto --js_out=import_style=commonjs,binary:. test.proto pbex/pbex.proto

The -I flag simply tells protoc where to look for files, not which files to generate code for. The second -I flag is incorrect and should be removed.