From 9c3a8c38cf80adff85a3b95fbad8a583fad4480d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gy=C3=B6rgy=20Krajcsovits?= Date: Thu, 12 Mar 2026 09:27:01 +0100 Subject: [PATCH 1/2] fix(om2): consistency between model and exposition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The model said that: A MetricFamily MUST have a name, HELP, TYPE, and UNIT metadata. However the exposition does not require it to be exposed, therefore for the sake of consistency we make this SHOULD. Also having all caps conflated the model with the exposition. Also this allows very simple exposers to not think about this. Signed-off-by: György Krajcsovits --- docs/specs/om/open_metrics_spec_2_0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/om/open_metrics_spec_2_0.md b/docs/specs/om/open_metrics_spec_2_0.md index 698500be0..ab16df4bc 100644 --- a/docs/specs/om/open_metrics_spec_2_0.md +++ b/docs/specs/om/open_metrics_spec_2_0.md @@ -148,7 +148,7 @@ If more than one MetricPoint is exposed for a Metric, then its MetricPoints MUST #### MetricFamily -A MetricFamily MAY have zero or more Metrics. A MetricFamily MUST have a name, HELP, TYPE, and UNIT metadata. Every Metric within a MetricFamily MUST have a unique LabelSet. +A MetricFamily MAY have zero or more Metrics. Every Metric within a MetricFamily MUST have a unique LabelSet. A MetricFamily SHOULD have a name, Help, Type, and Unit metadata. ##### Name From 07aba5a99e2d83c80a226a4433e9d340c18276c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gy=C3=B6rgy=20Krajcsovits?= Date: Fri, 13 Mar 2026 13:29:13 +0100 Subject: [PATCH 2/2] name is a must MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: György Krajcsovits --- docs/specs/om/open_metrics_spec_2_0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/om/open_metrics_spec_2_0.md b/docs/specs/om/open_metrics_spec_2_0.md index ab16df4bc..1990b2efd 100644 --- a/docs/specs/om/open_metrics_spec_2_0.md +++ b/docs/specs/om/open_metrics_spec_2_0.md @@ -148,7 +148,7 @@ If more than one MetricPoint is exposed for a Metric, then its MetricPoints MUST #### MetricFamily -A MetricFamily MAY have zero or more Metrics. Every Metric within a MetricFamily MUST have a unique LabelSet. A MetricFamily SHOULD have a name, Help, Type, and Unit metadata. +A MetricFamily MAY have zero or more Metrics. Every Metric within a MetricFamily MUST have a unique LabelSet. A MetricFamily MUST have a name and SHOULD have Help, Type, and Unit metadata. ##### Name