From 62d3eede2e4531348c2530d22ca5312a234b9389 Mon Sep 17 00:00:00 2001
From: aiirvizionz <david.lopezhuerta01@gmail.com>
Date: Thu, 23 Jul 2026 11:56:00 -0600
Subject: [PATCH] fix(ai-ionet): require clean api base urls

---
 packages/ai/ionet/src/index.test.ts | 25 ++++++++++++++++++++++---
 packages/ai/ionet/src/index.ts      | 22 +++++++++++++++++++++-
 2 files changed, 43 insertions(+), 4 deletions(-)

diff --git a/packages/ai/ionet/src/index.test.ts b/packages/ai/ionet/src/index.test.ts
index 58916085..f1c9c37d 100644
--- a/packages/ai/ionet/src/index.test.ts
+++ b/packages/ai/ionet/src/index.test.ts
@@ -84,22 +84,41 @@ describe('io.net IO Intelligence generation', () => {
   });
 
   it('supports text-style choices from compatible responses', async () => {
-    vi.stubGlobal('fetch', vi.fn().mockResolvedValue({
+    const fetchMock = vi.fn().mockResolvedValue({
       ok: true,
       json: async () => ({
         model: 'Qwen/Qwen2-VL-7B-Instruct',
         choices: [{ text: 'legacy text response' }],
       }),
-    }));
+    });
+    vi.stubGlobal('fetch', fetchMock);
 
-    const result = await adapter.generate(ctx(), 'hello', {}, { baseUrl: 'https://ionet.test/api/v1' });
+    const result = await adapter.generate(ctx(), 'hello', {}, { baseUrl: 'https://ionet.test/api/v1/' });
 
+    expect(fetchMock).toHaveBeenCalledOnce();
+    expect(fetchMock.mock.calls[0]?.[0]).toBe('https://ionet.test/api/v1/chat/completions');
     expect(result).toEqual({
       text: 'legacy text response',
       model: 'Qwen/Qwen2-VL-7B-Instruct',
     });
   });
 
+  it.each([
+    ['missing scheme', 'ionet.test/api/v1'],
+    ['ftp scheme', 'ftp://ionet.test/api/v1'],
+    ['credentials', 'https://user:pass@ionet.test/api/v1'],
+    ['query string', 'https://ionet.test/api/v1?token=secret'],
+    ['fragment', 'https://ionet.test/api/v1#chat'],
+  ])('rejects unclean custom baseUrl values: %s', async (_label, baseUrl) => {
+    const fetchMock = vi.fn();
+    vi.stubGlobal('fetch', fetchMock);
+
+    await expect(adapter.generate(ctx(), 'hello', {}, { baseUrl })).rejects.toThrow(
+      /io.net baseUrl/,
+    );
+    expect(fetchMock).not.toHaveBeenCalled();
+  });
+
   it('includes status and response body excerpt on errors', async () => {
     vi.stubGlobal('fetch', vi.fn().mockResolvedValue({
       ok: false,
diff --git a/packages/ai/ionet/src/index.ts b/packages/ai/ionet/src/index.ts
index 99fdc7f0..0a19f8df 100644
--- a/packages/ai/ionet/src/index.ts
+++ b/packages/ai/ionet/src/index.ts
@@ -28,7 +28,8 @@ export default defineAi<Config>({
     if (opts.system) messages.push({ role: 'system', content: opts.system });
     messages.push({ role: 'user', content: prompt });
 
-    const res = await fetch(`${config.baseUrl ?? DEFAULT_BASE}/chat/completions`, {
+    const baseUrl = cleanBaseUrl(config.baseUrl ?? DEFAULT_BASE);
+    const res = await fetch(`${baseUrl}/chat/completions`, {
       method: 'POST',
       headers: {
         authorization: `Bearer ${apiKey}`,
@@ -88,3 +89,22 @@ interface IoNetChatResponse {
     completion_tokens?: number;
   };
 }
+
+function cleanBaseUrl(value: string): string {
+  let url: URL;
+  try {
+    url = new URL(value);
+  } catch {
+    throw new Error('io.net baseUrl must be a valid URL');
+  }
+
+  if (url.protocol !== 'https:' && url.protocol !== 'http:') {
+    throw new Error('io.net baseUrl must use http or https');
+  }
+
+  if (url.username || url.password || url.search || url.hash) {
+    throw new Error('io.net baseUrl must be a clean API base without credentials, query, or hash');
+  }
+
+  return url.toString().replace(/\/+$/, '');
+}