Skip to content

Commit 5deeec2

Browse files
Merge pull request #80 from jmeridth/jm_fix_tests
fix: tests
2 parents 0c62184 + 0c330a9 commit 5deeec2

3 files changed

Lines changed: 23 additions & 4 deletions

File tree

CONTRIBUTING.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ Once a GitHub issue is accepted and assigned to you, please follow general workf
1212

1313
1. Fork the target repository under your GitHub username.
1414
2. Create a branch in your forked repository for the changes you are about to make.
15+
16+
- `bundle install` to install the dependencies
17+
- Make sure tests pass locally
18+
- You'll need to spin up a few containers (redis and memcached) to run the tests. You can do this by running `docker-compose up -d` in the root of the project.
19+
- Run tests with `COVERAGE=true bundle exec rake`
20+
1521
3. Commit your changes in the branch you created in step 2. All commits need to be signed-off. Check the [legal](#legal) section bellow for more details.
1622
4. Push your commits to your remote fork.
1723
5. Create a Pull Request from your remote fork pointing to the HEAD branch (usually `main` branch) of the target repository.
@@ -23,14 +29,14 @@ Procore projects use Developer Certificate of Origin ([DCO](https://GitHub.com/a
2329

2430
Please sign-off your contributions by doing ONE of the following:
2531

26-
* Use `git commit -s ...` with each commit to add the sign-off or
27-
* Manually add a `Signed-off-by: Your Name <your.email@example.com>` to each commit message.
32+
- Use `git commit -s ...` with each commit to add the sign-off or
33+
- Manually add a `Signed-off-by: Your Name <your.email@example.com>` to each commit message.
2834

2935
The email address must match your primary GitHub email. You do NOT need cryptographic (e.g. gpg) signing.
3036

31-
* Use `git commit -s --amend ...` to add a sign-off to the latest commit, if you forgot.
37+
- Use `git commit -s --amend ...` to add a sign-off to the latest commit, if you forgot.
3238

33-
*Note*: Some projects will provide specific configuration to ensure all commits are signed-off. Please check the project's documentation for more details.
39+
_Note_: Some projects will provide specific configuration to ensure all commits are signed-off. Please check the project's documentation for more details.
3440

3541
## Tests
3642

docker-compose.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
version: "3.5"
2+
3+
services:
4+
redis:
5+
image: redis:6.2.6
6+
ports:
7+
- "127.0.0.1:6379:6379"
8+
memcached:
9+
image: memcached:1.6.18
10+
ports:
11+
- "127.0.0.1:11211:11211"

lib/procore/errors.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
require 'ostruct'
2+
13
module Procore
24
# Generic / catch all error class. All other errors generated by the gem
35
# inherit from this class.

0 commit comments

Comments
 (0)