Skip to content

Styling Refactor on Non Clickable Options of File Menu #4121

@runningonsideprojects

Description

@runningonsideprojects

Issue Description

This specific subissue aims to address the several stylistic issues concerning the non clickable options of the File menu of the editor.

Namely:

  1. Changing the text color of the non-clickable menu option to adhere to WCAG guidelines
  2. Remove the on hover highlight for non-clickable menu options.

Location of the requested changes on the editor: https://editor.p5js.org/

Change Requested

WCAG guidelines state that non-text color contrast should be at least 3:1, and small text contrast should be 4.5:1. The foreground color the grayed out text is #747474, while the menu background color is #f0f0f0. This results in a color contrast ratio of 4.1:1.

  • The text color should be changed to #666
  • Remove the on hover menu highlight + tooltip on non clickable options

Visuals

Original (grayed out text: #747474. Regular text: #333)

Image

Text color modifications:

  • Grayed out text: #666 ($middle-dark)
  • Regular text: #1C1C1C($dark)
Image

On Hover Tooltip:

Image

Files to change

  • client/…/Header/Nav.jsx
  • client/…/components/_nav.scss

PR Criteria

  • Provide screenshots in ur PR of the visual changes implemented
  • Provide QA steps for how reviewers can ensure your changes are made properly

Additional Resources:

Metadata

Metadata

Labels

Area:AccessibilityCategory for accessibility related features and bugs

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions