lint

Author: csouchet

packages/addons/src/bpmn-elements.ts

@@ -23,12 +23,12 @@ const allBpmnElementKinds: BpmnElementKind[] = [...Object.values(ShapeBpmnElemen
 /**
  * Options to deduplicate elements when several names match.
  */
-export type DeduplicateNamesOptions = {
+export interface DeduplicateNamesOptions {
   /** If not set, use all `BpmnElementKind` values. */
   kinds?: BpmnElementKind[];
   /** Apply custom function to filter duplicates. */
   filter?: (bpmnSemantic: BpmnSemantic) => boolean;
-};
+}
 
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 const acceptAll = (_bpmnSemantic: BpmnSemantic): boolean => true;

packages/addons/src/paths.ts

@@ -88,17 +88,17 @@ export class CasePathResolver {
   }
 }
 
-export type CasePathResolverInput = {
+export interface CasePathResolverInput {
   /**
    * The IDs of elements (flowNodes/shapes and flows/edges) that are already completed. Non-existing ids will be silently ignored.
    *
    * `Completed` means that the element has been fully executed or definitively cancelled (for BPM engines that support this and allow cancelled elements to be continued).
    * No further user action or automation will update the element.
    */
   completedIds: string[];
-};
+}
 
-export type CasePathResolverOutput = {
+export interface CasePathResolverOutput {
   /**
    * The `BpmnSemantic` objects retrieved from the model that relate to the ids passed in {@link CasePathResolverInput}.
    */
@@ -114,4 +114,4 @@ export type CasePathResolverOutput = {
       edges: EdgeBpmnSemantic[];
     };
   };
-};
+}

packages/addons/src/plugins-support.ts

@@ -51,9 +51,9 @@ export interface Plugin {
  *
  * If you don't extend `GlobalOptions`, use {@link GlobalOptions} directly.
  */
-export type PluginOptionExtension = {
+export interface PluginOptionExtension {
   plugins?: PluginConstructor[];
-};
+}
 
 export type GlobalOptions = BaseGlobalOptions & PluginOptionExtension;
 
@@ -69,7 +69,7 @@ export type DefaultPlugins = 'css' | 'elements' | 'overlays' | 'style' | 'style-
 export type PluginIds = DefaultPlugins | (string & Record<never, never>);
 
 export class BpmnVisualization extends BaseBpmnVisualization {
-  private readonly plugins: Map<string, Plugin> = new Map();
+  private readonly plugins = new Map<string, Plugin>();
 
   constructor(options: GlobalOptions) {
     super(options);

packages/addons/src/plugins/style.ts

@@ -100,7 +100,7 @@ export class StyleByNamePlugin implements Plugin, StyleRegistryByName {
   }
 
   updateStyle(bpmnElementNames: string | string[], styleUpdate: StyleUpdate): void {
-    const bpmnElements = this.searcher.getElementsByNames(bpmnElementNames as Array<string>);
+    const bpmnElements = this.searcher.getElementsByNames(bpmnElementNames as string[]);
     this.styleRegistry.updateStyle(
       bpmnElements.map(bpmnElement => bpmnElement.id),
       styleUpdate,
@@ -112,7 +112,7 @@ export class StyleByNamePlugin implements Plugin, StyleRegistryByName {
       this.styleRegistry.resetStyle();
       return;
     }
-    const bpmnElements = this.searcher.getElementsByNames(bpmnElementNames as Array<string>);
+    const bpmnElements = this.searcher.getElementsByNames(bpmnElementNames as string[]);
     this.styleRegistry.resetStyle(bpmnElements.map(bpmnElement => bpmnElement.id));
   }
 }

packages/addons/test/spec/plugins/overlays.test.ts

@@ -183,7 +183,6 @@ class OverlaysExpectation {
     this.model = bpmnVisualization.graph.model;
   }
 
-  /* eslint-disable jest/no-standalone-expect -- util code, including expect calls */
   expectNoOverlay(bpmnId: string): void {
     expect(this.getOverlays(bpmnId)).toHaveLength(0);
   }
@@ -200,15 +199,14 @@ class OverlaysExpectation {
     expect(overlays).toHaveLength(labels.length);
     expect(overlays.map(overlay => overlay.label)).toEqual(labels);
   }
-  /* eslint-enable jest/no-standalone-expect */
 }
 
 // The real type is "class MxGraphCustomOverlay extends mxgraph.mxCellOverlay" but it is not part of the API so create a convenient matching type here
 // class BpmnVisualizationOverlay extends mxCellOverlay {}
 // In tests in this file, we are only checking the label, so use a simple type matching the label property of the actual type.
-type BpmnVisualizationOverlay = {
+interface BpmnVisualizationOverlay {
   label: string;
-};
+}
 
 function createOverlay(label: string): Overlay {
   return { label, position: 'top-center' };

packages/demo/src/plugins-by-name.ts

@@ -45,7 +45,7 @@ function clearAllStyles(): void {
   styleRegistryByName.resetStyle();
 }
 
-function pickRandomElement<T>(array: Array<T>): T {
+function pickRandomElement<T>(array: T[]): T {
   return array[Math.floor(Math.random() * array.length)];
 }
 

packages/demo/vite.config.ts

@@ -28,9 +28,9 @@ function findFiles(relativePathToSourceDirectory: string): string[] {
 }
 // =====================================================================================================================
 
-function generateInput(): { [p: string]: string } {
+function generateInput(): Record<string, string> {
   const pages = findFiles('pages');
-  const input: { [p: string]: string } = {
+  const input: Record<string, string> = {
     index: path.resolve(path.dirname(fileURLToPath(import.meta.url)), 'index.html'),
   };
   for (const page of pages) {