Minor refactoring

Author: Net-burst

src/main/java/org/prebid/server/auction/ExchangeService.java

@@ -680,9 +680,6 @@ private List<Eid> resolveAllowedEids(List<Eid> userEids, String bidder, EidPermi
     private boolean isUserEidAllowed(Eid eid,
                                      EidPermissionIndex eidPermissionIndex,
                                      String bidder) {
-        if (eidPermissionIndex == null) {
-            return true;
-        }
         return eidPermissionIndex.isAllowed(eid, bidder);
     }
 

src/main/java/org/prebid/server/auction/model/EidPermissionIndex.java

@@ -14,11 +14,11 @@
 
 public final class EidPermissionIndex {
 
-    // bitmask for which fields are present in a permission
-    private static final int INSERTER = 1; // 0001
-    private static final int SOURCE = 2; // 0010
-    private static final int MATCHER = 4; // 0100
-    private static final int MM = 8; // 1000
+    // Bitmask for which fields are present in the EID permission
+    private static final int INSERTER = 1 << 0;
+    private static final int SOURCE = 1 << 1;
+    private static final int MATCHER = 1 << 2;
+    private static final int MM = 1 << 3;
     private static final String WILDCARD_BIDDER = "*";
 
     private final Map<Integer, Map<Key, Set<String>>> ruleIndexByMask;
@@ -66,25 +66,17 @@ public static EidPermissionIndex build(List<ExtRequestPrebidDataEidPermissions>
     }
 
     private static int maskOf(String inserter, String source, String matcher, Integer mm) {
-        int mask = 0;
-
-        if (inserter != null) {
-            mask |= INSERTER;
-        }
-        if (source != null) {
-            mask |= SOURCE;
-        }
-        if (matcher != null) {
-            mask |= MATCHER;
-        }
-        if (mm != null) {
-            mask |= MM;
-        }
-
-        return mask;
+        return (inserter != null ? INSERTER : 0)
+                | (source != null ? SOURCE : 0)
+                | (matcher != null ? MATCHER : 0)
+                | (mm != null ? MM : 0);
     }
 
     public boolean isAllowed(Eid eid, String bidder) {
+        if (ObjectUtils.isEmpty(ruleIndexByMask)) {
+            return true;
+        }
+
         final int eidMask = maskOf(eid.getInserter(), eid.getSource(), eid.getMatcher(), eid.getMm());
 
         boolean ruleMatched = false;
@@ -93,8 +85,7 @@ public boolean isAllowed(Eid eid, String bidder) {
         for (Map.Entry<Integer, Map<Key, Set<String>>> ruleBucket : ruleIndexByMask.entrySet()) {
             final int ruleMask = ruleBucket.getKey();
 
-            // rule can only match if all its required fields exist on the Eid
-            if ((ruleMask & eidMask) != ruleMask) {
+            if (!isMaskMatched(ruleMask, eidMask)) {
                 continue;
             }
 
@@ -112,7 +103,11 @@ public boolean isAllowed(Eid eid, String bidder) {
             }
         }
 
-        // allow-by-default: if no rule matched at all, allow
+        // Allow by default if no rule matched at all
         return !ruleMatched;
     }
+
+    private boolean isMaskMatched(int ruleMaks, int eidMask) {
+        return (ruleMaks & eidMask) == ruleMaks;
+    }
 }