From 98a7fa3453018bee29528d02fb0a33f36814cefd Mon Sep 17 00:00:00 2001 From: Max R Date: Tue, 13 Jan 2026 19:29:19 -0500 Subject: [PATCH] Fix extra v in golang tags --- pre_commit_mirror_maker/languages.py | 7 +++++-- tests/languages_test.py | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/pre_commit_mirror_maker/languages.py b/pre_commit_mirror_maker/languages.py index 283012f..b6e40c4 100644 --- a/pre_commit_mirror_maker/languages.py +++ b/pre_commit_mirror_maker/languages.py @@ -43,7 +43,10 @@ def golang_get_package_versions(package_name: str) -> list[str]: ) url = f'https://proxy.golang.org/{escaped}/@v/list' resp = urllib.request.urlopen(url).read().decode() - return sorted(resp.splitlines(), key=version.parse) + return sorted( + (v.removeprefix('v') for v in resp.splitlines()), + key=version.parse, + ) def node_get_additional_dependencies( @@ -61,7 +64,7 @@ def rust_get_additional_dependencies( def golang_get_additional_dependencies( package_name: str, package_version: str, ) -> list[str]: - return [f'{package_name}@{package_version}'] + return [f'{package_name}@v{package_version}'] LIST_VERSIONS = { diff --git a/tests/languages_test.py b/tests/languages_test.py index 96e2a83..a076bb6 100644 --- a/tests/languages_test.py +++ b/tests/languages_test.py @@ -45,4 +45,5 @@ def test_rust_get_package_version_output(): def test_golang_get_package_version_output(): ret = golang_get_package_versions('mvdan.cc/gofumpt') assert ret + assert not any(v.startswith('v') for v in ret) assert_all_text(ret)