Keep clippy, the formatter, and pytest happy

Author: georgestagg

ggsql-python/tests/test_ggsql.py

@@ -392,25 +392,6 @@ def test_can_introspect_spec(self):
 class TestCustomReader:
     """Tests for custom Python reader support."""
 
-    def test_simple_custom_reader(self):
-        """Custom reader with execute_sql() method works."""
-
-        class SimpleReader:
-            def __init__(self):
-                self.conn = duckdb.connect()
-                self.conn.execute(
-                    "CREATE TABLE data AS SELECT * FROM ("
-                    "VALUES (1, 10), (2, 20), (3, 30)"
-                    ") AS t(x, y)"
-                )
-
-            def execute_sql(self, sql: str) -> pl.DataFrame:
-                return self.conn.execute(sql).pl()
-
-        reader = SimpleReader()
-        spec = ggsql.execute("SELECT * FROM data VISUALISE x, y DRAW point", reader)
-        assert spec.metadata()["rows"] == 3
-
     def test_custom_reader_with_register(self):
         """Custom reader with register() support."""
 
@@ -421,7 +402,7 @@ def __init__(self):
             def execute_sql(self, sql: str) -> pl.DataFrame:
                 return self.conn.execute(sql).pl()
 
-            def register(self, name: str, df: pl.DataFrame) -> None:
+            def register(self, name: str, df: pl.DataFrame, _replace: bool) -> None:
                 self.conn.register(name, df)
 
         reader = RegisterReader()
@@ -472,6 +453,9 @@ def __init__(self):
             def execute_sql(self, sql: str) -> pl.DataFrame:
                 return self.conn.execute(sql).pl()
 
+            def register(self, name: str, df: pl.DataFrame, _replace: bool) -> None:
+                self.conn.register(name, df)
+
         reader = DuckDBBackedReader()
         spec = ggsql.execute(
             "SELECT * FROM data VISUALISE x, y, category AS color DRAW point",
@@ -500,6 +484,9 @@ def execute_sql(self, sql: str) -> pl.DataFrame:
                 self.execute_calls.append(sql)
                 return self.conn.execute(sql).pl()
 
+            def register(self, name: str, df: pl.DataFrame, _replace: bool) -> None:
+                self.conn.register(name, df)
+
         reader = RecordingReader()
         ggsql.execute(
             "SELECT * FROM data VISUALISE x, y DRAW point",
@@ -522,8 +509,10 @@ def __init__(self):
             def execute_sql(self, sql: str) -> pl.DataFrame:
                 return self.con.con.execute(sql).pl()
 
-            def register(self, name: str, df: pl.DataFrame) -> None:
-                self.con.create_table(name, df.to_arrow(), overwrite=True)
+            def register(
+                self, name: str, df: pl.DataFrame, replace: bool = True
+            ) -> None:
+                self.con.create_table(name, df.to_arrow(), overwrite=replace)
 
             def unregister(self, name: str) -> None:
                 self.con.drop_table(name)

src/execute/cte.rs

@@ -257,7 +257,6 @@ pub fn has_executable_sql(source_tree: &SourceTree) -> bool {
     false
 }
 
-
 #[cfg(test)]
 mod tests {
     use super::*;

src/reader/duckdb.rs

@@ -819,7 +819,7 @@ mod tests {
     fn test_register_large_dataframe() {
         // duckdb-rs Arrow vtab has a vector capacity of 2048 rows. DataFrames
         // larger than this must be chunked to avoid a panic.
-        let mut reader = DuckDBReader::from_connection_string("duckdb://memory").unwrap();
+        let reader = DuckDBReader::from_connection_string("duckdb://memory").unwrap();
 
         let n = 3000;
         let ids: Vec<i32> = (0..n).collect();