Commit 8c444b4
committed
Fix inverted frontal plane: abduction swung limbs through the torso
`abduct`'s base Z sign was +1, but with every bone resting along -Y and
the body's right side at -X, a positive-Z rotation carries the
unmirrored (right-side) limb TOWARD the midline — and the left mirror
flipped it into the same mistake — so `shoulders: abduct 80` folded
both arms across the chest and `hips: abduct` crossed the legs. Every
frontal-plane example (lateral raise, jumping jacks, port de bras,
arms-to-second, horse stance, hip abduction) rendered mirrored, and
the thumb pinch adducted away from the fingers.
Flip abduct to -Z / adduct to +Z so positive abduction moves away from
the midline on both sides, matching what the spec already promised
("away from / toward midline"). The axial spine/neck lateral-flex
direction flips with it, so swap the actions in neck-side-stretch whose
cues name a side. Regression test checks all four limbs end up further
from the midline than their proximal joints, on the same side.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0164eTtmmq6U8GQkAEmQsvV51 parent 99363f3 commit 8c444b4
3 files changed
Lines changed: 53 additions & 9 deletions
File tree
- packages
- movit-parser/src
- movit-render/test
- spec/examples
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
134 | 136 | | |
135 | 137 | | |
136 | 138 | | |
137 | | - | |
138 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
139 | 147 | | |
140 | 148 | | |
141 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
458 | 458 | | |
459 | 459 | | |
460 | 460 | | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
0 commit comments