Skip to content

Commit 8223725

Browse files
committed
fix: stop feet sliding at gait phase transitions (reach, not ground-lock)
The closing / settling / about-face steps of the traveling gait moves declared their feet `ground-lock: feet` (planted) while the feet were actually relocating — closing home, stepping the trailing foot in, pivoting through a 180° about-face, or coming together in a waltz close. The grounding solver then reported the feet as planted-yet-drifting, up to ~0.95m (walk-cycle about-face), ~0.74m (walk-cycle arrival), and 0.13-0.21m across box-step / grapevine / chassé / waltz-box. Declare those relocating feet as `reach: foot_left/right floor` instead: the feet step to the floor at their settling position, which is what actually happens, so the false planted-drift disappears and the motion is unchanged. Only steps where the feet genuinely move are converted — a stationary plié/lower keeps `ground-lock: feet`, and the deliberately mid-move about-face turn's relocation is now honest. Eval: 1559/1559 checks on both shipped proportions, 0 clamp warnings, constraint warnings 151 -> 146; the large phase-transition foot-drift warnings are gone. 397/397 tests pass.
1 parent 094d453 commit 8223725

5 files changed

Lines changed: 14 additions & 7 deletions

File tree

spec/examples/box-step.posecode

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ posecode exercise "Box step"
4444
ankle_right: plantarflex 0
4545
shoulders: flex 0
4646
travel: 0 0
47-
ground-lock: feet
47+
reach: foot_left floor
48+
reach: foot_right floor
4849
cue "Close the left foot and settle over both feet, completing the square"
4950

5051
repeat 4

spec/examples/chasse.posecode

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ posecode exercise "Chassé"
6767
shoulders: abduct 0
6868
elbows: flex 0
6969
travel: 0 0
70-
ground-lock: feet
70+
reach: foot_left floor
71+
reach: foot_right floor
7172
cue "Close home over both feet and let the momentum resolve"
7273

7374
repeat 4

spec/examples/grapevine.posecode

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ posecode exercise "Grapevine"
7272
hip_right: abduct 0
7373
shoulders: abduct 0
7474
travel: 0 0
75-
ground-lock: feet
75+
reach: foot_left floor
76+
reach: foot_right floor
7677
cue "Close the left foot under the body and settle the phrase"
7778

7879
repeat 3

spec/examples/walk-cycle.posecode

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ posecode exercise "Walk & turn"
2828
shoulders: flex 0
2929
turn: 180
3030
travel: 0 0.66
31-
ground-lock: feet
31+
reach: foot_left floor
32+
reach: foot_right floor
3233
cue "Plant and turn a half-turn to face back the way you came"
3334

3435
step "Walk back" 0.7s flow:
@@ -48,7 +49,8 @@ posecode exercise "Walk & turn"
4849
shoulders: flex 0
4950
turn: 360
5051
travel: 0 0
51-
ground-lock: feet
52+
reach: foot_left floor
53+
reach: foot_right floor
5254
cue "Arrive home and turn to face front again"
5355

5456
repeat 2

spec/examples/waltz-box.posecode

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ posecode stretch "Waltz box step"
2828
knee_left: flex 0
2929
ankles: plantarflex 0
3030
travel: -0.2 0.2
31-
ground-lock: feet
31+
reach: foot_left floor
32+
reach: foot_right floor
3233
cue "Close the right foot to the left and lower softly through count three"
3334

3435
step "4 - left foot back" 0.95s flow:
@@ -57,7 +58,8 @@ posecode stretch "Waltz box step"
5758
shoulders: abduct 0
5859
elbows: flex 0
5960
travel: 0 0
60-
ground-lock: feet
61+
reach: foot_left floor
62+
reach: foot_right floor
6163
cue "Close the left foot and lower with control to complete the six-count box"
6264

6365
repeat 3

0 commit comments

Comments
 (0)