`StackElementIDGenerator` breaks `List` selection

[myihsan]

Description

Normally, pop to a List will also deselect the cell along with the pop transition, and this behavior depends on the value of NavigationLink in SwiftUI.
However, NavigationLink.init(state:label:fileID:filePath:line:column:) will increment the id each time, making the value unique.

swift-composable-architecture/Sources/ComposableArchitecture/Observation/NavigationStack+Observation.swift

Lines 249 to 250 in 7c2ed5d

	@Dependency(\.stackElementID) var stackElementID
	self.init(value: state.map { StackState.Component(id: stackElementID(), element: $0) }) {

With this implementation, the cell selection will not be retained during the push and pop, so the cell will be deselected instantly when pop (not during the transition).

Checklist

• I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
• If possible, I've reproduced the issue using the main branch of this package.
• This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

The value of NavigationLink remains the same when the state is the same.

Actual behavior

The value of NavigationLink changes each time.

Reproducing project

https://github.com/pointfreeco/swift-composable-architecture/blob/main/Examples/CaseStudies/SwiftUICaseStudies/04-NavigationStack.swift

[myihsan]

myihsan#1
I’ve drafted a PR that shows an approach for the expected behavior. It might not be the best, but I think it can give us a good idea of what we need to achieve.

If this approach works for you, I’d love to move forward with the formal PR.