Fix settings issue with list/object properties getting lost

Author: timothyschoen

Source/Dialogs/OverlayDisplaySettings.h

@@ -91,7 +91,7 @@ class OverlayDisplaySettings final : public Component
             }
 
             overlayState->setProperty(name, buttonBit);
-            SettingsFile::getInstance()->triggerSettingsChange("overlays");
+            SettingsFile::getInstance()->setProperty("overlays", var(overlayState.get()));
         }
 
         void resized() override
@@ -113,7 +113,7 @@ class OverlayDisplaySettings final : public Component
     explicit OverlayDisplaySettings(pd::Instance* pd)
         : pd(pd)
     {
-        auto const overlayTree = SettingsFile::getInstance()->getProperty<DynamicObject>("overlays");
+        auto overlayTree = SettingsFile::getInstance()->getProperty<DynamicObject>("overlays");
 
         canvasLabel.setText("Canvas", dontSendNotification);
         canvasLabel.setFont(Fonts::getSemiBoldFont().withHeight(14));

Source/Utility/SettingsFile.cpp

@@ -213,7 +213,7 @@ SettingsFile* SettingsFile::initialise()
     // No need to alert the user to this
     if (!settingsFile.existsAsFile() && !oldSettingsFile.existsAsFile()) {
         for (auto& [name, var] : defaultSettings) {
-            settings[name] = var;
+            settings[name] = var.clone();
         }
         settings["themes"] = JSON::parse(PlugDataLook::defaultThemesJSON);
         saveSettings();
@@ -226,7 +226,7 @@ SettingsFile* SettingsFile::initialise()
                 loadThemeFromDiff(*var.getArray());
                 continue;
             }
-            settings[name] = var;
+            settings[name] = var.clone();
         }
         for (auto& [name, value] : settings) {
             value.addListener(this);
@@ -724,11 +724,7 @@ void SettingsFile::saveSettings()
             if (!themesToWrite.isEmpty())
                 properties->setProperty("themes", themesToWrite);
         }
-        else if(defaultSettings[name].isArray())
-        {
-            properties->setProperty(name, value);
-        }
-        else if(!defaultSettings[name].equalsWithSameType(value)) {
+        else if(!defaultSettings.at(name).equalsWithSameType(value)) {
             properties->setProperty(name, value);
         }
     }

Source/Utility/SettingsFile.h

@@ -129,7 +129,7 @@ class SettingsFile final
 
     UnorderedMap<String, Value> settings;
 
-    UnorderedMap<String, var> defaultSettings {
+    UnorderedMap<String, var> const defaultSettings {
         { "browser_path", var(ProjectInfo::appDataDir.getFullPathName()) },
         { "theme", var("light") },
         { "oversampling", var(0) },
@@ -176,8 +176,10 @@ class SettingsFile final
         { "overlays", var(new DynamicObject()) },
         { "themes", var(Array<var> {}) },
         { "palettes", var(Array<var> {}) },
+        { "palettes_version", var(1) },
         { "audio_setup", var(new DynamicObject()) },
         { "window_size", var(Array<var> { 1000, 650 }) },
+        { "version", var("")},
     };
 
 public: