Fixes for automated tests

Author: timothyschoen

CMakeLists.txt

@@ -309,6 +309,12 @@ set(JUCE_COMPILE_DEFINITIONS
     JUCE_JACK_CLIENT_NAME="plugdata"
 )
 
+# Testing will run every help patch, which leads to some asserts due to standard Pd or ELSE patches outputting non-UTF8 text, invalid MIDI sequences, etc.
+# So for a better testing experience, we just disable assertions
+if(${ENABLE_TESTING})
+    list(APPEND JUCE_COMPILE_DEFINITIONS JUCE_DISABLE_ASSERTIONS=1)
+endif()
+
 if(LINUX)
  list(APPEND JUCE_COMPILE_DEFINITIONS JUCE_ALSA=1)
  if(ENABLE_WAYLAND)

Tests/ObjectFuzzTest.h

@@ -8,7 +8,7 @@ class ObjectFuzzTest : public PlugDataUnitTest
 private:
     void perform() override
     {
-        editor->pd->objectLibrary->waitForInitialisationToFinish();
+        //editor->pd->objectLibrary->waitForInitialisationToFinish();
 
         auto* cnv = editor->getTabComponent().newPatch();
         auto allObjects = editor->pd->objectLibrary->getAllObjects();
@@ -42,8 +42,8 @@ class ObjectFuzzTest : public PlugDataUnitTest
         editor->pd->unlockAudioThread();
 
         auto info = pd->objectLibrary->getObjectInfo(objectName);
-        auto methods = info.getChildWithName("methods");
-        auto arguments = info.getChildWithName("arguments");
+        auto methods = info.methods;
+        auto arguments = info.arguments;
 
         if(fuzzIncorrectly)
         {
@@ -55,7 +55,7 @@ class ObjectFuzzTest : public PlugDataUnitTest
         else {
             for(auto arg : arguments)
             {
-                auto type = arg.getProperty("type").toString();
+                auto type = arg.type;
                 if(type == "float")
                 {
                     objectName += " " + String(generateRandomFloat());
@@ -78,8 +78,8 @@ class ObjectFuzzTest : public PlugDataUnitTest
         lastY += 20;
         for (auto method : methods)
         {
-            auto methodName = method.getProperty("type").toString().toStdString();
-            auto description = method.getProperty("description").toString();
+            auto methodName = method.type.toStdString();
+            auto description = method.description;
             auto nameWithoutArgs = String(methodName).upToFirstOccurrenceOf("<", false, false).trim();
 
             SmallArray<pd::Atom> args;