ci: fix driver downloads, use pre-installed

- Export WEBDRIVER_PATH to reuse pre-installed runners drivers.

- Remove harmful stub fallback causing OS Error 193.

Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>

Author: WhiteMetagross

.github/workflows/build.yml

@@ -43,8 +43,11 @@ jobs:
           components: clippy
           targets: wasm32-unknown-unknown
       # lint plotly_static for all features
-      - run: cargo clippy -p plotly_static --features geckodriver,webdriver_download -- -D warnings -A deprecated
-      - run: cargo clippy -p plotly_static --features chromedriver,webdriver_download -- -D warnings -A deprecated
+      - run: |
+          export WEBDRIVER_PATH="${{ steps.setup-chrome.outputs.chromedriver-path }}"
+          export BROWSER_PATH="${{ steps.setup-chrome.outputs.chrome-path }}"
+          cargo clippy -p plotly_static --features geckodriver,webdriver_download -- -D warnings -A deprecated
+          cargo clippy -p plotly_static --features chromedriver,webdriver_download -- -D warnings -A deprecated
       # lint the main library workspace for non-wasm target
       - run: cargo clippy --features all -- -D warnings -A deprecated
       # lint the non-wasm examples
@@ -132,7 +135,10 @@ jobs:
       # Run tests on Ubuntu with Chrome
       - name: Run tests (${{ matrix.os }} - Chrome)
         if: matrix.os == 'ubuntu-latest' && matrix.browser == 'chrome'
-        run: cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
+        run: |
+          export WEBDRIVER_PATH="${{ steps.setup-chrome.outputs.chromedriver-path }}"
+          export BROWSER_PATH="${{ steps.setup-chrome.outputs.chrome-path }}"
+          cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
 
       # Install xvfb for Firefox WebGL support
       - name: Install xvfb
@@ -146,6 +152,7 @@ jobs:
         if: matrix.os == 'ubuntu-latest' && matrix.browser == 'firefox'
         run: |
           # Set environment variables for Firefox WebDriver
+          export WEBDRIVER_PATH="/usr/local/share/gecko_driver"
           export BROWSER_PATH="${{ steps.setup-firefox.outputs.firefox-path }}"
           export RUST_LOG="debug"
           export RUST_BACKTRACE="1"
@@ -159,7 +166,10 @@ jobs:
       # Run tests on macOS with Chrome
       - name: Run tests (${{ matrix.os }} - Chrome)
         if: matrix.os == 'macos-latest' && matrix.browser == 'chrome'
-        run: cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
+        run: |
+          export WEBDRIVER_PATH="${{ steps.setup-chrome.outputs.chromedriver-path }}"
+          export BROWSER_PATH="${{ steps.setup-chrome.outputs.chrome-path }}"
+          cargo test --workspace --features ${{ matrix.features }} --exclude plotly_kaleido
 
       # Run tests on Windows with Chrome WebDriver
       - name: Run tests (${{ matrix.os }} - Chrome)

plotly_static/build.rs

@@ -174,19 +174,19 @@ fn setup_driver(config: &WebdriverDownloadConfig) -> Result<()> {
     match config.driver_name {
         CHROMEDRIVER_NAME => {
             let driver_info = ChromedriverInfo::new(webdriver_bin.clone(), browser_path);
-            runtime
-                .block_on(async { download_with_retry(&driver_info, false, true, 1).await })
-                .with_context(|| {
-                    format!("Failed to download and install {}", config.driver_name)
-                })?;
+            let dl_res = runtime
+                .block_on(async { download_with_retry(&driver_info, false, true, 1).await });
+            if let Err(e) = dl_res {
+                return Err(anyhow!("Failed to download and install chromedriver").context(e));
+            }
         }
         GECKODRIVER_NAME => {
             let driver_info = GeckodriverInfo::new(webdriver_bin.clone(), browser_path);
-            runtime
-                .block_on(async { download_with_retry(&driver_info, false, true, 1).await })
-                .with_context(|| {
-                    format!("Failed to download and install {}", config.driver_name)
-                })?;
+            let dl_res = runtime
+                .block_on(async { download_with_retry(&driver_info, false, true, 1).await });
+            if let Err(e) = dl_res {
+                return Err(anyhow!("Failed to download and install geckodriver").context(e));
+            }
         }
         _ => return Err(anyhow!("Unsupported driver type: {}", config.driver_name)),
     }