Merge pull request #275 from planetscale/st-creation-name

Send `name` when creating a service token

Author: joshmgross

planetscale/service_tokens.go

@@ -26,7 +26,7 @@ type serviceTokenService struct {
 }
 
 func (s *serviceTokenService) Create(ctx context.Context, createReq *CreateServiceTokenRequest) (*ServiceToken, error) {
-	req, err := s.client.newRequest(http.MethodPost, serviceTokensAPIPath(createReq.Organization), nil)
+	req, err := s.client.newRequest(http.MethodPost, serviceTokensAPIPath(createReq.Organization), createReq)
 	if err != nil {
 		return nil, err
 	}

planetscale/service_tokens_test.go

@@ -14,22 +14,29 @@ import (
 func TestServiceTokens_Create(t *testing.T) {
 	c := qt.New(t)
 
+	wantBody := []byte("{\"name\":\"my-token\"}\n")
+
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(200)
+		data, err := io.ReadAll(r.Body)
+		c.Assert(err, qt.IsNil)
+		c.Assert(data, qt.DeepEquals, wantBody)
+
 		out := `{"id":"test-id","type":"ServiceToken","token":"d2980bbd91a4ab878601ef0573a7af7b1b15e705","name":"my-token","created_at":"2021-01-14T10:19:23.000Z","last_used_at":"2021-01-15T12:30:00.000Z"}`
-		_, err := w.Write([]byte(out))
+		_, err = w.Write([]byte(out))
 		c.Assert(err, qt.IsNil)
 	}))
 
 	client, err := NewClient(WithBaseURL(ts.URL))
 	c.Assert(err, qt.IsNil)
 
 	ctx := context.Background()
+	tokenName := "my-token"
 
 	snapshot, err := client.ServiceTokens.Create(ctx, &CreateServiceTokenRequest{
 		Organization: testOrg,
+		Name:         &tokenName,
 	})
-	tokenName := "my-token"
 	lastUsedAt := time.Date(2021, 1, 15, 12, 30, 0, 0, time.UTC)
 	want := &ServiceToken{
 		ID:         "test-id",