Fix --quiet --json combination suppressing command output (#72)

austin-denoble · web-flow · commit 42e103938ccd · 2026-03-19T16:54:40.000-04:00
## Problem Currently, passing `--quiet --json` to commands ends up suppressing the expected JSON output due to `pcio`. We're going to most likely remove `pcio` entirely in a future PR. ## Solution Make sure `--quiet --json` flag comination doesn't suppress command output, add `pcio.PrintJSON` that writes directly to stdout and replace `pcio.Println` across commands. ## Type of Change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan Run commands with `--json --quiet` and make sure you're seeing JSON in stdout.  --- > [!NOTE] > **Low Risk** > Low risk: output-path change only, routing JSON to stdout regardless of quiet mode; potential risk is minor formatting/stream changes for scripts expecting previous suppression behavior. > > **Overview** > Fixes the `--quiet --json` combination by adding `pcio.PrintJSON` (always writes to stdout) and switching JSON output paths across CLI commands from `pcio.Println` to `pcio.PrintJSON`. > > This ensures machine-readable JSON is emitted even in quiet mode for commands like API key, auth, backup restore, collections, indexes/namespaces/records/vectors, organizations, projects, and target, and adds unit tests covering `PrintJSON` vs `Println` behavior under quiet mode. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 07d74a1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>
diff --git a/internal/pkg/cli/command/apiKey/create.go b/internal/pkg/cli/command/apiKey/create.go
@@ -96,7 +96,7 @@ func NewCreateApiKeyCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(keyWithSecret)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				msg.SuccessMsg("API key %s created successfully.\n", style.Emphasis(keyWithSecret.Key.Name))
 				presenters.PrintDescribeAPIKeyWithSecretTable(keyWithSecret)
diff --git a/internal/pkg/cli/command/apiKey/describe.go b/internal/pkg/cli/command/apiKey/describe.go
@@ -39,7 +39,7 @@ func NewDescribeAPIKeyCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(apiKey)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				presenters.PrintDescribeAPIKeyTable(apiKey)
 			}
diff --git a/internal/pkg/cli/command/apiKey/list.go b/internal/pkg/cli/command/apiKey/list.go
@@ -65,7 +65,7 @@ func NewListKeysCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(sortedKeys)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				printTable(sortedKeys)
 			}
diff --git a/internal/pkg/cli/command/apiKey/update.go b/internal/pkg/cli/command/apiKey/update.go
@@ -50,7 +50,7 @@ func NewUpdateAPIKeyCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(apiKey)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 				return
 			}
 
diff --git a/internal/pkg/cli/command/auth/configure.go b/internal/pkg/cli/command/auth/configure.go
@@ -240,7 +240,7 @@ func Run(ctx context.Context, io IO, opts configureCmdOptions) {
 		defaultAPIKey := secrets.DefaultAPIKey.Get()
 		targetContext.DefaultAPIKey = presenters.MaskHeadTail(defaultAPIKey, 4, 4)
 		json := text.IndentJSON(targetContext)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 		return
 	}
 
diff --git a/internal/pkg/cli/command/auth/local_keys_list.go b/internal/pkg/cli/command/auth/local_keys_list.go
@@ -42,7 +42,7 @@ func NewListLocalKeysCmd() *cobra.Command {
 			if options.json {
 				maskedMap := maskForJSON(managedKeys, options.reveal)
 				json := text.IndentJSON(maskedMap)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				printTable(managedKeys, options.reveal)
 			}
diff --git a/internal/pkg/cli/command/auth/local_keys_prune.go b/internal/pkg/cli/command/auth/local_keys_prune.go
@@ -215,7 +215,7 @@ func confirmPruneKeys(plan []planItem, options pruneLocalKeysCmdOptions) (bool,
 func printDryRunPlan(plan []planItem, options pruneLocalKeysCmdOptions) {
 	if options.json {
 		json := text.IndentJSON(plan)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		for _, key := range plan {
 			if key.onServer {
diff --git a/internal/pkg/cli/command/auth/status.go b/internal/pkg/cli/command/auth/status.go
@@ -99,7 +99,7 @@ func runAuthStatus(cmd *cobra.Command, options authStatusCmdOptions) error {
 
 	if options.json {
 		json := text.IndentJSON(authStatus)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 		return nil
 	}
 
diff --git a/internal/pkg/cli/command/backup/restore/cmd.go b/internal/pkg/cli/command/backup/restore/cmd.go
@@ -113,7 +113,7 @@ func runRestoreJobCmd(ctx context.Context, svc RestoreJobService, options restor
 	}
 
 	if options.json {
-		pcio.Println(text.IndentJSON(resp))
+		pcio.PrintJSON(text.IndentJSON(resp))
 		return nil
 	}
 
diff --git a/internal/pkg/cli/command/backup/restore/describe.go b/internal/pkg/cli/command/backup/restore/describe.go
@@ -58,7 +58,7 @@ func runDescribeRestoreJobCmd(ctx context.Context, svc RestoreJobService, option
 	}
 
 	if options.json {
-		pcio.Println(text.IndentJSON(resp))
+		pcio.PrintJSON(text.IndentJSON(resp))
 	} else {
 		presenters.PrintRestoreJob(resp)
 	}
diff --git a/internal/pkg/cli/command/backup/restore/list.go b/internal/pkg/cli/command/backup/restore/list.go
@@ -69,7 +69,7 @@ func runListRestoreJobsCmd(ctx context.Context, svc RestoreJobService, options l
 	}
 
 	if options.json {
-		pcio.Println(text.IndentJSON(resp))
+		pcio.PrintJSON(text.IndentJSON(resp))
 	} else {
 		presenters.PrintRestoreJobList(resp)
 	}
diff --git a/internal/pkg/cli/command/collection/create.go b/internal/pkg/cli/command/collection/create.go
@@ -45,7 +45,7 @@ func NewCreateCollectionCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(collection)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				describeCommand := pcio.Sprintf("pc collection describe --name %s", collection.Name)
 				msg.SuccessMsg("Collection %s created successfully. Run %s to check status. \n\n", style.Emphasis(collection.Name), style.Code(describeCommand))
diff --git a/internal/pkg/cli/command/collection/describe.go b/internal/pkg/cli/command/collection/describe.go
@@ -37,7 +37,7 @@ func NewDescribeCollectionCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(collection)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				presenters.PrintDescribeCollectionTable(collection)
 			}
diff --git a/internal/pkg/cli/command/collection/list.go b/internal/pkg/cli/command/collection/list.go
@@ -47,7 +47,7 @@ func NewListCollectionsCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(collections)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				printTable(collections)
 			}
diff --git a/internal/pkg/cli/command/index/configure.go b/internal/pkg/cli/command/index/configure.go
@@ -136,7 +136,7 @@ func runConfigureIndexCmd(ctx context.Context, cmd *cobra.Command, options confi
 
 	if options.json {
 		json := text.IndentJSON(idx)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 		return
 	}
 
diff --git a/internal/pkg/cli/command/index/create.go b/internal/pkg/cli/command/index/create.go
@@ -309,7 +309,7 @@ func runCreateIndexCmd(ctx context.Context, cmd *cobra.Command, service CreateIn
 func renderSuccessOutput(idx *pinecone.Index, options createIndexOptions) {
 	if options.json {
 		json := text.IndentJSON(idx)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 		return
 	}
 
diff --git a/internal/pkg/cli/command/index/describe.go b/internal/pkg/cli/command/index/describe.go
@@ -45,7 +45,7 @@ func NewDescribeCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(idx)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				presenters.PrintDescribeIndexTable(idx)
 			}
diff --git a/internal/pkg/cli/command/index/describe_stats.go b/internal/pkg/cli/command/index/describe_stats.go
@@ -77,7 +77,7 @@ func runDescribeIndexStatsCmd(ctx context.Context, options describeIndexStatsCmd
 
 	if options.json {
 		json := text.IndentJSON(resp)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		presenters.PrintDescribeIndexStatsTable(resp)
 	}
diff --git a/internal/pkg/cli/command/index/list.go b/internal/pkg/cli/command/index/list.go
@@ -47,7 +47,7 @@ func NewListCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(idxs)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				printTable(idxs, options.wide)
 			}
diff --git a/internal/pkg/cli/command/index/namespace/create.go b/internal/pkg/cli/command/index/namespace/create.go
@@ -96,7 +96,7 @@ func runCreateNamespaceCmd(ctx context.Context, ic NamespaceService, options cre
 
 	if options.json {
 		json := text.IndentJSON(ns)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		msg.SuccessMsg("Namespace %s created successfully.", options.name)
 		presenters.PrintDescribeNamespaceTable(ns)
diff --git a/internal/pkg/cli/command/index/namespace/describe.go b/internal/pkg/cli/command/index/namespace/describe.go
@@ -80,7 +80,7 @@ func runDescribeNamespaceCmd(ctx context.Context, ic NamespaceService, options d
 
 	if options.json {
 		json := text.IndentJSON(ns)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		presenters.PrintDescribeNamespaceTable(ns)
 	}
diff --git a/internal/pkg/cli/command/index/namespace/list.go b/internal/pkg/cli/command/index/namespace/list.go
@@ -109,7 +109,7 @@ func runListNamespaceCmd(ctx context.Context, ic NamespaceService, options listN
 
 	if options.json {
 		json := text.IndentJSON(resp)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		printTable(resp)
 	}
diff --git a/internal/pkg/cli/command/index/record/search.go b/internal/pkg/cli/command/index/record/search.go
@@ -265,7 +265,7 @@ func runSearchCmd(ctx context.Context, ic RecordService, options searchCmdOption
 	}
 
 	if options.json {
-		pcio.Println(text.IndentJSON(resp))
+		pcio.PrintJSON(text.IndentJSON(resp))
 	} else {
 		presenters.PrintSearchRecordsTable(resp)
 	}
diff --git a/internal/pkg/cli/command/index/record/upsert.go b/internal/pkg/cli/command/index/record/upsert.go
@@ -130,7 +130,7 @@ func runUpsertCmd(ctx context.Context, ic RecordService, options upsertCmdOption
 				"records":   len(batch),
 				"namespace": options.namespace,
 			}
-			pcio.Println(text.IndentJSON(summary))
+			pcio.PrintJSON(text.IndentJSON(summary))
 		} else {
 			msg.SuccessMsg("Upserted %d records into namespace %s (batch %d of %d)", len(batch), options.namespace, i+1, len(batches))
 		}
diff --git a/internal/pkg/cli/command/index/vector/fetch.go b/internal/pkg/cli/command/index/vector/fetch.go
@@ -159,7 +159,7 @@ func runFetchCmd(ctx context.Context, options fetchCmdOptions) {
 func printFetchVectorsResults(results *presenters.FetchVectorsResults, options fetchCmdOptions) {
 	if options.json {
 		json := text.IndentJSON(results)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		presenters.PrintFetchVectorsTable(results)
 	}
diff --git a/internal/pkg/cli/command/index/vector/list_vectors.go b/internal/pkg/cli/command/index/vector/list_vectors.go
@@ -76,7 +76,7 @@ func runListVectorsCmd(ctx context.Context, options listVectorsCmdOptions) {
 
 	if options.json {
 		json := text.IndentJSON(resp)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		presenters.PrintListVectorsTable(resp)
 	}
diff --git a/internal/pkg/cli/command/index/vector/query.go b/internal/pkg/cli/command/index/vector/query.go
@@ -208,7 +208,7 @@ func runQueryCmd(ctx context.Context, options queryCmdOptions) {
 
 	if options.json {
 		json := text.IndentJSON(queryResponse)
-		pcio.Println(json)
+		pcio.PrintJSON(json)
 	} else {
 		presenters.PrintQueryVectorsTable(queryResponse)
 	}
diff --git a/internal/pkg/cli/command/index/vector/update.go b/internal/pkg/cli/command/index/vector/update.go
@@ -197,7 +197,7 @@ func runUpdateCmd(ctx context.Context, options updateCmdOptions) {
 			presenters.PrintUpdateVectorsByMetadataTable(resp)
 		} else {
 			json := text.IndentJSON(resp)
-			pcio.Println(json)
+			pcio.PrintJSON(json)
 		}
 		return
 	}
diff --git a/internal/pkg/cli/command/index/vector/upsert.go b/internal/pkg/cli/command/index/vector/upsert.go
@@ -136,7 +136,7 @@ func runUpsertCmd(ctx context.Context, options upsertCmdOptions) {
 		} else {
 			if options.json {
 				json := text.IndentJSON(resp)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				msg.SuccessMsg("Upserted %d vectors into namespace %s (batch %d of %d)", len(batch), options.namespace, i+1, len(batches))
 			}
diff --git a/internal/pkg/cli/command/organization/describe.go b/internal/pkg/cli/command/organization/describe.go
@@ -50,7 +50,7 @@ func NewDescribeOrganizationCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(org)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				presenters.PrintDescribeOrganizationTable(org)
 			}
diff --git a/internal/pkg/cli/command/organization/list.go b/internal/pkg/cli/command/organization/list.go
@@ -41,7 +41,7 @@ func NewListOrganizationsCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(orgs)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 				return
 			}
 
diff --git a/internal/pkg/cli/command/organization/update.go b/internal/pkg/cli/command/organization/update.go
@@ -58,7 +58,7 @@ func NewUpdateOrganizationCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(org)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 				return
 			}
 
diff --git a/internal/pkg/cli/command/project/create.go b/internal/pkg/cli/command/project/create.go
@@ -69,7 +69,7 @@ func NewCreateProjectCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(proj)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 				return
 			}
 
diff --git a/internal/pkg/cli/command/project/describe.go b/internal/pkg/cli/command/project/describe.go
@@ -50,7 +50,7 @@ func NewDescribeProjectCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(project)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				presenters.PrintDescribeProjectTable(project)
 			}
diff --git a/internal/pkg/cli/command/project/list.go b/internal/pkg/cli/command/project/list.go
@@ -42,7 +42,7 @@ func NewListProjectsCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(projects)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 			} else {
 				printTable(projects)
 			}
diff --git a/internal/pkg/cli/command/project/update.go b/internal/pkg/cli/command/project/update.go
@@ -67,7 +67,7 @@ func NewUpdateProjectCmd() *cobra.Command {
 
 			if options.json {
 				json := text.IndentJSON(project)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 				return
 			}
 
diff --git a/internal/pkg/cli/command/target/target.go b/internal/pkg/cli/command/target/target.go
@@ -101,7 +101,7 @@ func NewTargetCmd() *cobra.Command {
 					defaultAPIKey := secrets.DefaultAPIKey.Get()
 					targetContext.DefaultAPIKey = presenters.MaskHeadTail(defaultAPIKey, 4, 4)
 					json := text.IndentJSON(targetContext)
-					pcio.Println(json)
+					pcio.PrintJSON(json)
 					return
 				}
 				log.Info().
@@ -260,7 +260,7 @@ func NewTargetCmd() *cobra.Command {
 				defaultAPIKey := secrets.DefaultAPIKey.Get()
 				targetContext.DefaultAPIKey = presenters.MaskHeadTail(defaultAPIKey, 4, 4)
 				json := text.IndentJSON(targetContext)
-				pcio.Println(json)
+				pcio.PrintJSON(json)
 				return
 			}
 
diff --git a/internal/pkg/utils/pcio/print.go b/internal/pkg/utils/pcio/print.go
@@ -3,6 +3,7 @@ package pcio
 import (
 	"fmt"
 	"io"
+	"os"
 )
 
 // The purpose of this package is to stub out the fmt package so that
@@ -15,6 +16,13 @@ func SetQuiet(q bool) {
 	quiet = q
 }
 
+// PrintJSON writes s to stdout regardless of quiet mode.
+// Use this instead of Println when outputting structured JSON so that
+// --quiet does not suppress machine-readable output.
+func PrintJSON(s string) {
+	fmt.Fprintln(os.Stdout, s)
+}
+
 func Println(a ...any) {
 	if !quiet {
 		fmt.Println(a...)
diff --git a/internal/pkg/utils/pcio/print_test.go b/internal/pkg/utils/pcio/print_test.go

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func NewDescribeAPIKeyCmd() *cobra.Command {`
`39`	`39`
`40`	`40`	`if options.json {`
`41`	`41`	`json := text.IndentJSON(apiKey)`
`42`		`- pcio.Println(json)`
	`42`	`+ pcio.PrintJSON(json)`
`43`	`43`	`} else {`
`44`	`44`	`presenters.PrintDescribeAPIKeyTable(apiKey)`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ func NewListKeysCmd() *cobra.Command {`
`65`	`65`
`66`	`66`	`if options.json {`
`67`	`67`	`json := text.IndentJSON(sortedKeys)`
`68`		`- pcio.Println(json)`
	`68`	`+ pcio.PrintJSON(json)`
`69`	`69`	`} else {`
`70`	`70`	`printTable(sortedKeys)`
`71`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func NewUpdateAPIKeyCmd() *cobra.Command {`
`50`	`50`
`51`	`51`	`if options.json {`
`52`	`52`	`json := text.IndentJSON(apiKey)`
`53`		`- pcio.Println(json)`
	`53`	`+ pcio.PrintJSON(json)`
`54`	`54`	`return`
`55`	`55`	`}`
`56`	`56`
Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ func Run(ctx context.Context, io IO, opts configureCmdOptions) {`
`240`	`240`	`defaultAPIKey := secrets.DefaultAPIKey.Get()`
`241`	`241`	`targetContext.DefaultAPIKey = presenters.MaskHeadTail(defaultAPIKey, 4, 4)`
`242`	`242`	`json := text.IndentJSON(targetContext)`
`243`		`- pcio.Println(json)`
	`243`	`+ pcio.PrintJSON(json)`
`244`	`244`	`return`
`245`	`245`	`}`
`246`	`246`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func NewListLocalKeysCmd() *cobra.Command {`
`42`	`42`	`if options.json {`
`43`	`43`	`maskedMap := maskForJSON(managedKeys, options.reveal)`
`44`	`44`	`json := text.IndentJSON(maskedMap)`
`45`		`- pcio.Println(json)`
	`45`	`+ pcio.PrintJSON(json)`
`46`	`46`	`} else {`
`47`	`47`	`printTable(managedKeys, options.reveal)`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ func runAuthStatus(cmd *cobra.Command, options authStatusCmdOptions) error {`
`99`	`99`
`100`	`100`	`if options.json {`
`101`	`101`	`json := text.IndentJSON(authStatus)`
`102`		`- pcio.Println(json)`
	`102`	`+ pcio.PrintJSON(json)`
`103`	`103`	`return nil`
`104`	`104`	`}`
`105`	`105`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ func runRestoreJobCmd(ctx context.Context, svc RestoreJobService, options restor`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`if options.json {`
`116`		`- pcio.Println(text.IndentJSON(resp))`
	`116`	`+ pcio.PrintJSON(text.IndentJSON(resp))`
`117`	`117`	`return nil`
`118`	`118`	`}`
`119`	`119`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func runDescribeRestoreJobCmd(ctx context.Context, svc RestoreJobService, option`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`if options.json {`
`61`		`- pcio.Println(text.IndentJSON(resp))`
	`61`	`+ pcio.PrintJSON(text.IndentJSON(resp))`
`62`	`62`	`} else {`
`63`	`63`	`presenters.PrintRestoreJob(resp)`
`64`	`64`	`}`