Allow BcMath\Number increment/decrement

Author: mpesari

src/Rules/Operators/OperatorRuleHelper.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node\Expr;
 use PHPStan\Analyser\Scope;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Type\Accessory\AccessoryNumericStringType;
 use PHPStan\Type\BenevolentUnionType;
@@ -12,6 +13,7 @@
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\MixedType;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
@@ -21,9 +23,12 @@ class OperatorRuleHelper
 
 	private RuleLevelHelper $ruleLevelHelper;
 
-	public function __construct(RuleLevelHelper $ruleLevelHelper)
+	private PhpVersion $phpVersion;
+
+	public function __construct(RuleLevelHelper $ruleLevelHelper, PhpVersion $phpVersion)
 	{
 		$this->ruleLevelHelper = $ruleLevelHelper;
+		$this->phpVersion = $phpVersion;
 	}
 
 	public function isValidForArithmeticOperation(Scope $scope, Expr $expr): bool
@@ -68,7 +73,13 @@ public function isValidForDecrement(Scope $scope, Expr $expr): bool
 
 	private function isSubtypeOfNumber(Scope $scope, Expr $expr): bool
 	{
-		$acceptedType = new UnionType([new IntegerType(), new FloatType(), new IntersectionType([new StringType(), new AccessoryNumericStringType()])]);
+		$acceptedTypes = [new IntegerType(), new FloatType(), new IntersectionType([new StringType(), new AccessoryNumericStringType()])];
+
+		if ($this->phpVersion->supportsBcMathNumberOperatorOverloading()) {
+			$acceptedTypes[] = new ObjectType('BcMath\Number');
+		}
+
+		$acceptedType = new UnionType($acceptedTypes);
 
 		$type = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,

tests/Rules/Operators/OperandInArithmeticIncrementOrDecrementRuleTestCase.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Operators;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
@@ -18,6 +19,7 @@ protected function getRule(): Rule
 		return $this->createRule(
 			new OperatorRuleHelper(
 				self::getContainer()->getByType(RuleLevelHelper::class),
+				self::getContainer()->getByType(PhpVersion::class),
 			),
 		);
 	}

tests/Rules/Operators/OperandInArithmeticPostDecrementRuleTest.php

@@ -49,12 +49,7 @@ protected function getExpectedErrors(): array
 	 */
 	protected function getExpectedErrorsWithBcMath(): array
 	{
-		return [
-			[
-				'Only numeric types are allowed in post-decrement, BcMath\Number given.',
-				8,
-			],
-		];
+		return [];
 	}
 
 }

tests/Rules/Operators/OperandInArithmeticPostIncrementRuleTest.php

@@ -45,12 +45,7 @@ protected function getExpectedErrors(): array
 	 */
 	protected function getExpectedErrorsWithBcMath(): array
 	{
-		return [
-			[
-				'Only numeric types are allowed in post-increment, BcMath\Number given.',
-				12,
-			],
-		];
+		return [];
 	}
 
 }

tests/Rules/Operators/OperandInArithmeticPreDecrementRuleTest.php

@@ -49,12 +49,7 @@ protected function getExpectedErrors(): array
 	 */
 	protected function getExpectedErrorsWithBcMath(): array
 	{
-		return [
-			[
-				'Only numeric types are allowed in pre-decrement, BcMath\Number given.',
-				16,
-			],
-		];
+		return [];
 	}
 
 }

tests/Rules/Operators/OperandInArithmeticPreIncrementRuleTest.php

@@ -45,12 +45,7 @@ protected function getExpectedErrors(): array
 	 */
 	protected function getExpectedErrorsWithBcMath(): array
 	{
-		return [
-			[
-				'Only numeric types are allowed in pre-increment, BcMath\Number given.',
-				20,
-			],
-		];
+		return [];
 	}
 
 }

tests/Rules/Operators/OperandInArithmeticUnaryMinusRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Operators;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
@@ -17,6 +18,7 @@ protected function getRule(): Rule
 		return new OperandInArithmeticUnaryMinusRule(
 			new OperatorRuleHelper(
 				self::getContainer()->getByType(RuleLevelHelper::class),
+				self::getContainer()->getByType(PhpVersion::class),
 			),
 		);
 	}

tests/Rules/Operators/OperandInArithmeticUnaryPlusRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Operators;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
@@ -17,6 +18,7 @@ protected function getRule(): Rule
 		return new OperandInArithmeticUnaryPlusRule(
 			new OperatorRuleHelper(
 				self::getContainer()->getByType(RuleLevelHelper::class),
+				self::getContainer()->getByType(PhpVersion::class),
 			),
 		);
 	}

tests/Rules/Operators/OperandsInArithmeticAdditionRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Operators;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
@@ -19,6 +20,7 @@ protected function getRule(): Rule
 		return new OperandsInArithmeticAdditionRule(
 			new OperatorRuleHelper(
 				self::getContainer()->getByType(RuleLevelHelper::class),
+				self::getContainer()->getByType(PhpVersion::class),
 			),
 		);
 	}

tests/Rules/Operators/OperandsInArithmeticDivisionRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Operators;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
@@ -17,6 +18,7 @@ protected function getRule(): Rule
 		return new OperandsInArithmeticDivisionRule(
 			new OperatorRuleHelper(
 				self::getContainer()->getByType(RuleLevelHelper::class),
+				self::getContainer()->getByType(PhpVersion::class),
 			),
 		);
 	}