property_exists does not need to narrow non-object to object|class-string

Author: ondrejmirtes

src/Type/Php/PropertyExistsTypeSpecifyingExtension.php

@@ -15,12 +15,10 @@
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Rules\Properties\PropertyReflectionFinder;
 use PHPStan\Type\Accessory\HasPropertyType;
-use PHPStan\Type\ClassStringType;
 use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\FunctionTypeSpecifyingExtension;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\ObjectWithoutClassType;
-use PHPStan\Type\UnionType;
 use function count;
 
 #[AutowiredService]
@@ -80,18 +78,7 @@ public function specifyTypes(
 		}
 
 		if (!$objectOrStringType->isObject()->yes()) {
-			return $this->typeSpecifier->create(
-				$args[0]->value,
-				new UnionType([
-					new IntersectionType([
-						new ObjectWithoutClassType(),
-						new HasPropertyType($propertyNameType->getValue()),
-					]),
-					new ClassStringType(),
-				]),
-				$context,
-				$scope,
-			);
+			return new SpecifiedTypes([], []);
 		}
 
 		$propertyNode = new PropertyFetch(

tests/PHPStan/Analyser/nsrt/bug-2861.php

@@ -9,7 +9,7 @@
  */
 function testObjectOrString($objectOrClass): void {
 	if (property_exists($objectOrClass, 'foo')) {
-		assertType('class-string|(object&hasProperty(foo))', $objectOrClass);
+		assertType('object|string', $objectOrClass);
 	}
 }
 
@@ -18,6 +18,6 @@ function testObjectOrString($objectOrClass): void {
  */
 function testObjectOrClassString($objectOrClass): void {
 	if (property_exists($objectOrClass, 'bar')) {
-		assertType('class-string|(object&hasProperty(bar))', $objectOrClass);
+		assertType('class-string|object', $objectOrClass);
 	}
 }