From a989310224981546e330ed16657cf744576c7688 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Thu, 16 Apr 2026 16:40:30 -0700 Subject: [PATCH 1/3] Update view online test some more --- tests/functional/viewonline_test.php | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/tests/functional/viewonline_test.php b/tests/functional/viewonline_test.php index c18ade0b..5b892c01 100644 --- a/tests/functional/viewonline_test.php +++ b/tests/functional/viewonline_test.php @@ -16,27 +16,14 @@ class viewonline_test extends boardrules_functional_base { /** - * Create a fresh admin session on the board rules page. + * Test viewonline page for admin */ - protected function visit_rules_as_admin() + public function test_viewonline_check_viewonline() { - $db = $this->get_db(); - - // XXX hardcoded user id - $sql = 'DELETE FROM ' . SESSIONS_TABLE . ' WHERE session_user_id = 2'; - $db->sql_query($sql); - + // Visit Ideas as user "admin" $this->login(); $crawler = self::request('GET', "app.php/rules?sid=$this->sid"); $this->assertContainsLang('BOARDRULES_HEADER', $crawler->filter('h2')->text()); - } - - /** - * Test viewonline page for admin - */ - public function test_viewonline_check_viewonline() - { - $this->visit_rules_as_admin(); // Create a second user and check who is online from a separate session. self::$client->restart(); From 73eaee3c336d0f9ba6f14f8838a8e35677c7b7e4 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Thu, 16 Apr 2026 16:47:56 -0700 Subject: [PATCH 2/3] Revert "Update view online test some more" This reverts commit a989310224981546e330ed16657cf744576c7688. --- tests/functional/viewonline_test.php | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/tests/functional/viewonline_test.php b/tests/functional/viewonline_test.php index 5b892c01..c18ade0b 100644 --- a/tests/functional/viewonline_test.php +++ b/tests/functional/viewonline_test.php @@ -16,14 +16,27 @@ class viewonline_test extends boardrules_functional_base { /** - * Test viewonline page for admin + * Create a fresh admin session on the board rules page. */ - public function test_viewonline_check_viewonline() + protected function visit_rules_as_admin() { - // Visit Ideas as user "admin" + $db = $this->get_db(); + + // XXX hardcoded user id + $sql = 'DELETE FROM ' . SESSIONS_TABLE . ' WHERE session_user_id = 2'; + $db->sql_query($sql); + $this->login(); $crawler = self::request('GET', "app.php/rules?sid=$this->sid"); $this->assertContainsLang('BOARDRULES_HEADER', $crawler->filter('h2')->text()); + } + + /** + * Test viewonline page for admin + */ + public function test_viewonline_check_viewonline() + { + $this->visit_rules_as_admin(); // Create a second user and check who is online from a separate session. self::$client->restart(); From 7736dc382a50b98e0e86433a87f0cb34bb4f7e08 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Thu, 16 Apr 2026 16:48:37 -0700 Subject: [PATCH 3/3] Update view online test some more --- tests/functional/viewonline_test.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/viewonline_test.php b/tests/functional/viewonline_test.php index c18ade0b..641a3298 100644 --- a/tests/functional/viewonline_test.php +++ b/tests/functional/viewonline_test.php @@ -22,7 +22,7 @@ protected function visit_rules_as_admin() { $db = $this->get_db(); - // XXX hardcoded user id + // Visit Ideas as user "admin" $sql = 'DELETE FROM ' . SESSIONS_TABLE . ' WHERE session_user_id = 2'; $db->sql_query($sql);